From: Jiri Slaby <jirislaby@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net, pabeni@redhat.com
Cc: netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH net-next 3/6] net: atm: remove support for ZeitNet ZN122x ATM devices
Date: Wed, 10 Aug 2022 09:36:24 +0200 [thread overview]
Message-ID: <8576aef3-37e4-8bae-bab5-08f82a78efd3@kernel.org> (raw)
In-Reply-To: <20220426175436.417283-4-kuba@kernel.org>
On 26. 04. 22, 19:54, Jakub Kicinski wrote:
> This driver received nothing but automated fixes in the last 15 years.
> Since it's using virt_to_bus it's unlikely to be used on any modern
> platform.
...
> delete mode 100644 include/uapi/linux/atm_zatm.h
This unfortunately breaks linux-atm:
zntune.c:18:10: fatal error: linux/atm_zatm.h: No such file or directory
The source does also:
ioctl(s,ZATM_SETPOOL,&sioc)
ioctl(s,zero ? ZATM_GETPOOLZ : ZATM_GETPOOL,&sioc)
etc.
So we should likely revert the below:
> --- a/include/uapi/linux/atm_zatm.h
> +++ /dev/null
> @@ -1,47 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -/* atm_zatm.h - Driver-specific declarations of the ZATM driver (for use by
> - driver-specific utilities) */
> -
> -/* Written 1995-1999 by Werner Almesberger, EPFL LRC/ICA */
> -
> -
> -#ifndef LINUX_ATM_ZATM_H
> -#define LINUX_ATM_ZATM_H
> -
> -/*
> - * Note: non-kernel programs including this file must also include
> - * sys/types.h for struct timeval
> - */
> -
> -#include <linux/atmapi.h>
> -#include <linux/atmioc.h>
> -
> -#define ZATM_GETPOOL _IOW('a',ATMIOC_SARPRV+1,struct atmif_sioc)
> - /* get pool statistics */
> -#define ZATM_GETPOOLZ _IOW('a',ATMIOC_SARPRV+2,struct atmif_sioc)
> - /* get statistics and zero */
> -#define ZATM_SETPOOL _IOW('a',ATMIOC_SARPRV+3,struct atmif_sioc)
> - /* set pool parameters */
> -
> -struct zatm_pool_info {
> - int ref_count; /* free buffer pool usage counters */
> - int low_water,high_water; /* refill parameters */
> - int rqa_count,rqu_count; /* queue condition counters */
> - int offset,next_off; /* alignment optimizations: offset */
> - int next_cnt,next_thres; /* repetition counter and threshold */
> -};
> -
> -struct zatm_pool_req {
> - int pool_num; /* pool number */
> - struct zatm_pool_info info; /* actual information */
> -};
> -
> -#define ZATM_OAM_POOL 0 /* free buffer pool for OAM cells */
> -#define ZATM_AAL0_POOL 1 /* free buffer pool for AAL0 cells */
> -#define ZATM_AAL5_POOL_BASE 2 /* first AAL5 free buffer pool */
> -#define ZATM_LAST_POOL ZATM_AAL5_POOL_BASE+10 /* max. 64 kB */
> -
> -#define ZATM_TIMER_HISTORY_SIZE 16 /* number of timer adjustments to
> - record; must be 2^n */
> -
> -#endif
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-08-10 7:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 17:54 [PATCH net-next 0/6] net: remove non-Ethernet drivers using virt_to_bus() Jakub Kicinski
2022-04-26 17:54 ` [PATCH net-next 1/6] net: atm: remove support for Fujitsu FireStream ATM devices Jakub Kicinski
2022-04-26 17:54 ` [PATCH net-next 2/6] net: atm: remove support for Madge Horizon " Jakub Kicinski
2022-04-26 17:54 ` [PATCH net-next 3/6] net: atm: remove support for ZeitNet ZN122x " Jakub Kicinski
2022-08-10 7:36 ` Jiri Slaby [this message]
2022-08-10 9:11 ` Arnd Bergmann
2022-08-10 16:42 ` Jakub Kicinski
2022-08-11 5:19 ` Jiri Slaby
2022-08-11 9:18 ` Arnd Bergmann
2022-04-26 17:54 ` [PATCH net-next 4/6] net: wan: remove support for COSA and SRP synchronous serial boards Jakub Kicinski
2022-04-26 17:54 ` [PATCH net-next 5/6] net: wan: remove support for Z85230-based devices Jakub Kicinski
2022-04-26 17:54 ` [PATCH net-next 6/6] net: hamradio: remove support for DMA SCC devices Jakub Kicinski
2022-04-26 18:55 ` Thomas Osterried
2022-04-26 19:39 ` Jakub Kicinski
2022-04-27 13:27 ` Arnd Bergmann
2022-05-02 1:01 ` Thomas Osterried
2022-04-27 11:30 ` [PATCH net-next 0/6] net: remove non-Ethernet drivers using virt_to_bus() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8576aef3-37e4-8bae-bab5-08f82a78efd3@kernel.org \
--to=jirislaby@kernel.org \
--cc=3chas3@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.