All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libp11: needs threads
@ 2022-07-19 21:56 Fabrice Fontaine
  2022-07-20 11:45 ` Thomas Petazzoni via buildroot
  2022-08-11 11:36 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-07-19 21:56 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

threads are mandatory since bump to version 0.4.12 in commit
86ab91483dcb4b60de8c1daa20e2f42bd95ab5fb and
https://github.com/OpenSC/libp11/commit/4bd92da60a670e3c25d9cb69fca3363f47a225c7:

In file included from eng_back.c:30:
p11_pthread.h:92:2: error: #error Locking not supported on this platform.
   92 | #error Locking not supported on this platform.
      |  ^~~~~

Fixes:
 - http://autobuild.buildroot.org/results/22adeb78ec4a807c362e6666825f50db6c0408f7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libp11/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/libp11/Config.in b/package/libp11/Config.in
index 4d7ff56895..ef1e5b4703 100644
--- a/package/libp11/Config.in
+++ b/package/libp11/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBP11
 	bool "libp11"
 	depends on !BR2_STATIC_LIBS # dlopen
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_OPENSSL
 	help
 	  OpenSSL engine for PKCS#11 modules. Part of the OpenSC
@@ -8,5 +9,5 @@ config BR2_PACKAGE_LIBP11
 
 	  https://github.com/OpenSC/OpenSC/wiki
 
-comment "libp11 needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
+comment "libp11 needs a toolchain w/ dynamic library, threads"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libp11: needs threads
  2022-07-19 21:56 [Buildroot] [PATCH 1/1] package/libp11: needs threads Fabrice Fontaine
@ 2022-07-20 11:45 ` Thomas Petazzoni via buildroot
  2022-08-11 11:36 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 11:45 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

On Tue, 19 Jul 2022 23:56:19 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> threads are mandatory since bump to version 0.4.12 in commit
> 86ab91483dcb4b60de8c1daa20e2f42bd95ab5fb and
> https://github.com/OpenSC/libp11/commit/4bd92da60a670e3c25d9cb69fca3363f47a225c7:
> 
> In file included from eng_back.c:30:
> p11_pthread.h:92:2: error: #error Locking not supported on this platform.
>    92 | #error Locking not supported on this platform.
>       |  ^~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/22adeb78ec4a807c362e6666825f50db6c0408f7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libp11/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libp11: needs threads
  2022-07-19 21:56 [Buildroot] [PATCH 1/1] package/libp11: needs threads Fabrice Fontaine
  2022-07-20 11:45 ` Thomas Petazzoni via buildroot
@ 2022-08-11 11:36 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-08-11 11:36 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > threads are mandatory since bump to version 0.4.12 in commit
 > 86ab91483dcb4b60de8c1daa20e2f42bd95ab5fb and
 > https://github.com/OpenSC/libp11/commit/4bd92da60a670e3c25d9cb69fca3363f47a225c7:

 > In file included from eng_back.c:30:
 > p11_pthread.h:92:2: error: #error Locking not supported on this platform.
 >    92 | #error Locking not supported on this platform.
 >       |  ^~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/22adeb78ec4a807c362e6666825f50db6c0408f7

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-11 11:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 21:56 [Buildroot] [PATCH 1/1] package/libp11: needs threads Fabrice Fontaine
2022-07-20 11:45 ` Thomas Petazzoni via buildroot
2022-08-11 11:36 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.