From: Stefan Agner <stefan@agner.ch>
To: Jonas Gorski <jogo@openwrt.org>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Joachim Eastwood <manabian@gmail.com>,
Jonas Jensen <jonas.jensen@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
James Hogan <james.hogan@imgtec.com>,
Jun Nie <jun.nie@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alessandro Rubini <rubini@unipv.it>,
Sonic Zhang <sonic.zhang@analog.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jonas Aaberg <jonas.aberg@stericsson.com>,
Baruch Siach <baruch@tkos.co.il>,
Andrew
Subject: Re: [PATCH RFT 2/5] gpio: replace trivial implementations of request/free with generic one
Date: Mon, 14 Sep 2015 20:32:15 -0700 [thread overview]
Message-ID: <8c58ff686349d7c027b8d82db3ca440a@agner.ch> (raw)
In-Reply-To: <1442150498-31116-3-git-send-email-jogo@openwrt.org>
On 2015-09-13 06:21, Jonas Gorski wrote:
> Replace all trivial request/free callbacks that do nothing but call into
> pinctrl code with the generic versions.
>
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
> drivers/gpio/gpio-lpc18xx.c | 14 ++------------
> drivers/gpio/gpio-moxart.c | 14 ++------------
> drivers/gpio/gpio-mvebu.c | 14 ++------------
> drivers/gpio/gpio-tb10x.c | 14 ++------------
> drivers/gpio/gpio-tz1090-pdc.c | 14 ++------------
> drivers/gpio/gpio-vf610.c | 14 ++------------
> 6 files changed, 12 insertions(+), 72 deletions(-)
<snip>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 3d5714d..cf39fb2 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -77,16 +77,6 @@ static inline u32 vf610_gpio_readl(void __iomem *reg)
> return readl_relaxed(reg);
> }
>
> -static int vf610_gpio_request(struct gpio_chip *chip, unsigned offset)
> -{
> - return pinctrl_request_gpio(chip->base + offset);
> -}
> -
> -static void vf610_gpio_free(struct gpio_chip *chip, unsigned offset)
> -{
> - pinctrl_free_gpio(chip->base + offset);
> -}
> -
> static int vf610_gpio_get(struct gpio_chip *gc, unsigned int gpio)
> {
> struct vf610_gpio_port *port =
> @@ -255,8 +245,8 @@ static int vf610_gpio_probe(struct platform_device *pdev)
> gc->ngpio = VF610_GPIO_PER_PORT;
> gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT;
>
> - gc->request = vf610_gpio_request;
> - gc->free = vf610_gpio_free;
> + gc->request = gpiochip_generic_request;
> + gc->free = gpiochip_generic_free;
> gc->direction_input = vf610_gpio_direction_input;
> gc->get = vf610_gpio_get;
> gc->direction_output = vf610_gpio_direction_output;
For the vf610 changes,
Acked-by: Stefan Agner <stefan@agner.ch>
--
Stefan
next prev parent reply other threads:[~2015-09-15 3:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 13:21 [PATCH RFT 0/5] gpiochip: add and use generic request/free Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 1/5] gpiolib: provide generic request/free implementations Jonas Gorski
2015-10-05 9:17 ` Linus Walleij
2015-09-13 13:21 ` [PATCH RFT 2/5] gpio: replace trivial implementations of request/free with generic one Jonas Gorski
2015-09-14 14:37 ` Thomas Petazzoni
2015-09-14 17:14 ` James Hogan
2015-09-15 3:32 ` Stefan Agner [this message]
2015-09-20 13:16 ` Joachim Eastwood
2015-09-13 13:21 ` [PATCH RFT 3/5] gpio: gpio-xz: use the generic request/free implementations Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 4/5] gpio: gpio-pl061: " Jonas Gorski
2015-10-05 9:19 ` Linus Walleij
2015-10-05 13:12 ` Jonas Gorski
2015-10-06 7:23 ` Linus Walleij
2015-09-13 13:21 ` [PATCH RFT 5/5] pinctrl: replace trivial implementations of gpio_chip request/free Jonas Gorski
2015-09-13 19:07 ` Bjorn Andersson
2015-09-13 19:20 ` Heiko Stübner
2015-09-14 14:18 ` Eric Anholt
2015-09-14 14:41 ` Mika Westerberg
2015-09-14 16:53 ` Andrew Bresticker
2015-09-16 11:07 ` Baruch Siach
2015-09-20 13:40 ` Matthias Brugger
2015-10-01 12:32 ` Lee Jones
2015-10-05 10:37 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c58ff686349d7c027b8d82db3ca440a@agner.ch \
--to=stefan@agner.ch \
--cc=baruch@tkos.co.il \
--cc=eric@anholt.net \
--cc=gnurou@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=james.hogan@imgtec.com \
--cc=jogo@openwrt.org \
--cc=jonas.aberg@stericsson.com \
--cc=jonas.jensen@gmail.com \
--cc=jun.nie@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rubini@unipv.it \
--cc=sonic.zhang@analog.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.