From: Linus Walleij <linus.walleij@linaro.org>
To: Jonas Gorski <jogo@openwrt.org>, Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Joachim Eastwood <manabian@gmail.com>,
Jonas Jensen <jonas.jensen@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
James Hogan <james.hogan@imgtec.com>,
Stefan Agner <stefan@agner.ch>, Jun Nie <jun.nie@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alessandro Rubini <rubini@unipv.it>,
Sonic Zhang <sonic.zhang@analog.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Baruch Siach <baruch@tkos.co.il>,
Andrew Bresticker <abrestic@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Sr
Subject: Re: [PATCH RFT 4/5] gpio: gpio-pl061: use the generic request/free implementations
Date: Tue, 6 Oct 2015 09:23:30 +0200 [thread overview]
Message-ID: <CACRpkdY_BAVhTJoMvyLXo9iDQ-YoezeO64jTesgpJ=1d8AxcFw@mail.gmail.com> (raw)
In-Reply-To: <5612772B.8090706@openwrt.org>
On Mon, Oct 5, 2015 at 3:12 PM, Jonas Gorski <jogo@openwrt.org> wrote:
> [Me]
>> Can we think of a way to do this even more generic:
>> could gpiochip_generic_request() check if the range is
>> there instead?
>
> I thought about this, and AFAICT this would open a window in which gpio
> requests could bypass the pinctrl subsystem, as ranges are only registered
> after the gpio chip was registered.
> pinctrl_request_gpio() -> pinctrl_get_device_gpio_range() returns -EPROBEDEFER if
> it can't find a range for that reason.
>
> To solve this we could introduce a gpiochip_add_with_range(), then we can assign
> the generic _request/_free in gpiochip_add in case the callbacks aren't set yet
> (and keep the way _request/_free are implemented).
Hm! That sounds like a good idea. Alexandre, what do you think?
> static const struct __initconst pinctrl_gpio_range foo_range = {
> .base = 0,
> .pinbase = 0,
> .npins = npins,
> };
>
> gpiochip_add_with_ranges(chip, "foo", &foo_range, 1);
Neato.
> which would be a bit more verbose, but for drivers like pinctrl-cygnus-gpio,
> which registers 51(!) pinranges for the same gpio chip, it would mean quite a
> bit of code reduction.
Now we're talking.
Are you interested in doing this refactoring? It'd be awesome.
(Do it on top of this series though, so we can merge this first.)
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-10-06 7:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 13:21 [PATCH RFT 0/5] gpiochip: add and use generic request/free Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 1/5] gpiolib: provide generic request/free implementations Jonas Gorski
2015-10-05 9:17 ` Linus Walleij
2015-09-13 13:21 ` [PATCH RFT 2/5] gpio: replace trivial implementations of request/free with generic one Jonas Gorski
2015-09-14 14:37 ` Thomas Petazzoni
2015-09-14 17:14 ` James Hogan
2015-09-15 3:32 ` Stefan Agner
2015-09-20 13:16 ` Joachim Eastwood
2015-09-13 13:21 ` [PATCH RFT 3/5] gpio: gpio-xz: use the generic request/free implementations Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 4/5] gpio: gpio-pl061: " Jonas Gorski
2015-10-05 9:19 ` Linus Walleij
2015-10-05 13:12 ` Jonas Gorski
2015-10-06 7:23 ` Linus Walleij [this message]
2015-09-13 13:21 ` [PATCH RFT 5/5] pinctrl: replace trivial implementations of gpio_chip request/free Jonas Gorski
2015-09-13 19:07 ` Bjorn Andersson
2015-09-13 19:20 ` Heiko Stübner
2015-09-14 14:18 ` Eric Anholt
2015-09-14 14:41 ` Mika Westerberg
2015-09-14 16:53 ` Andrew Bresticker
2015-09-16 11:07 ` Baruch Siach
2015-09-20 13:40 ` Matthias Brugger
2015-10-01 12:32 ` Lee Jones
2015-10-05 10:37 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY_BAVhTJoMvyLXo9iDQ-YoezeO64jTesgpJ=1d8AxcFw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=abrestic@chromium.org \
--cc=baruch@tkos.co.il \
--cc=eric@anholt.net \
--cc=gnurou@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=james.hogan@imgtec.com \
--cc=jogo@openwrt.org \
--cc=jonas.jensen@gmail.com \
--cc=jun.nie@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rubini@unipv.it \
--cc=sonic.zhang@analog.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.