Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error
Date: Fri, 26 Apr 2024 09:36:21 +0300	[thread overview]
Message-ID: <99218e32-bd37-49d8-bb90-b6ce9a6447ac@ideasonboard.com> (raw)
In-Reply-To: <20240425-dp-live-fmt-fix-v2-2-6048e81211de@amd.com>

On 26/04/2024 04:46, Anatoliy Klymenko wrote:
> Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats().
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-lkp@intel.com/
> ---

This is missing your signed-off-by.

  Tomi

>   drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 423f5f4943cc..c9fb432d4cbd 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct zynqmp_disp_layer *layer,
>   	unsigned int i;
>   	u32 *formats;
>   
> -	if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> +	if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
>   		*num_formats = 0;
>   		return NULL;
>   	}
> 