From: Paul Durrant <Paul.Durrant@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Keir (Xen.org)" <keir@xen.org>
Subject: Re: [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq()
Date: Tue, 14 Jul 2015 12:33:40 +0000 [thread overview]
Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD02F4C1C7E@AMSPEX01CL02.citrite.net> (raw)
In-Reply-To: <55A50FBF0200007800090A32@mail.emea.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 14 July 2015 12:34
> To: xen-devel
> Cc: Andrew Cooper; Paul Durrant; Keir (Xen.org)
> Subject: [PATCH] x86/HVM: drop now wrong ASSERT() from
> hvm_broadcast_ioreq()
>
> The function is now also being used for IOREQ_TYPE_TIMEOFFSET.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Ouch. Yes.
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2717,8 +2717,6 @@ unsigned int hvm_broadcast_ioreq(ioreq
> struct hvm_ioreq_server *s;
> unsigned int failed = 0;
>
> - ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
> -
> list_for_each_entry ( s,
> &d->arch.hvm_domain.ioreq_server.list,
> list_entry )
>
>
prev parent reply other threads:[~2015-07-14 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 11:33 [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq() Jan Beulich
2015-07-14 12:32 ` Andrew Cooper
2015-07-14 12:33 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9AAE0902D5BC7E449B7C8E4E778ABCD02F4C1C7E@AMSPEX01CL02.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.