* [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq()
@ 2015-07-14 11:33 Jan Beulich
2015-07-14 12:32 ` Andrew Cooper
2015-07-14 12:33 ` Paul Durrant
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2015-07-14 11:33 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Paul Durrant, Keir Fraser
The function is now also being used for IOREQ_TYPE_TIMEOFFSET.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2717,8 +2717,6 @@ unsigned int hvm_broadcast_ioreq(ioreq
struct hvm_ioreq_server *s;
unsigned int failed = 0;
- ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
-
list_for_each_entry ( s,
&d->arch.hvm_domain.ioreq_server.list,
list_entry )
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq()
2015-07-14 11:33 [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq() Jan Beulich
@ 2015-07-14 12:32 ` Andrew Cooper
2015-07-14 12:33 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2015-07-14 12:32 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Paul Durrant, Keir Fraser
On 14/07/15 12:33, Jan Beulich wrote:
> The function is now also being used for IOREQ_TYPE_TIMEOFFSET.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2717,8 +2717,6 @@ unsigned int hvm_broadcast_ioreq(ioreq
> struct hvm_ioreq_server *s;
> unsigned int failed = 0;
>
> - ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
> -
> list_for_each_entry ( s,
> &d->arch.hvm_domain.ioreq_server.list,
> list_entry )
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq()
2015-07-14 11:33 [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq() Jan Beulich
2015-07-14 12:32 ` Andrew Cooper
@ 2015-07-14 12:33 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2015-07-14 12:33 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Keir (Xen.org)
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 14 July 2015 12:34
> To: xen-devel
> Cc: Andrew Cooper; Paul Durrant; Keir (Xen.org)
> Subject: [PATCH] x86/HVM: drop now wrong ASSERT() from
> hvm_broadcast_ioreq()
>
> The function is now also being used for IOREQ_TYPE_TIMEOFFSET.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Ouch. Yes.
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2717,8 +2717,6 @@ unsigned int hvm_broadcast_ioreq(ioreq
> struct hvm_ioreq_server *s;
> unsigned int failed = 0;
>
> - ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
> -
> list_for_each_entry ( s,
> &d->arch.hvm_domain.ioreq_server.list,
> list_entry )
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-14 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 11:33 [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq() Jan Beulich
2015-07-14 12:32 ` Andrew Cooper
2015-07-14 12:33 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.