* Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id
2022-08-11 10:50 [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id Vincent Knecht
@ 2022-08-11 10:55 ` Bryan O'Donoghue
2022-09-19 20:17 ` Bjorn Andersson
2022-09-24 16:38 ` Dmitry Baryshkov
2 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-08-11 10:55 UTC (permalink / raw)
To: Vincent Knecht, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Shawn Guo, linux-arm-msm, linux-pm, linux-kernel
Cc: ~postmarketos/upstreaming, phone-devel, mchen
On 11/08/2022 11:50, Vincent Knecht wrote:
> Reading temperature from this sensor fails with 'Invalid argument'.
>
> Looking at old vendor dts [1], its hw_id should be 3 instead of 4.
> Change this hw_id accordingly.
>
> [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511
>
> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939")
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi
> ---
> drivers/thermal/qcom/tsens-v0_1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index f136cb350238..327f37202c69 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = {
> struct tsens_plat_data data_8939 = {
> .num_sensors = 10,
> .ops = &ops_8939,
> - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 },
> + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },
>
> .feat = &tsens_v0_1_feat,
> .fields = tsens_v0_1_regfields,
ACK we have this change in our shipping 4.19 kernel
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id
2022-08-11 10:50 [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id Vincent Knecht
2022-08-11 10:55 ` Bryan O'Donoghue
@ 2022-09-19 20:17 ` Bjorn Andersson
2022-09-24 16:38 ` Dmitry Baryshkov
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2022-09-19 20:17 UTC (permalink / raw)
To: Vincent Knecht
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Amit Kucheria,
Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Shawn Guo, linux-arm-msm, linux-pm, linux-kernel, bryan.odonoghue,
~postmarketos/upstreaming, phone-devel
On Thu, Aug 11, 2022 at 12:50:14PM +0200, Vincent Knecht wrote:
> Reading temperature from this sensor fails with 'Invalid argument'.
>
> Looking at old vendor dts [1], its hw_id should be 3 instead of 4.
> Change this hw_id accordingly.
>
> [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511
>
> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939")
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi
> ---
> drivers/thermal/qcom/tsens-v0_1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index f136cb350238..327f37202c69 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = {
> struct tsens_plat_data data_8939 = {
> .num_sensors = 10,
> .ops = &ops_8939,
> - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 },
> + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },
>
> .feat = &tsens_v0_1_feat,
> .fields = tsens_v0_1_regfields,
> --
> 2.37.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id
2022-08-11 10:50 [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id Vincent Knecht
2022-08-11 10:55 ` Bryan O'Donoghue
2022-09-19 20:17 ` Bjorn Andersson
@ 2022-09-24 16:38 ` Dmitry Baryshkov
2022-09-27 9:35 ` Daniel Lezcano
2 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-09-24 16:38 UTC (permalink / raw)
To: Vincent Knecht, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Shawn Guo, linux-arm-msm, linux-pm, linux-kernel
Cc: bryan.odonoghue, ~postmarketos/upstreaming, phone-devel
On 11/08/2022 13:50, Vincent Knecht wrote:
> Reading temperature from this sensor fails with 'Invalid argument'.
>
> Looking at old vendor dts [1], its hw_id should be 3 instead of 4.
> Change this hw_id accordingly.
>
> [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511
>
> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939")
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Daniel, gracious ping for getting this patch into 6.1.
> ---
> Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi
> ---
> drivers/thermal/qcom/tsens-v0_1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index f136cb350238..327f37202c69 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = {
> struct tsens_plat_data data_8939 = {
> .num_sensors = 10,
> .ops = &ops_8939,
> - .hw_ids = (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 },
> + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },
>
> .feat = &tsens_v0_1_feat,
> .fields = tsens_v0_1_regfields,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw_id
2022-09-24 16:38 ` Dmitry Baryshkov
@ 2022-09-27 9:35 ` Daniel Lezcano
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2022-09-27 9:35 UTC (permalink / raw)
To: Dmitry Baryshkov, Vincent Knecht, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki,
Zhang Rui, Shawn Guo, linux-arm-msm, linux-pm, linux-kernel
Cc: bryan.odonoghue, ~postmarketos/upstreaming, phone-devel
On 24/09/2022 18:38, Dmitry Baryshkov wrote:
> On 11/08/2022 13:50, Vincent Knecht wrote:
>> Reading temperature from this sensor fails with 'Invalid argument'.
>>
>> Looking at old vendor dts [1], its hw_id should be 3 instead of 4.
>> Change this hw_id accordingly.
>>
>> [1]
>> https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511
>>
>>
>> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for
>> MSM8939")
>> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Daniel, gracious ping for getting this patch into 6.1.
Applied for 6.1, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread