From: Luca Fancellu <luca.fancellu@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Elliott Mitchell <ehem+xen@m5p.com>,
xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant
Date: Wed, 5 Jan 2022 13:09:57 +0000 [thread overview]
Message-ID: <AC735889-DA89-49E6-9214-31EFC8890AB9@arm.com> (raw)
In-Reply-To: <YdVuZyvwrDUxn4O4@perard>
> On 5 Jan 2022, at 10:09, Anthony PERARD <anthony.perard@citrix.com> wrote:
>
> On Fri, Dec 18, 2020 at 01:37:44PM -0800, Elliott Mitchell wrote:
>> Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
>> examining the pointed to thing, not modifying it. This potentially
>> results in higher-performance output. This also allows spreading
>> constants further, allowing more checking and security.
>>
>> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
>
> This patch doesn't build.
>
> libxl_cpuid.c:510:17: error: conflicting types for ‘libxl_cpuid_policy_list_gen_json’
> 510 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from libxl_internal.h:89,
> from libxl_cpuid.c:15:
> /home/sheep/work/xen/tools/libs/light/../../../tools/include/libxl_json.h:30:17: note: previous declaration of ‘libxl_cpuid_policy_list_gen_json’ was here
> 30 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Also we talked about this patch before, in
> https://lore.kernel.org/xen-devel/YImXfc4oaPgWzkeT@perard/
>
> Cheers,
Sorry about that, when I’ve put my R-by I thought it was building, I’ve checked again and it’s not building for x86_64, arm32 and arm64 looks fine so far.
Cheers,
Luca
>
> --
> Anthony PERARD
>
prev parent reply other threads:[~2022-01-05 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 7:39 [PATCH 0/5] Some misc from my tree Elliott Mitchell
2020-12-10 23:09 ` [PATCH 5/5] tools/xl: Fix potential deallocation bug Elliott Mitchell
2021-12-29 17:20 ` Luca Fancellu
2022-01-05 15:05 ` Anthony PERARD
2022-04-22 22:58 ` Elliott Mitchell
2020-12-18 1:42 ` [PATCH 4/5] tools/xl: Merge down debug/dry-run section of create_domain() Elliott Mitchell
2021-12-29 17:19 ` Luca Fancellu
2020-12-18 1:42 ` [PATCH 3/5] tools/xl: Rename printf_info()/list_domains_details() to dump_by_...() Elliott Mitchell
2021-12-29 17:18 ` Luca Fancellu
2020-12-18 21:32 ` [PATCH 2/5] tools/xl: Mark libxl_domain_config * arg of printf_info_*() const Elliott Mitchell
2021-12-29 17:18 ` Luca Fancellu
2020-12-18 21:37 ` [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant Elliott Mitchell
2021-12-29 17:15 ` Luca Fancellu
2022-01-05 10:09 ` Anthony PERARD
2022-01-05 13:09 ` Luca Fancellu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC735889-DA89-49E6-9214-31EFC8890AB9@arm.com \
--to=luca.fancellu@arm.com \
--cc=anthony.perard@citrix.com \
--cc=ehem+xen@m5p.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.