From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH 0/5] Some misc from my tree
Date: Sun, 26 Dec 2021 23:39:54 -0800 [thread overview]
Message-ID: <cover.1640590794.git.ehem+xen@m5p.com> (raw)
Some bits I had run across when looking at a piece of libxl.
Even though the purpose of the functions suggests they won't modify the
memory passed in via pointer, marking them constant provides better
reassurance.
While list_domains_details() and printf_info() had similar purposes their
interfaces were wildly different. Make them more consistent. I was
aiming to turn dump_by_dominfo_list() into a wrapper around
dump_by_config(), but didn't quite get there.
Having the functions named "printf" is wrong. They are generating output
in a fixed format, there is no control over the format. That is a write
or dump operation, not a formatted print.
Elliott Mitchell (5):
tools/libxl: Mark pointer args of many functions constant
tools/xl: Mark libxl_domain_config * arg of printf_info_*() const
tools/xl: Rename printf_info()/list_domains_details() to dump_by_...()
tools/xl: Merge down debug/dry-run section of create_domain()
tools/xl: Fix potential deallocation bug
tools/include/libxl_json.h | 22 +++++++++++---------
tools/libs/light/gentypes.py | 8 ++++----
tools/libs/light/libxl_cpuid.c | 2 +-
tools/libs/light/libxl_internal.c | 4 ++--
tools/libs/light/libxl_internal.h | 18 ++++++++--------
tools/libs/light/libxl_json.c | 18 ++++++++--------
tools/libs/light/libxl_nocpuid.c | 4 ++--
tools/xl/xl.h | 10 ++++++++-
tools/xl/xl_info.c | 34 ++++++++++++++++---------------
tools/xl/xl_misc.c | 5 +----
tools/xl/xl_sxp.c | 6 +++---
tools/xl/xl_vmcontrol.c | 14 +------------
12 files changed, 72 insertions(+), 73 deletions(-)
--
2.30.2
next reply other threads:[~2021-12-27 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 7:39 Elliott Mitchell [this message]
2020-12-10 23:09 ` [PATCH 5/5] tools/xl: Fix potential deallocation bug Elliott Mitchell
2021-12-29 17:20 ` Luca Fancellu
2022-01-05 15:05 ` Anthony PERARD
2022-04-22 22:58 ` Elliott Mitchell
2020-12-18 1:42 ` [PATCH 3/5] tools/xl: Rename printf_info()/list_domains_details() to dump_by_...() Elliott Mitchell
2021-12-29 17:18 ` Luca Fancellu
2020-12-18 1:42 ` [PATCH 4/5] tools/xl: Merge down debug/dry-run section of create_domain() Elliott Mitchell
2021-12-29 17:19 ` Luca Fancellu
2020-12-18 21:32 ` [PATCH 2/5] tools/xl: Mark libxl_domain_config * arg of printf_info_*() const Elliott Mitchell
2021-12-29 17:18 ` Luca Fancellu
2020-12-18 21:37 ` [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant Elliott Mitchell
2021-12-29 17:15 ` Luca Fancellu
2022-01-05 10:09 ` Anthony PERARD
2022-01-05 13:09 ` Luca Fancellu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1640590794.git.ehem+xen@m5p.com \
--to=ehem+xen@m5p.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.