* [Intel-wired-lan] [PATCH net v2] i40e: Fix to stop tx_timeout recovery if GLOBR fails
@ 2022-08-02 8:19 Mateusz Palczewski
2022-08-11 11:15 ` G, GurucharanX
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Palczewski @ 2022-08-02 8:19 UTC (permalink / raw)
To: intel-wired-lan
From: Alan Brady <alan.brady@intel.com>
When a tx_timeout fires, the PF attempts to recover by incrementally
resetting. First we try a PFR, then CORER and finally a GLOBR. If the
GLOBR fails, then we keep hitting the tx_timeout and incrementing the
recovery level and issuing dmesgs, which is both annoying to the user
and accomplishes nothing.
If the GLOBR fails, then we're pretty much totally hosed, and there's
not much else we can do to recover, so this makes it such that we just
kill the VSI and stop hitting the tx_timeout in such a case.
Fixes: 41c445ff0f48 ("i40e: main driver core")
Signed-off-by: Alan Brady <alan.brady@intel.com>
Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
---
v2: Changed the author
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 685556e968f2..71a8e1698ed4 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -384,7 +384,9 @@ static void i40e_tx_timeout(struct net_device *netdev, unsigned int txqueue)
set_bit(__I40E_GLOBAL_RESET_REQUESTED, pf->state);
break;
default:
- netdev_err(netdev, "tx_timeout recovery unsuccessful\n");
+ netdev_err(netdev, "tx_timeout recovery unsuccessful, device is in non-recoverable state.\n");
+ set_bit(__I40E_DOWN_REQUESTED, pf->state);
+ set_bit(__I40E_VSI_DOWN_REQUESTED, vsi->state);
break;
}
--
2.27.0
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-wired-lan] [PATCH net v2] i40e: Fix to stop tx_timeout recovery if GLOBR fails
2022-08-02 8:19 [Intel-wired-lan] [PATCH net v2] i40e: Fix to stop tx_timeout recovery if GLOBR fails Mateusz Palczewski
@ 2022-08-11 11:15 ` G, GurucharanX
0 siblings, 0 replies; 2+ messages in thread
From: G, GurucharanX @ 2022-08-11 11:15 UTC (permalink / raw)
To: Palczewski, Mateusz, intel-wired-lan@lists.osuosl.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Mateusz Palczewski
> Sent: Tuesday, August 2, 2022 1:49 PM
> To: intel-wired-lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix to stop tx_timeout
> recovery if GLOBR fails
>
> From: Alan Brady <alan.brady@intel.com>
>
> When a tx_timeout fires, the PF attempts to recover by incrementally
> resetting. First we try a PFR, then CORER and finally a GLOBR. If the GLOBR
> fails, then we keep hitting the tx_timeout and incrementing the recovery
> level and issuing dmesgs, which is both annoying to the user and
> accomplishes nothing.
>
> If the GLOBR fails, then we're pretty much totally hosed, and there's not
> much else we can do to recover, so this makes it such that we just kill the VSI
> and stop hitting the tx_timeout in such a case.
>
> Fixes: 41c445ff0f48 ("i40e: main driver core")
> Signed-off-by: Alan Brady <alan.brady@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> ---
> v2: Changed the author
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-11 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 8:19 [Intel-wired-lan] [PATCH net v2] i40e: Fix to stop tx_timeout recovery if GLOBR fails Mateusz Palczewski
2022-08-11 11:15 ` G, GurucharanX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.