From: Moritz Fischer <moritz.fischer@ettus.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk,
"Kumar Gala" <galak@codeaurora.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
akpm@linux-foundation.org, "Greg KH" <gregkh@linuxfoundation.org>,
mchehab@osg.samsung.com, "Arnd Bergmann" <arnd@arndb.de>,
joe@perches.com, "Jingoo Han" <jingoohan1@gmail.com>,
devicetree@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Moritz Fischer" <moritz.fischer@ettus.com>
Subject: Re: [PATCHv7 0/2] Adding driver for Xilinx LogiCORE IP mailbox.
Date: Tue, 28 Jul 2015 15:44:35 -0700 [thread overview]
Message-ID: <CAAtXAHcobgftojgba8fcb2OM2eZvYqHHBhzEQahXO4m-VfrFYg@mail.gmail.com> (raw)
In-Reply-To: <1436922022-17564-1-git-send-email-moritz.fischer@ettus.com>
Hi Jassi,
just a ping to see if you're waiting on me to fix things or if this is
good to go from your point of view,
and you're just waiting some time to give people more time to review.
Let me know if you want me to resend with Soeren's Acked-By
Cheers,
Moritz
On Tue, Jul 14, 2015 at 6:00 PM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> Hi all,
>
> Thanks for hanging in there, hopefully the last round of review ...
>
> This patchset adds mailbox framework integration for the Xilinx LogiCORE IP
> mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows
> interprocessor communication between AXI4 stream / memory mapped
> processors.
>
> Cheers,
>
> Moritz
>
> Changes from v6:
> - As suggested by Jassi and Sören use #mbox-cells = <1>
>
> Changes from v5:
> - Fixed constness for ops struct
> - Removed redundant checks
> - Moved ops assignment
> - Removed MODULE_ALIAS
>
> Changes from v4:
> - Have separate mbox_ops structs for polling / irq mode
> - Moved clk handling to startup / shutdown
> - Embedded struct mbox_chan in struct xilinx_mbox
> - Fixed mbox-cells in devicetree documentation
> - Misc stylistic issues
>
> Changes from v3:
> - Stylistic changes
> - Changed reg size in dts to 0x100
>
> Changes from v2:
> - Fixed error condition for IRQ from >= 0 to > 0
> - Fixed clock enable
> - Cleaned up docs
>
> Changes from v1:
> - Added common clock framework support
> - Deal with IRQs that happend before driver load,
> since HW will not let us know about them when we enable IRQs
>
> Changes from v0:
> - Several stylistic issues
> - Dropped superfluous intr_mode member
> - Really masking the IRQs on mailbox_shutdown
> - No longer using polling by accident in non-IRQ mode
> - Swapped doc and driver commits
>
>
> Moritz Fischer (2):
> dts: Adding docs for Xilinx LogiCORE IP mailbox driver.
> mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
>
> .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 +++
> MAINTAINERS | 7 +
> drivers/mailbox/Kconfig | 7 +
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/mailbox-xilinx.c | 367 +++++++++++++++++++++
> 5 files changed, 427 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
> create mode 100644 drivers/mailbox/mailbox-xilinx.c
>
> --
> 2.4.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Moritz Fischer <moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>
To: Jassi Brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Michal Simek"
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
"Greg KH"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
"Jingoo Han" <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Moritz Fischer"
<moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCHv7 0/2] Adding driver for Xilinx LogiCORE IP mailbox.
Date: Tue, 28 Jul 2015 15:44:35 -0700 [thread overview]
Message-ID: <CAAtXAHcobgftojgba8fcb2OM2eZvYqHHBhzEQahXO4m-VfrFYg@mail.gmail.com> (raw)
In-Reply-To: <1436922022-17564-1-git-send-email-moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>
Hi Jassi,
just a ping to see if you're waiting on me to fix things or if this is
good to go from your point of view,
and you're just waiting some time to give people more time to review.
Let me know if you want me to resend with Soeren's Acked-By
Cheers,
Moritz
On Tue, Jul 14, 2015 at 6:00 PM, Moritz Fischer
<moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org> wrote:
> Hi all,
>
> Thanks for hanging in there, hopefully the last round of review ...
>
> This patchset adds mailbox framework integration for the Xilinx LogiCORE IP
> mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows
> interprocessor communication between AXI4 stream / memory mapped
> processors.
>
> Cheers,
>
> Moritz
>
> Changes from v6:
> - As suggested by Jassi and Sören use #mbox-cells = <1>
>
> Changes from v5:
> - Fixed constness for ops struct
> - Removed redundant checks
> - Moved ops assignment
> - Removed MODULE_ALIAS
>
> Changes from v4:
> - Have separate mbox_ops structs for polling / irq mode
> - Moved clk handling to startup / shutdown
> - Embedded struct mbox_chan in struct xilinx_mbox
> - Fixed mbox-cells in devicetree documentation
> - Misc stylistic issues
>
> Changes from v3:
> - Stylistic changes
> - Changed reg size in dts to 0x100
>
> Changes from v2:
> - Fixed error condition for IRQ from >= 0 to > 0
> - Fixed clock enable
> - Cleaned up docs
>
> Changes from v1:
> - Added common clock framework support
> - Deal with IRQs that happend before driver load,
> since HW will not let us know about them when we enable IRQs
>
> Changes from v0:
> - Several stylistic issues
> - Dropped superfluous intr_mode member
> - Really masking the IRQs on mailbox_shutdown
> - No longer using polling by accident in non-IRQ mode
> - Swapped doc and driver commits
>
>
> Moritz Fischer (2):
> dts: Adding docs for Xilinx LogiCORE IP mailbox driver.
> mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
>
> .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 +++
> MAINTAINERS | 7 +
> drivers/mailbox/Kconfig | 7 +
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/mailbox-xilinx.c | 367 +++++++++++++++++++++
> 5 files changed, 427 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
> create mode 100644 drivers/mailbox/mailbox-xilinx.c
>
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: moritz.fischer@ettus.com (Moritz Fischer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 0/2] Adding driver for Xilinx LogiCORE IP mailbox.
Date: Tue, 28 Jul 2015 15:44:35 -0700 [thread overview]
Message-ID: <CAAtXAHcobgftojgba8fcb2OM2eZvYqHHBhzEQahXO4m-VfrFYg@mail.gmail.com> (raw)
In-Reply-To: <1436922022-17564-1-git-send-email-moritz.fischer@ettus.com>
Hi Jassi,
just a ping to see if you're waiting on me to fix things or if this is
good to go from your point of view,
and you're just waiting some time to give people more time to review.
Let me know if you want me to resend with Soeren's Acked-By
Cheers,
Moritz
On Tue, Jul 14, 2015 at 6:00 PM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> Hi all,
>
> Thanks for hanging in there, hopefully the last round of review ...
>
> This patchset adds mailbox framework integration for the Xilinx LogiCORE IP
> mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows
> interprocessor communication between AXI4 stream / memory mapped
> processors.
>
> Cheers,
>
> Moritz
>
> Changes from v6:
> - As suggested by Jassi and S?ren use #mbox-cells = <1>
>
> Changes from v5:
> - Fixed constness for ops struct
> - Removed redundant checks
> - Moved ops assignment
> - Removed MODULE_ALIAS
>
> Changes from v4:
> - Have separate mbox_ops structs for polling / irq mode
> - Moved clk handling to startup / shutdown
> - Embedded struct mbox_chan in struct xilinx_mbox
> - Fixed mbox-cells in devicetree documentation
> - Misc stylistic issues
>
> Changes from v3:
> - Stylistic changes
> - Changed reg size in dts to 0x100
>
> Changes from v2:
> - Fixed error condition for IRQ from >= 0 to > 0
> - Fixed clock enable
> - Cleaned up docs
>
> Changes from v1:
> - Added common clock framework support
> - Deal with IRQs that happend before driver load,
> since HW will not let us know about them when we enable IRQs
>
> Changes from v0:
> - Several stylistic issues
> - Dropped superfluous intr_mode member
> - Really masking the IRQs on mailbox_shutdown
> - No longer using polling by accident in non-IRQ mode
> - Swapped doc and driver commits
>
>
> Moritz Fischer (2):
> dts: Adding docs for Xilinx LogiCORE IP mailbox driver.
> mailbox: Adding driver for Xilinx LogiCORE IP mailbox.
>
> .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 +++
> MAINTAINERS | 7 +
> drivers/mailbox/Kconfig | 7 +
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/mailbox-xilinx.c | 367 +++++++++++++++++++++
> 5 files changed, 427 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
> create mode 100644 drivers/mailbox/mailbox-xilinx.c
>
> --
> 2.4.3
>
next prev parent reply other threads:[~2015-07-28 22:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 1:00 [PATCHv7 0/2] Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-07-15 1:00 ` Moritz Fischer
2015-07-15 1:00 ` Moritz Fischer
2015-07-15 1:00 ` [PATCHv7 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver Moritz Fischer
2015-07-15 1:00 ` Moritz Fischer
2015-07-15 1:23 ` Sören Brinkmann
2015-07-15 1:23 ` Sören Brinkmann
2015-07-15 1:23 ` Sören Brinkmann
2015-07-15 1:00 ` [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-07-15 1:00 ` Moritz Fischer
2015-08-10 8:05 ` Jassi Brar
2015-08-10 8:05 ` Jassi Brar
2015-08-10 8:05 ` Jassi Brar
2015-12-02 17:26 ` Moritz Fischer
2015-12-02 17:26 ` Moritz Fischer
2015-12-03 5:05 ` Jassi Brar
2015-12-03 5:05 ` Jassi Brar
2015-12-03 5:05 ` Jassi Brar
2015-07-28 22:44 ` Moritz Fischer [this message]
2015-07-28 22:44 ` [PATCHv7 0/2] " Moritz Fischer
2015-07-28 22:44 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAtXAHcobgftojgba8fcb2OM2eZvYqHHBhzEQahXO4m-VfrFYg@mail.gmail.com \
--to=moritz.fischer@ettus.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.