From: Matthias Brugger <matthias.bgg@gmail.com>
To: YH Huang <yh.huang@mediatek.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Pawel Moll <pawel.moll@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/2] Add MediaTek display PWM driver
Date: Fri, 5 Jun 2015 10:39:11 +0200 [thread overview]
Message-ID: <CABuKBeLaVXxqBgy7AMoZ73+GoUknC6Zq=fJdcyZZjP5VYRZSkg@mail.gmail.com> (raw)
In-Reply-To: <1433484929.17376.17.camel@mtksdaap41>
Hi YH,
2015-06-05 8:15 GMT+02:00 YH Huang <yh.huang@mediatek.com>:
> On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote:
>> On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote:
>
> This patch series add the use of display PWM driver and documentation
> for Mediatek SoCs. The driver is used to support the backlight of
> the panel. This is based on v4.1-rc1.
>
>> > YH Huang (2):
>> > dt-bindings: pwm: add MediaTek display PWM bindings
>> > pwm: add MediaTek display PWM driver support
>> >
>> > .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 +++
>> > drivers/pwm/Kconfig | 10 +
>> > drivers/pwm/Makefile | 1 +
>> > drivers/pwm/pwm-mtk-disp.c | 228 +++++++++++++++++++++
>> > 4 files changed, 264 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>> > create mode 100644 drivers/pwm/pwm-mtk-disp.c
>>
>> Hi YH,
>>
>> It would be easier for reviewer if you have a summary here on what you
>> have changed compare to last version.
>> Also, please add patch series summary even for v2, it remind reviewer
>> what this series is about.
>>
>> Joe.C
>>
>
> The patch v2 is refined with everybody's suggestions.
> It is much readable and consistent.
I suppose that Yingjoe wanted to emphasis that for the reviewer it is
much easier if you describe the changes you made from v1 to v2.
You can find an example (random pick from the mailing list) here:
http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000572.html
Thanks,
Matthias
--
motzblog.wordpress.com
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] Add MediaTek display PWM driver
Date: Fri, 5 Jun 2015 10:39:11 +0200 [thread overview]
Message-ID: <CABuKBeLaVXxqBgy7AMoZ73+GoUknC6Zq=fJdcyZZjP5VYRZSkg@mail.gmail.com> (raw)
In-Reply-To: <1433484929.17376.17.camel@mtksdaap41>
Hi YH,
2015-06-05 8:15 GMT+02:00 YH Huang <yh.huang@mediatek.com>:
> On Mon, 2015-05-25 at 10:14 +0800, Yingjoe Chen wrote:
>> On Thu, 2015-05-21 at 21:29 +0800, YH Huang wrote:
>
> This patch series add the use of display PWM driver and documentation
> for Mediatek SoCs. The driver is used to support the backlight of
> the panel. This is based on v4.1-rc1.
>
>> > YH Huang (2):
>> > dt-bindings: pwm: add MediaTek display PWM bindings
>> > pwm: add MediaTek display PWM driver support
>> >
>> > .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 +++
>> > drivers/pwm/Kconfig | 10 +
>> > drivers/pwm/Makefile | 1 +
>> > drivers/pwm/pwm-mtk-disp.c | 228 +++++++++++++++++++++
>> > 4 files changed, 264 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>> > create mode 100644 drivers/pwm/pwm-mtk-disp.c
>>
>> Hi YH,
>>
>> It would be easier for reviewer if you have a summary here on what you
>> have changed compare to last version.
>> Also, please add patch series summary even for v2, it remind reviewer
>> what this series is about.
>>
>> Joe.C
>>
>
> The patch v2 is refined with everybody's suggestions.
> It is much readable and consistent.
I suppose that Yingjoe wanted to emphasis that for the reviewer it is
much easier if you describe the changes you made from v1 to v2.
You can find an example (random pick from the mailing list) here:
http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000572.html
Thanks,
Matthias
--
motzblog.wordpress.com
next prev parent reply other threads:[~2015-06-05 8:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:29 [PATCH v2 0/2] Add MediaTek display PWM driver YH Huang
2015-05-21 13:29 ` YH Huang
2015-05-21 13:29 ` YH Huang
2015-05-21 13:29 ` [PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings YH Huang
2015-05-21 13:29 ` YH Huang
2015-05-21 13:29 ` YH Huang
2015-06-12 10:23 ` Thierry Reding
2015-06-12 10:23 ` Thierry Reding
2015-06-18 9:00 ` YH Huang
2015-06-18 9:00 ` YH Huang
2015-06-18 9:00 ` YH Huang
2015-05-21 13:29 ` [PATCH v2 2/2] pwm: add MediaTek display PWM driver support YH Huang
2015-05-21 13:29 ` YH Huang
2015-05-21 13:29 ` YH Huang
2015-06-12 10:20 ` Thierry Reding
2015-06-12 10:20 ` Thierry Reding
2015-06-18 10:19 ` YH Huang
2015-06-18 10:19 ` YH Huang
2015-06-18 10:19 ` YH Huang
2015-06-18 13:58 ` Yingjoe Chen
2015-06-18 13:58 ` Yingjoe Chen
2015-06-18 13:58 ` Yingjoe Chen
2015-06-29 9:27 ` Thierry Reding
2015-06-29 9:27 ` Thierry Reding
2015-06-29 9:21 ` Thierry Reding
2015-06-29 9:21 ` Thierry Reding
2015-06-12 10:25 ` Thierry Reding
2015-06-12 10:25 ` Thierry Reding
2015-06-18 9:02 ` YH Huang
2015-06-18 9:02 ` YH Huang
2015-06-18 9:02 ` YH Huang
2015-05-25 2:14 ` [PATCH v2 0/2] Add MediaTek display PWM driver Yingjoe Chen
2015-05-25 2:14 ` Yingjoe Chen
2015-05-25 2:14 ` Yingjoe Chen
2015-06-05 6:15 ` YH Huang
2015-06-05 6:15 ` YH Huang
2015-06-05 8:39 ` Matthias Brugger [this message]
2015-06-05 8:39 ` Matthias Brugger
2015-06-05 10:45 ` YH Huang
2015-06-05 10:45 ` YH Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABuKBeLaVXxqBgy7AMoZ73+GoUknC6Zq=fJdcyZZjP5VYRZSkg@mail.gmail.com' \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=thierry.reding@gmail.com \
--cc=yh.huang@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.