From: Javier Martinez Canillas <javier@dowhile0.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Nadav Haklai <nadavh@marvell.com>,
Mark Rutland <mark.rutland@arm.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Tawfik Bayouk <tawfik@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Arnaud Ebalard <arno@natisbad.org>,
Rob Herring <robh+dt@kernel.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Imre Kaloz <kaloz@openwrt.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date: Thu, 25 Jun 2015 02:33:43 +0200 [thread overview]
Message-ID: <CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com> (raw)
In-Reply-To: <20150625000037.GK31584@windriver.com>
Hello Paul,
On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>
I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].
So it seems that the problem is rather that the header is not being
included in some file.
> Paul.
> --
>
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@dowhile0.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Nadav Haklai <nadavh@marvell.com>,
Mark Rutland <mark.rutland@arm.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Herbert Xu <herbert@gondor.apana.org.au>,
Tawfik Bayouk <tawfik@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Arnaud Ebalard <arno@natisbad.org>,
Rob Herring <robh+dt@kernel.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists
Subject: Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date: Thu, 25 Jun 2015 02:33:43 +0200 [thread overview]
Message-ID: <CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com> (raw)
In-Reply-To: <20150625000037.GK31584@windriver.com>
Hello Paul,
On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>
I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].
So it seems that the problem is rather that the header is not being
included in some file.
> Paul.
> --
>
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@dowhile0.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Nadav Haklai <nadavh@marvell.com>,
Mark Rutland <mark.rutland@arm.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Herbert Xu <herbert@gondor.apana.org.au>,
Tawfik Bayouk <tawfik@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Arnaud Ebalard <arno@natisbad.org>,
Rob Herring <robh+dt@kernel.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists>
Subject: Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date: Thu, 25 Jun 2015 02:33:43 +0200 [thread overview]
Message-ID: <CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com> (raw)
In-Reply-To: <20150625000037.GK31584@windriver.com>
Hello Paul,
On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>
I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].
So it seems that the problem is rather that the header is not being
included in some file.
> Paul.
> --
>
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
WARNING: multiple messages have this Message-ID (diff)
From: javier@dowhile0.org (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date: Thu, 25 Jun 2015 02:33:43 +0200 [thread overview]
Message-ID: <CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com> (raw)
In-Reply-To: <20150625000037.GK31584@windriver.com>
Hello Paul,
On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote:
>
>> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
>> > Hi Herbert,
>> >
>> > On Sun, 21 Jun 2015 16:27:17 +0800
>> > Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> >
>> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:
>> > > >
>> > > > Indeed. Here is a patch fixing that.
>> > >
>> > > I think you should just kill COMPILE_TEST instead of adding ARM.
>> >
>> > The following patch is killing the COMPILE_TEST dependency.
>>
>> Patch applied.
>
> Just a heads up, this driver is still killing a couple of linux-next
> builds today and for the past few days.
>
> drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
> 'of_get_named_gen_pool' [-Werror=implicit-function-declaration]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/
>
> Missing dependency on CONFIG_OF_<blah> presumably.
>
I haven't looked at the series but <linux/genalloc.h> has a stub
of_get_named_gen_pool() function if CONFIG_OF is not enabled [0].
So it seems that the problem is rather that the header is not being
included in some file.
> Paul.
> --
>
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131
next prev parent reply other threads:[~2015-06-25 0:33 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:46 [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 01/14] crypto: mv_cesa: document the clocks property Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 02/14] crypto: mv_cesa: use gen_pool to reserve the SRAM memory region Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 03/14] crypto: mv_cesa: explicitly define kirkwood and dove compatible strings Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 04/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-19 6:42 ` Herbert Xu
2015-06-19 6:42 ` Herbert Xu
2015-06-19 6:42 ` Herbert Xu
2015-06-19 6:42 ` Herbert Xu
2015-06-19 8:24 ` Thomas Petazzoni
2015-06-19 8:24 ` Thomas Petazzoni
2015-06-19 8:24 ` Thomas Petazzoni
2015-06-19 8:24 ` Thomas Petazzoni
2015-06-19 8:40 ` Gregory CLEMENT
2015-06-19 8:40 ` Gregory CLEMENT
2015-06-19 14:03 ` Herbert Xu
2015-06-19 14:03 ` Herbert Xu
2015-06-19 14:03 ` Herbert Xu
2015-06-19 14:03 ` Herbert Xu
2015-06-18 13:46 ` [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 06/14] crypto: marvell/CESA: add DES support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 07/14] crypto: marvell/CESA: add Triple-DES support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 08/14] crypto: marvell/CESA: add MD5 support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 09/14] crypto: marvell/CESA: add SHA256 support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 10/14] crypto: marvell/CESA: add support for all armada SoCs Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 11/14] crypto: marvell/CESA: add allhwsupport module parameter Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 12/14] crypto: marvell/CESA: add support for Orion SoCs Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 13/14] crypto: marvell/CESA: add support for Kirkwood and Dove SoCs Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 14/14] crypto: marvell/CESA: add DT bindings documentation Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-19 14:24 ` [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Herbert Xu
2015-06-19 14:24 ` Herbert Xu
2015-06-19 14:24 ` Herbert Xu
2015-06-19 14:24 ` Herbert Xu
2015-06-20 20:32 ` Paul Gortmaker
2015-06-20 20:32 ` Paul Gortmaker
2015-06-20 20:32 ` Paul Gortmaker
2015-06-20 20:32 ` Paul Gortmaker
2015-06-21 0:14 ` Paul Gortmaker
2015-06-21 0:14 ` Paul Gortmaker
2015-06-21 0:14 ` Paul Gortmaker
2015-06-21 0:14 ` Paul Gortmaker
2015-06-21 8:24 ` Boris Brezillon
2015-06-21 8:24 ` Boris Brezillon
2015-06-21 8:24 ` Boris Brezillon
2015-06-21 8:24 ` Boris Brezillon
2015-06-21 8:27 ` Herbert Xu
2015-06-21 8:27 ` Herbert Xu
2015-06-21 8:27 ` Herbert Xu
2015-06-21 8:27 ` Herbert Xu
2015-06-21 15:36 ` Boris Brezillon
2015-06-21 15:36 ` Boris Brezillon
2015-06-21 15:36 ` Boris Brezillon
2015-06-21 15:36 ` Boris Brezillon
2015-06-22 7:23 ` Boris Brezillon
2015-06-22 7:23 ` Boris Brezillon
2015-06-22 7:23 ` Boris Brezillon
2015-06-22 7:23 ` Boris Brezillon
2015-06-22 7:59 ` Herbert Xu
2015-06-22 7:59 ` Herbert Xu
2015-06-22 7:59 ` Herbert Xu
2015-06-22 7:59 ` Herbert Xu
2015-06-25 0:00 ` Paul Gortmaker
2015-06-25 0:00 ` Paul Gortmaker
2015-06-25 0:00 ` Paul Gortmaker
2015-06-25 0:00 ` Paul Gortmaker
2015-06-25 0:33 ` Javier Martinez Canillas [this message]
2015-06-25 0:33 ` Javier Martinez Canillas
2015-06-25 0:33 ` Javier Martinez Canillas
2015-06-25 0:33 ` Javier Martinez Canillas
2015-06-25 8:37 ` [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename Simon Guinot
2015-06-25 8:37 ` Simon Guinot
2015-06-25 8:37 ` Simon Guinot
2015-06-25 8:37 ` Simon Guinot
2015-06-25 15:30 ` Herbert Xu
2015-06-25 15:30 ` Herbert Xu
2015-06-25 15:30 ` Herbert Xu
2015-06-25 15:30 ` Herbert Xu
2015-06-25 15:41 ` Paul Gortmaker
2015-06-25 15:41 ` Paul Gortmaker
2015-06-25 15:41 ` Paul Gortmaker
2015-06-25 15:41 ` Paul Gortmaker
2015-06-25 15:56 ` Simon Guinot
2015-06-25 15:56 ` Simon Guinot
2015-06-25 15:56 ` Simon Guinot
2015-06-25 15:56 ` Simon Guinot
2015-06-26 8:32 ` Herbert Xu
2015-06-26 8:32 ` Herbert Xu
2015-06-26 8:32 ` Herbert Xu
2015-06-26 8:32 ` Herbert Xu
2015-06-25 0:33 ` [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Stephen Rothwell
2015-07-25 14:51 ` Gregory CLEMENT
2015-07-25 14:51 ` Gregory CLEMENT
2015-07-25 14:51 ` Gregory CLEMENT
2015-07-25 14:51 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv=m4juAMHaMYSB+8O8cEX+YZCJ0cArS2wN-YGpTBgWe-CA@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.