From: Konstantin Khlebnikov <koct9i@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Nicolai Stange <nicstange@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
LKP <lkp@01.org>
Subject: Re: [mminit] [ INFO: possible recursive locking detected ]
Date: Fri, 17 Jul 2015 08:06:49 +0300 [thread overview]
Message-ID: <CALYGNiMMeyW7GXHpdAONn4CckE5Q4cn64wwekZfk18q_W7xMsQ@mail.gmail.com> (raw)
In-Reply-To: <20150716175139.GB2561@suse.de>
On Thu, Jul 16, 2015 at 8:51 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Thu, Jul 16, 2015 at 08:13:38PM +0300, Konstantin Khlebnikov wrote:
>> > @@ -1187,14 +1195,14 @@ void __init page_alloc_init_late(void)
>> > {pgdat_init_rwsempgdat_init_rwsempgdat_init_rwsem
>> > int nid;
>> >
>> > + /* There will be num_node_state(N_MEMORY) threads */
>> > + atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));
>> > for_each_node_state(nid, N_MEMORY) {
>> > - down_read(&pgdat_init_rwsem);
>>
>> Rw-sem have special "non-owner" mode for keeping lockdep away.
>> This should be enough:
>>
>
> I think in this case that the completions look nicer though so I think
> I'll keep them.
Ok. Not a big deal, they are anyway in init sections.
BTW there's another option: wait_on_atomic_t / wake_up_atomic_t
like wait_on_bit but atomic_t
>
> --
> Mel Gorman
> SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <koct9i@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Nicolai Stange <nicstange@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
LKP <lkp@01.org>
Subject: Re: [mminit] [ INFO: possible recursive locking detected ]
Date: Fri, 17 Jul 2015 08:06:49 +0300 [thread overview]
Message-ID: <CALYGNiMMeyW7GXHpdAONn4CckE5Q4cn64wwekZfk18q_W7xMsQ@mail.gmail.com> (raw)
In-Reply-To: <20150716175139.GB2561@suse.de>
On Thu, Jul 16, 2015 at 8:51 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Thu, Jul 16, 2015 at 08:13:38PM +0300, Konstantin Khlebnikov wrote:
>> > @@ -1187,14 +1195,14 @@ void __init page_alloc_init_late(void)
>> > {pgdat_init_rwsempgdat_init_rwsempgdat_init_rwsem
>> > int nid;
>> >
>> > + /* There will be num_node_state(N_MEMORY) threads */
>> > + atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));
>> > for_each_node_state(nid, N_MEMORY) {
>> > - down_read(&pgdat_init_rwsem);
>>
>> Rw-sem have special "non-owner" mode for keeping lockdep away.
>> This should be enough:
>>
>
> I think in this case that the completions look nicer though so I think
> I'll keep them.
Ok. Not a big deal, they are anyway in init sections.
BTW there's another option: wait_on_atomic_t / wake_up_atomic_t
like wait_on_bit but atomic_t
>
> --
> Mel Gorman
> SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <koct9i@gmail.com>
To: lkp@lists.01.org
Subject: Re: [mminit] [ INFO: possible recursive locking detected ]
Date: Fri, 17 Jul 2015 08:06:49 +0300 [thread overview]
Message-ID: <CALYGNiMMeyW7GXHpdAONn4CckE5Q4cn64wwekZfk18q_W7xMsQ@mail.gmail.com> (raw)
In-Reply-To: <20150716175139.GB2561@suse.de>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Thu, Jul 16, 2015 at 8:51 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Thu, Jul 16, 2015 at 08:13:38PM +0300, Konstantin Khlebnikov wrote:
>> > @@ -1187,14 +1195,14 @@ void __init page_alloc_init_late(void)
>> > {pgdat_init_rwsempgdat_init_rwsempgdat_init_rwsem
>> > int nid;
>> >
>> > + /* There will be num_node_state(N_MEMORY) threads */
>> > + atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));
>> > for_each_node_state(nid, N_MEMORY) {
>> > - down_read(&pgdat_init_rwsem);
>>
>> Rw-sem have special "non-owner" mode for keeping lockdep away.
>> This should be enough:
>>
>
> I think in this case that the completions look nicer though so I think
> I'll keep them.
Ok. Not a big deal, they are anyway in init sections.
BTW there's another option: wait_on_atomic_t / wake_up_atomic_t
like wait_on_bit but atomic_t
>
> --
> Mel Gorman
> SUSE Labs
next prev parent reply other threads:[~2015-07-17 5:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 0:09 [mminit] [ INFO: possible recursive locking detected ] Fengguang Wu
2015-07-14 0:09 ` Fengguang Wu
2015-07-14 10:31 ` Mel Gorman
2015-07-14 10:31 ` Mel Gorman
2015-07-14 10:31 ` Mel Gorman
2015-07-16 17:13 ` Konstantin Khlebnikov
2015-07-16 17:13 ` Konstantin Khlebnikov
2015-07-16 17:13 ` Konstantin Khlebnikov
2015-07-16 17:33 ` Peter Zijlstra
2015-07-16 17:33 ` Peter Zijlstra
2015-07-16 17:33 ` Peter Zijlstra
2015-07-16 17:51 ` Mel Gorman
2015-07-16 17:51 ` Mel Gorman
2015-07-16 17:51 ` Mel Gorman
2015-07-17 5:06 ` Konstantin Khlebnikov [this message]
2015-07-17 5:06 ` Konstantin Khlebnikov
2015-07-17 5:06 ` Konstantin Khlebnikov
2015-07-20 14:01 ` Fengguang Wu
2015-07-20 14:01 ` Fengguang Wu
2015-07-20 14:01 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALYGNiMMeyW7GXHpdAONn4CckE5Q4cn64wwekZfk18q_W7xMsQ@mail.gmail.com \
--to=koct9i@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@01.org \
--cc=mgorman@suse.de \
--cc=nicstange@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.