From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
To: Alan Cooper <alcooperx@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: Conflicting PCI ID in bdc driver
Date: Tue, 12 Jan 2021 09:42:58 +0100 [thread overview]
Message-ID: <CAMeQTsZA7a9WcJq2tudWhaJbc6Z4vb4jtcUnHOCzg9u3oLxzbw@mail.gmail.com> (raw)
In-Reply-To: <CAOGqxeUkZ8VK-D3xutVvQk7e2t1=9GzLQL7oHz0GTj_FMdVeqw@mail.gmail.com>
On Tue, Jan 12, 2021 at 2:06 AM Alan Cooper <alcooperx@gmail.com> wrote:
>
> This driver was written for a PCI FPGA development board used to
> verify the controller logic and to help with driver development before
> adding the logic to our SoC's. I'm not sure why the driver was pushed
> upstream but I'd like to remove it. I'm checking with a few other
> groups to make sure I'm not missing anything.
That would solve my problem. Is removing a driver acceptable for
stable submission? If not, it would be helpful to have a patch
suitable for stable that disables the driver before removal. I'm
somewhat tired of explaining to people how to blacklist bdc.
>
> Thanks
> Al
>
>
> On Mon, Jan 11, 2021 at 5:02 PM Patrik Jakobsson
> <patrik.r.jakobsson@gmail.com> wrote:
> >
> > On Mon, Jan 11, 2021 at 9:29 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Jan 11, 2021 at 08:34:01PM +0100, Patrik Jakobsson wrote:
> > > > Hi Al,
> > > > The PCI device ID of 0x1570 in the bdc driver (bdc_pci.c) is
> > > > conflicting with the Apple FacetimeHD webcam [1]. Is this caused by an
> > > > incorrect ID in the bdc driver or are there actually two devices with
> > > > the same ID in the wild? If we have a real conflict, how would we go
> > > > about solving this?
> > >
> > > Looks like someone at broadcom messed up :(
> > >
> > > Can you look for any other fields in the device other than just the
> > > vendor/device ids to verify that this really is a webcam so you can not
> > > bind to the same thing this driver wants to bind to?
> >
> > Right, we could check the class. But I suppose it must be fixed in
> > both drivers? bdc must not bind to the webcam and facetimehd must not
> > bind to the UDC. So which class is bdc reporting?
> > PCI_CLASS_SERIAL_USB_DEVICE?
> >
> > >
> > > thanks,
> > >
> > > greg k-h
next prev parent reply other threads:[~2021-01-12 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 19:34 Conflicting PCI ID in bdc driver Patrik Jakobsson
2021-01-11 20:30 ` Greg Kroah-Hartman
2021-01-11 22:02 ` Patrik Jakobsson
2021-01-12 1:06 ` Alan Cooper
2021-01-12 8:42 ` Patrik Jakobsson [this message]
2021-01-12 8:58 ` Greg Kroah-Hartman
2021-01-12 19:51 ` Alan Cooper
2021-01-13 10:23 ` Greg Kroah-Hartman
2021-01-13 20:07 ` Alan Cooper
2021-01-14 7:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMeQTsZA7a9WcJq2tudWhaJbc6Z4vb4jtcUnHOCzg9u3oLxzbw@mail.gmail.com \
--to=patrik.r.jakobsson@gmail.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.