From: Alan Cooper <alcooperx@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: Conflicting PCI ID in bdc driver
Date: Tue, 12 Jan 2021 14:51:05 -0500 [thread overview]
Message-ID: <CAOGqxeXE4D7Dyf-9c=evZMG+PTGrycKTpY1=VBk7OVAWKmyh0A@mail.gmail.com> (raw)
In-Reply-To: <X/1ksTC4SBgrQoak@kroah.com>
I just checked with the hardware engineer that designed the BDC core.
The BDC PCI driver was used with an FPGA/PCIe board for design
verification and no one should be using this driver. I'll send a patch
that will remove this driver.
Thanks
Al
On Tue, Jan 12, 2021 at 3:57 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 12, 2021 at 09:42:58AM +0100, Patrik Jakobsson wrote:
> > On Tue, Jan 12, 2021 at 2:06 AM Alan Cooper <alcooperx@gmail.com> wrote:
> > >
> > > This driver was written for a PCI FPGA development board used to
> > > verify the controller logic and to help with driver development before
> > > adding the logic to our SoC's. I'm not sure why the driver was pushed
> > > upstream but I'd like to remove it. I'm checking with a few other
> > > groups to make sure I'm not missing anything.
> >
> > That would solve my problem. Is removing a driver acceptable for
> > stable submission?
>
> Not really, if there are users of that driver. Why not just mark the
> config to depend on BROKEN instead?
>
> But first we need to ensure that the users of it are really all gone.
>
> > If not, it would be helpful to have a patch
> > suitable for stable that disables the driver before removal. I'm
> > somewhat tired of explaining to people how to blacklist bdc.
>
> Why not submit your driver for inclusion in the kernel tree? We can
> make sure it doesn't conflict when that happens.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-01-12 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 19:34 Conflicting PCI ID in bdc driver Patrik Jakobsson
2021-01-11 20:30 ` Greg Kroah-Hartman
2021-01-11 22:02 ` Patrik Jakobsson
2021-01-12 1:06 ` Alan Cooper
2021-01-12 8:42 ` Patrik Jakobsson
2021-01-12 8:58 ` Greg Kroah-Hartman
2021-01-12 19:51 ` Alan Cooper [this message]
2021-01-13 10:23 ` Greg Kroah-Hartman
2021-01-13 20:07 ` Alan Cooper
2021-01-14 7:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOGqxeXE4D7Dyf-9c=evZMG+PTGrycKTpY1=VBk7OVAWKmyh0A@mail.gmail.com' \
--to=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.