From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linux PM list <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <damm@opensource.se>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] clocksource: sh_cmt: Only perform clocksource suspend/resume if enabled
Date: Thu, 18 Jun 2015 16:19:25 +0200 [thread overview]
Message-ID: <CAMuHMdUiDVVY1YE1Pt3gsFfNrTRAHgLdQ_F8CXOKG5aKW1TeFQ@mail.gmail.com> (raw)
In-Reply-To: <1829815.c8lIHLtv9K@avalon>
Hi Laurent,
On Thu, Jun 18, 2015 at 4:14 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday 18 June 2015 12:22:33 Geert Uytterhoeven wrote:
>> Currently the sh_cmt clocksource timer is disabled or enabled
>> unconditionally on clocksource suspend resp. resume, even if a better
>> clocksource is present (e.g. arch_sys_counter) and the sh_cmt
>> clocksource is not enabled.
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Good catch. The patch looks good to me.
While the solution was simple, it was hard to catch (engineers and
lightbulbs... euh timers ;-)
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
> I've quickly checked the MTU2 and TMU timer drivers and they should be immune
> to the issue, but I'd appreciate if you could confirm that.
I had concluded the same, thanks for verifying!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linux PM list <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <damm@opensource.se>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] clocksource: sh_cmt: Only perform clocksource suspend/resume if enabled
Date: Thu, 18 Jun 2015 14:19:25 +0000 [thread overview]
Message-ID: <CAMuHMdUiDVVY1YE1Pt3gsFfNrTRAHgLdQ_F8CXOKG5aKW1TeFQ@mail.gmail.com> (raw)
In-Reply-To: <1829815.c8lIHLtv9K@avalon>
Hi Laurent,
On Thu, Jun 18, 2015 at 4:14 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday 18 June 2015 12:22:33 Geert Uytterhoeven wrote:
>> Currently the sh_cmt clocksource timer is disabled or enabled
>> unconditionally on clocksource suspend resp. resume, even if a better
>> clocksource is present (e.g. arch_sys_counter) and the sh_cmt
>> clocksource is not enabled.
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Good catch. The patch looks good to me.
While the solution was simple, it was hard to catch (engineers and
lightbulbs... euh timers ;-)
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
> I've quickly checked the MTU2 and TMU timer drivers and they should be immune
> to the issue, but I'd appreciate if you could confirm that.
I had concluded the same, thanks for verifying!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-06-18 14:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 10:22 [PATCH 0/2] PM / Domains: Infinite loop during reboot Geert Uytterhoeven
2015-06-18 10:22 ` Geert Uytterhoeven
2015-06-18 10:22 ` [PATCH 1/2] clocksource: sh_cmt: Only perform clocksource suspend/resume if enabled Geert Uytterhoeven
2015-06-18 10:22 ` Geert Uytterhoeven
2015-06-18 14:14 ` Laurent Pinchart
2015-06-18 14:14 ` Laurent Pinchart
2015-06-18 14:19 ` Geert Uytterhoeven [this message]
2015-06-18 14:19 ` Geert Uytterhoeven
2015-06-18 10:22 ` [PATCH 2/2] PM / Domains: Avoid infinite loops in attach/detach code Geert Uytterhoeven
2015-06-18 10:22 ` Geert Uytterhoeven
2015-06-22 7:30 ` Geert Uytterhoeven
2015-06-22 7:30 ` Geert Uytterhoeven
2015-06-22 7:30 ` Geert Uytterhoeven
2015-06-22 7:31 ` Geert Uytterhoeven
2015-06-22 7:31 ` Geert Uytterhoeven
2015-06-22 7:31 ` Geert Uytterhoeven
2015-06-22 23:41 ` Rafael J. Wysocki
2015-06-22 23:41 ` Rafael J. Wysocki
2015-06-22 23:41 ` Rafael J. Wysocki
2015-06-23 7:16 ` Geert Uytterhoeven
2015-06-23 7:16 ` Geert Uytterhoeven
2015-06-23 7:16 ` Geert Uytterhoeven
2015-06-23 12:50 ` Ulf Hansson
2015-06-23 12:50 ` Ulf Hansson
2015-06-23 13:20 ` Geert Uytterhoeven
2015-06-23 13:20 ` Geert Uytterhoeven
2015-06-23 13:38 ` Rafael J. Wysocki
2015-06-23 13:38 ` Rafael J. Wysocki
2015-06-23 13:45 ` Geert Uytterhoeven
2015-06-23 13:45 ` Geert Uytterhoeven
2015-06-24 8:33 ` Ulf Hansson
2015-06-24 8:33 ` Ulf Hansson
2015-06-24 8:35 ` Geert Uytterhoeven
2015-06-24 8:35 ` Geert Uytterhoeven
2015-06-24 13:48 ` Rafael J. Wysocki
2015-06-24 13:48 ` Rafael J. Wysocki
2015-06-24 13:44 ` Rafael J. Wysocki
2015-06-24 14:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUiDVVY1YE1Pt3gsFfNrTRAHgLdQ_F8CXOKG5aKW1TeFQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=damm@opensource.se \
--cc=daniel.lezcano@linaro.org \
--cc=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.