From: Denis Kirjanov <kda@linux-powerpc.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org, airlied@gmail.com
Subject: Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
Date: Fri, 2 Oct 2015 11:48:55 +0300 [thread overview]
Message-ID: <CAOJe8K2avdaAhtr9vpDkoAEM4FcqO5u7qYF4TRFDKZmsgHEc_g@mail.gmail.com> (raw)
In-Reply-To: <1441684296.14597.2.camel@ellerman.id.au>
On 9/8/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-09-07 at 13:39 +0300, Denis Kirjanov wrote:
>> On 9/7/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
>> >> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> >> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
>> >> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>> >> >> > Fix the memory leak in create_gatt_table:
>> >> >> > we've lost a kfree on the exit path for the pages array allocated
>> >> >> > in uninorth_create_gatt_table
>> >> >> >
>> >> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>> >> >>
>> >> >> Hi Ben, Michael
>> >> >>
>> >> >> Will you take the patch through your trees or do I need to send it
>> >> >> to
>> >> >> Dave Airlie?
>> >> >
>> >> > I haven't had a chance to review yet...
>> >>
>> >> Ping...
>> >
>> > Hi Denis,
>> >
>> > Have you built and/or boot tested this?
>>
>> Hi,
>>
>> yes, sure. Actually I've spotted this through the kmemleak. With the
>> patch applied scanner is happy :)
>
> OK thanks. I'll merge it then, and if Ben ever reviews it and dislikes your
> changes he can send patches to fix it :)
Hi Michael,
could you please apply the patch to fixes branch?
Thanks!
>
> cheers
>
>
>
next prev parent reply other threads:[~2015-10-02 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 6:57 [PATCH] agp/uninorth: fix a memleak in create_gatt_table Denis Kirjanov
2015-06-18 14:34 ` Denis Kirjanov
2015-06-19 1:08 ` Benjamin Herrenschmidt
2015-09-07 7:30 ` Denis Kirjanov
2015-09-07 10:28 ` Michael Ellerman
2015-09-07 10:39 ` Denis Kirjanov
2015-09-08 3:51 ` Michael Ellerman
2015-10-02 8:48 ` Denis Kirjanov [this message]
2015-10-12 11:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJe8K2avdaAhtr9vpDkoAEM4FcqO5u7qYF4TRFDKZmsgHEc_g@mail.gmail.com \
--to=kda@linux-powerpc.org \
--cc=airlied@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.