All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	"Lukas F . Hartmann" <lukas@mntre.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: imx8mq: add support for MNT Reform2
Date: Tue, 11 May 2021 08:46:38 -0300	[thread overview]
Message-ID: <CAOMZO5AZEuKnwSpwdMp7SxLLE+5VQ3rnU-QVuP_yfnFqd6qJ4Q@mail.gmail.com> (raw)
In-Reply-To: <20210510185931.104780-3-l.stach@pengutronix.de>

On Mon, May 10, 2021 at 4:00 PM Lucas Stach <l.stach@pengutronix.de> wrote:


> +&i2c3 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c3>;
> +       status = "okay";
> +
> +       pcf8523: pcf8523@68 {

Just a nit: node names should be generic: rtc@68

Reviewed-by: Fabio Estevam <festevam@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	 "Lukas F . Hartmann" <lukas@mntre.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	 Sascha Hauer <kernel@pengutronix.de>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: imx8mq: add support for MNT Reform2
Date: Tue, 11 May 2021 08:46:38 -0300	[thread overview]
Message-ID: <CAOMZO5AZEuKnwSpwdMp7SxLLE+5VQ3rnU-QVuP_yfnFqd6qJ4Q@mail.gmail.com> (raw)
In-Reply-To: <20210510185931.104780-3-l.stach@pengutronix.de>

On Mon, May 10, 2021 at 4:00 PM Lucas Stach <l.stach@pengutronix.de> wrote:


> +&i2c3 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c3>;
> +       status = "okay";
> +
> +       pcf8523: pcf8523@68 {

Just a nit: node names should be generic: rtc@68

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-11 11:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 18:59 [PATCH v2 1/3] arm64: dts: imx8mq: add Nitrogen8 SoM Lucas Stach
2021-05-10 18:59 ` Lucas Stach
2021-05-10 18:59 ` [PATCH v2 2/3] dt-bindings: vendor-prefixes: add mntre Lucas Stach
2021-05-10 18:59   ` Lucas Stach
2021-05-10 18:59 ` [PATCH v2 3/3] arm64: dts: imx8mq: add support for MNT Reform2 Lucas Stach
2021-05-10 18:59   ` Lucas Stach
2021-05-11 11:46   ` Fabio Estevam [this message]
2021-05-11 11:46     ` Fabio Estevam
2021-05-11 19:04   ` Rob Herring
2021-05-11 19:04     ` Rob Herring
2021-05-23  3:21   ` Shawn Guo
2021-05-23  3:21     ` Shawn Guo
2021-05-11 11:43 ` [PATCH v2 1/3] arm64: dts: imx8mq: add Nitrogen8 SoM Fabio Estevam
2021-05-11 11:43   ` Fabio Estevam
2021-05-11 19:03 ` Rob Herring
2021-05-11 19:03   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AZEuKnwSpwdMp7SxLLE+5VQ3rnU-QVuP_yfnFqd6qJ4Q@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=lukas@mntre.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.