From: Dan Williams <dan.j.williams@intel.com> To: Shiyang Ruan <ruansy.fnst@fujitsu.com> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-xfs <linux-xfs@vger.kernel.org>, linux-nvdimm <linux-nvdimm@lists.01.org>, Linux MM <linux-mm@kvack.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, device-mapper development <dm-devel@redhat.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, david <david@fromorbit.com>, Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>, Goldwyn Rodrigues <rgoldwyn@suse.de> Subject: Re: [PATCH v4 01/10] pagemap: Introduce ->memory_failure() Date: Tue, 15 Jun 2021 17:18:18 -0700 [thread overview] Message-ID: <CAPcyv4ibuHeQ7o=sTZpQoryv=_3WuBFJhodBnAEVRPmvo=nAeQ@mail.gmail.com> (raw) In-Reply-To: <20210604011844.1756145-2-ruansy.fnst@fujitsu.com> On Thu, Jun 3, 2021 at 6:19 PM Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote: Hi Ruan, apologies for the delays circling back to this. > > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page located in. And finally call filesystem handler to > deal with this error. > > The filesystem will try to recover the corrupted data if possiable. > Let's move this change to the patch that needs it, this patch does not do anything on its own. > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> > --- > include/linux/memremap.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 45a79da89c5f..473fe18c516a 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -87,6 +87,14 @@ struct dev_pagemap_ops { > * the page back to a CPU accessible page. > */ > vm_fault_t (*migrate_to_ram)(struct vm_fault *vmf); > + > + /* > + * Handle the memory failure happens on one page. Notify the processes > + * who are using this page, and try to recover the data on this page > + * if necessary. > + */ I thought we discussed that this needed to be range based here: https://lore.kernel.org/r/CAPcyv4jhUU3NVD8HLZnJzir+SugB6LnnrgJZ-jP45BZrbJ1dJQ@mail.gmail.com ...but also incorporate Christoph's feedback to not use notifiers. > + int (*memory_failure)(struct dev_pagemap *pgmap, unsigned long pfn, > + int flags); Change this callback to int (*notify_memory_failure)(struct dev_pagemap *pgmap, unsigned long pfn, unsigned long nr_pfns) ...to pass a range and to clarify that this callback is for memory_failure() to notify the pgmap, the pgmap notifies the owner via the holder callbacks.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: Shiyang Ruan <ruansy.fnst@fujitsu.com> Cc: Mike Snitzer <snitzer@redhat.com>, linux-nvdimm <linux-nvdimm@lists.01.org>, Goldwyn Rodrigues <rgoldwyn@suse.de>, "Darrick J. Wong" <darrick.wong@oracle.com>, david <david@fromorbit.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-xfs <linux-xfs@vger.kernel.org>, Linux MM <linux-mm@kvack.org>, device-mapper development <dm-devel@redhat.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com> Subject: Re: [dm-devel] [PATCH v4 01/10] pagemap: Introduce ->memory_failure() Date: Tue, 15 Jun 2021 17:18:18 -0700 [thread overview] Message-ID: <CAPcyv4ibuHeQ7o=sTZpQoryv=_3WuBFJhodBnAEVRPmvo=nAeQ@mail.gmail.com> (raw) In-Reply-To: <20210604011844.1756145-2-ruansy.fnst@fujitsu.com> On Thu, Jun 3, 2021 at 6:19 PM Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote: Hi Ruan, apologies for the delays circling back to this. > > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page located in. And finally call filesystem handler to > deal with this error. > > The filesystem will try to recover the corrupted data if possiable. > Let's move this change to the patch that needs it, this patch does not do anything on its own. > Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com> > --- > include/linux/memremap.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 45a79da89c5f..473fe18c516a 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -87,6 +87,14 @@ struct dev_pagemap_ops { > * the page back to a CPU accessible page. > */ > vm_fault_t (*migrate_to_ram)(struct vm_fault *vmf); > + > + /* > + * Handle the memory failure happens on one page. Notify the processes > + * who are using this page, and try to recover the data on this page > + * if necessary. > + */ I thought we discussed that this needed to be range based here: https://lore.kernel.org/r/CAPcyv4jhUU3NVD8HLZnJzir+SugB6LnnrgJZ-jP45BZrbJ1dJQ@mail.gmail.com ...but also incorporate Christoph's feedback to not use notifiers. > + int (*memory_failure)(struct dev_pagemap *pgmap, unsigned long pfn, > + int flags); Change this callback to int (*notify_memory_failure)(struct dev_pagemap *pgmap, unsigned long pfn, unsigned long nr_pfns) ...to pass a range and to clarify that this callback is for memory_failure() to notify the pgmap, the pgmap notifies the owner via the holder callbacks. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-16 0:18 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-04 1:18 [PATCH v4 00/10] fsdax: introduce fs query to support reflink Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-04 1:18 ` [PATCH v4 01/10] pagemap: Introduce ->memory_failure() Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-16 0:18 ` Dan Williams [this message] 2021-06-16 0:18 ` Dan Williams 2021-06-04 1:18 ` [PATCH v4 02/10] dax: Introduce holder for dax_device Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-16 0:46 ` Dan Williams 2021-06-16 0:46 ` Dan Williams 2021-06-04 1:18 ` [PATCH v4 03/10] fs: Introduce ->corrupted_range() for superblock Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-16 0:48 ` Dan Williams 2021-06-16 0:48 ` Dan Williams 2021-06-17 6:51 ` ruansy.fnst 2021-06-17 6:51 ` [dm-devel] " ruansy.fnst 2021-06-17 7:04 ` Dan Williams 2021-06-17 7:04 ` Dan Williams 2021-06-17 8:12 ` ruansy.fnst 2021-06-17 8:12 ` [dm-devel] " ruansy.fnst 2021-06-04 1:18 ` [PATCH v4 04/10] mm, fsdax: Refactor memory-failure handler for dax mapping Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-16 6:30 ` Dan Williams 2021-06-16 6:30 ` Dan Williams 2021-06-17 7:51 ` ruansy.fnst 2021-06-17 7:51 ` [dm-devel] " ruansy.fnst 2021-06-04 1:18 ` [PATCH v4 05/10] mm, pmem: Implement ->memory_failure() in pmem driver Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-16 6:49 ` Dan Williams 2021-06-16 6:49 ` Dan Williams 2021-06-04 1:18 ` [PATCH v4 06/10] fs/dax: Implement dax_holder_operations Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-04 1:18 ` [PATCH v4 07/10] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-04 1:18 ` [PATCH v4 08/10] md: Implement dax_holder_operations Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-04 5:48 ` kernel test robot 2021-06-04 5:48 ` kernel test robot 2021-06-04 5:48 ` kernel test robot 2021-06-04 1:18 ` [PATCH v4 09/10] xfs: Implement ->corrupted_range() for XFS Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan 2021-06-04 5:22 ` kernel test robot 2021-06-04 5:22 ` kernel test robot 2021-06-04 5:22 ` [dm-devel] " kernel test robot 2021-06-04 5:40 ` kernel test robot 2021-06-04 5:40 ` kernel test robot 2021-06-04 5:40 ` kernel test robot 2021-06-04 1:18 ` [PATCH v4 10/10] fs/dax: Remove useless functions Shiyang Ruan 2021-06-04 1:18 ` [dm-devel] " Shiyang Ruan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPcyv4ibuHeQ7o=sTZpQoryv=_3WuBFJhodBnAEVRPmvo=nAeQ@mail.gmail.com' \ --to=dan.j.williams@intel.com \ --cc=agk@redhat.com \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=dm-devel@redhat.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ --cc=rgoldwyn@suse.de \ --cc=ruansy.fnst@fujitsu.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.