From: Akhil Goyal <gakhil@marvell.com>
To: Raja Zidane <rzidane@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "matan@nvidia.com" <matan@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] compress/mlx5: fix level translation in xform API
Date: Sat, 31 Jul 2021 17:57:23 +0000 [thread overview]
Message-ID: <CO6PR18MB44847E10E92FFDE12F75FBEBD8ED9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210729141108.20908-1-rzidane@nvidia.com>
> Compression Level is interpreted by each PMD differently.
> However, lower numbers give faster compression
> at the expense of compression ratio, while higher numbers
> may give better compression ratios but are likely slower.
> The level affects the block size, which affects performance,
> the bigger the block, the faster the compression is.
>
> The problem was that higher levels caused bigger blocks:
> size = min_block_size - 1 + level.
>
> the solution is to reverse the above:
> size = max_block_size + 1 - level.
>
> Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations")
> Cc: matan@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
This patch is not acked, hence not applied for RC3.
@Thomas Monjalon can you pick it directly if it gets acked?
next prev parent reply other threads:[~2021-07-31 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:11 [dpdk-dev] [PATCH] compress/mlx5: fix level translation in xform API Raja Zidane
2021-07-31 17:57 ` Akhil Goyal [this message]
2021-08-01 6:13 ` Matan Azrad
2021-08-03 12:11 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44847E10E92FFDE12F75FBEBD8ED9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rzidane@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.