From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "Reyna, David L (Wind River)" <david.reyna@windriver.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited
Date: Wed, 2 Sep 2015 15:58:21 +0000 [thread overview]
Message-ID: <D20CDABF.63E49%belen.barros.pena@intel.com> (raw)
In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D082655F65@ALA-MBA.corp.ad.wrs.com>
On 02/09/2015 15:46, "Reyna, David" <david.reyna@windriver.com> wrote:
>Hi Belén,
>
>Thank you for the observation.
>
>I have updated "dreyna/project_fstypes_8126" to address that issue, and
>the code now always pre-initializes the warning message element so that
>the previous value is not dangling.
yep: this seems to behave as expected now. Thanks!
I've also realised that the base branch seems a bit old. Could you rebase
and resubmit?
Cheers
Belén
>
>- David
>
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>> Sent: Wednesday, September 02, 2015 2:16 AM
>> To: Reyna, David
>> Cc: toaster@yoctoproject.org
>> Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are missing
>> when "IMAGE_FSTYPES" field is not properly edited
>>
>>
>>
>> On 02/09/2015 08:44, "Reyna, David" <david.reyna@windriver.com> wrote:
>>
>> >Hi Belén,
>> >
>> >Please find the patch for 8126 here:
>> >
>> > dreyna/project_fstypes_8126
>>
>> Hi David,
>>
>> This is looking fairly good. I've only run across one problem. This is
>>how
>> to reproduce:
>>
>> 1. Click the 'change' icon for IMAGE_FSTYPES
>>
>> 2. Deselect all values: the 'save' button becomes disabled and the
>>message
>> asking you to select at least one image type appears. This is the
>>expected
>> behaviour
>>
>> 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the way
>>it
>> was before you clicked the 'change' icon. This is once more the correct
>> behaviour
>>
>> 4. Now click the 'change' icon again. There are image types selected,
>>but
>> the message 'You must select at least one image type' still shows, and
>>the
>> 'Save' button is disabled. This is not the correct behaviour. As long as
>> there is at least one checkbox ticked you should see no message and the
>> 'save' button should be enabled. If you make a change (untick a box),
>>the
>> validation kicks in and things return to the correct state. Sounds like
>>we
>> need to check the selected values whenever the 'change' icon is clicked
>>
>> Thanks!
>>
>> Belén
>>
>> >
>> >Note: for the message 'label' the I insert and then show when there are
>> >no matches, it is guaranteed not to pollute the database because it can
>> >never be in the checked state.
>> >
>> >- David
>> >
>>
>
next prev parent reply other threads:[~2015-09-02 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 7:44 [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited Reyna, David
2015-09-02 9:16 ` Barros Pena, Belen
2015-09-02 14:46 ` Reyna, David
2015-09-02 15:58 ` Barros Pena, Belen [this message]
2015-09-14 14:19 ` Michael Wood
2015-09-23 9:02 ` Reyna, David
2015-09-28 10:11 ` Barros Pena, Belen
2015-09-30 10:59 ` Michael Wood
2015-09-30 11:04 ` Barros Pena, Belen
2015-09-30 13:47 ` Reyna, David
2015-09-30 14:05 ` Barros Pena, Belen
2015-10-06 15:44 ` Michael Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D20CDABF.63E49%belen.barros.pena@intel.com \
--to=belen.barros.pena@intel.com \
--cc=david.reyna@windriver.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.