From: "Abdul, Hussain (H.)" <habdul@visteon.com>
To: Ian Abbott <abbotti@mev.co.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ravindran, Madhusudhanan (M.)" <mravindr@visteon.com>,
"Dighe, Niranjan (N.)" <ndighe@visteon.com>
Subject: Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence
Date: Tue, 16 Jun 2015 14:08:33 +0000 [thread overview]
Message-ID: <DB5PR06MB1112A333A49A22CD4A2D66FDDFA70@DB5PR06MB1112.eurprd06.prod.outlook.com> (raw)
In-Reply-To: 5580209A.1050205@mev.co.uk
On Tuesday 16 June 2015 06:42 PM, Ian Abbott wrote:
> On 16/06/15 08:58, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <habdul@visteon.com>
>>
>> This patch simplify a trivial if-return sequence. Possibly combine with
>> a preceding function call.
>>
>> Signed-off-by: Abdul Hussain <habdul@visteon.com>
>> ---
>> drivers/staging/comedi/drivers/dac02.c | 6 +-----
>> drivers/staging/comedi/drivers/daqboard2000.c | 6 +-----
>> drivers/staging/comedi/drivers/dmm32at.c | 6 +-----
>> drivers/staging/comedi/drivers/fl512.c | 6 +-----
>> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
>> drivers/staging/comedi/drivers/s626.c | 6 +-----
>> 6 files changed, 6 insertions(+), 30 deletions(-)
>>
> Ideally, this should be split into separate patches.
>
> [snip]
>> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
>> index 611b0a3..0fe40c2 100644
>> --- a/drivers/staging/comedi/drivers/daqboard2000.c
>> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
>> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>> return result;
>>
>> s = &dev->subdevices[2];
>> - result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
>> + return subdev_8255_init(dev, s, daqboard2000_8255_cb,
>> dioP2ExpansionIO8Bit);
> That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a
> couple of spaces so it still lines up with the 'dev' on the preceding line.
>
Ian,
Split and sent as separate patches with the above change.
Thanks,
Abdul
prev parent reply other threads:[~2015-06-16 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 7:58 [PATCH] Staging: comedi: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-16 13:11 ` Ian Abbott
2015-06-16 14:08 ` Abdul, Hussain (H.) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR06MB1112A333A49A22CD4A2D66FDDFA70@DB5PR06MB1112.eurprd06.prod.outlook.com \
--to=habdul@visteon.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mravindr@visteon.com \
--cc=ndighe@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.