RE: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()

From: Aisheng Dong <aisheng.dong@nxp.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
	Frank Li <frank.li@nxp.com>, "will@kernel.org" <will@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
Date: Thu, 17 Jun 2021 12:24:12 +0000	[thread overview]
Message-ID: <DB9PR04MB84777974EF797DA08E9DFD6F800E9@DB9PR04MB8477.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210617122614.166823-1-jingxiangfeng@huawei.com>

> From: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Sent: Thursday, June 17, 2021 8:26 PM
> Subject: [PATCH] drivers/perf: fix the missed ida_simple_remove() in
> ddr_perf_probe()
> 

drivers/perf: imx8_ddr: xxxx

Otherwise:

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng

> ddr_perf_probe() misses to call ida_simple_remove() in an error path.
> Jump to cpuhp_state_err to fix it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
>  drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 2bbb93188064..7b87aaf267d5 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -705,8 +705,10 @@ static int ddr_perf_probe(struct platform_device
> *pdev)
> 
>  	name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> DDR_PERF_DEV_NAME "%d",
>  			      num);
> -	if (!name)
> -		return -ENOMEM;
> +	if (!name) {
> +		ret = -ENOMEM;
> +		goto cpuhp_state_err;
> +	}
> 
>  	pmu->devtype_data = of_device_get_match_data(&pdev->dev);
> 
> --
> 2.26.0.106.g9fadedd