From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Fred Oh <fred.oh@linux.intel.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Mark Brown <broonie@kernel.org>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
Libin Yang <libin.yang@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>
Subject: RE: [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support
Date: Tue, 16 Mar 2021 15:20:11 +0000 [thread overview]
Message-ID: <DM6PR11MB3642B7F0E8D288CFD7772CBB976B9@DM6PR11MB3642.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3e48f98a-247f-1784-2d72-ccd6feae1cd4@linux.intel.com>
> > +/*
> > + * rt1015: i2c mode driver for ALC1015 and ALC1015Q
> > + * rt1015p: auto-mode driver for ALC1015, ALC1015Q, and ALC1015Q-VB
> > +*/ static const struct snd_soc_dapm_route rt1015p_1dev_dapm_routes[]
> > += {
> > + /* speaker */
> > + { "Left Spk", NULL, "Speaker" },
> > + { "Right Spk", NULL, "Speaker" },
> > +};
> > +
> > +static const struct snd_soc_dapm_route rt1015p_2dev_dapm_routes[] = {
> > + /* speaker */
> > + { "Left Spk", NULL, "Left Speaker" },
> > + { "Right Spk", NULL, "Right Speaker" }, };
>
> I am confused by these routes...
>
> is this a result of using the codec confs below only when there are 2 amps with
> their own enable pin?
Yes, we need to use the prefix in codec confs when there are two device instances.
>
> You still have 2 amps even in the 1dev case, so I want to make sure the code has
> enough comments so that we don't lose track of the design.
>
> The rest of the code looks fine.
>
There are always two amps on the board for stereo output. If the two amps sharing
one enable pin, ODM will implement only one device instance in the ACPI table
because there is only one GPIO to control in codec driver.
I'll upload a v3 with more comment.
Regards,
Brent
WARNING: multiple messages have this Message-ID (diff)
From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jie Yang <yang.jie@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Fred Oh <fred.oh@linux.intel.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Mark Brown <broonie@kernel.org>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Libin Yang <libin.yang@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>
Subject: RE: [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support
Date: Tue, 16 Mar 2021 15:20:11 +0000 [thread overview]
Message-ID: <DM6PR11MB3642B7F0E8D288CFD7772CBB976B9@DM6PR11MB3642.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3e48f98a-247f-1784-2d72-ccd6feae1cd4@linux.intel.com>
> > +/*
> > + * rt1015: i2c mode driver for ALC1015 and ALC1015Q
> > + * rt1015p: auto-mode driver for ALC1015, ALC1015Q, and ALC1015Q-VB
> > +*/ static const struct snd_soc_dapm_route rt1015p_1dev_dapm_routes[]
> > += {
> > + /* speaker */
> > + { "Left Spk", NULL, "Speaker" },
> > + { "Right Spk", NULL, "Speaker" },
> > +};
> > +
> > +static const struct snd_soc_dapm_route rt1015p_2dev_dapm_routes[] = {
> > + /* speaker */
> > + { "Left Spk", NULL, "Left Speaker" },
> > + { "Right Spk", NULL, "Right Speaker" }, };
>
> I am confused by these routes...
>
> is this a result of using the codec confs below only when there are 2 amps with
> their own enable pin?
Yes, we need to use the prefix in codec confs when there are two device instances.
>
> You still have 2 amps even in the 1dev case, so I want to make sure the code has
> enough comments so that we don't lose track of the design.
>
> The rest of the code looks fine.
>
There are always two amps on the board for stereo output. If the two amps sharing
one enable pin, ODM will implement only one device instance in the ACPI table
because there is only one GPIO to control in codec driver.
I'll upload a v3 with more comment.
Regards,
Brent
next prev parent reply other threads:[~2021-03-16 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 9:46 [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support Brent Lu
2021-03-16 9:46 ` Brent Lu
2021-03-16 15:04 ` Pierre-Louis Bossart
2021-03-16 15:04 ` Pierre-Louis Bossart
2021-03-16 15:20 ` Lu, Brent [this message]
2021-03-16 15:20 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3642B7F0E8D288CFD7772CBB976B9@DM6PR11MB3642.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=libin.yang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.