From: "Liu, Yujie" <yujie.liu@intel.com>
To: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: lkp <lkp@intel.com>, LKML <linux-kernel@vger.kernel.org>,
"lkp@lists.01.org" <lkp@lists.01.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kaleshsingh@google.com" <kaleshsingh@google.com>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"joel@joelfernandes.org" <joel@joelfernandes.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
"Sang, Oliver" <oliver.sang@intel.com>
Subject: RE: [LKP] Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
Date: Thu, 17 Jun 2021 02:38:29 +0000 [thread overview]
Message-ID: <SJ0PR11MB5598DC21AC79E6D8D5F485FDFB0E9@SJ0PR11MB5598.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a815a022-cf3e-fe4b-ee23-191523ed1980@linux.ibm.com>
> -----Original Message-----
> From: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Sent: Tuesday, June 15, 2021 12:09 AM
> To: Sang, Oliver <oliver.sang@intel.com>
> Cc: lkp <lkp@intel.com>; LKML <linux-kernel@vger.kernel.org>; lkp@lists.01.org; linux-mm@kvack.org; akpm@linux-foundation.org;
> mpe@ellerman.id.au; linuxppc-dev@lists.ozlabs.org; kaleshsingh@google.com; npiggin@gmail.com; joel@joelfernandes.org; Christophe
> Leroy <christophe.leroy@csgroup.eu>; Linus Torvalds <torvalds@linux-foundation.org>; Kirill A . Shutemov <kirill@shutemov.name>
> Subject: [LKP] Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
>
> On 6/14/21 8:25 PM, kernel test robot wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed a -29.4% regression of vm-scalability.throughput due to commit:
> >
> >
> > commit: ecf8443e51a862b261313c2319ab4e4aed9e6b7e ("[PATCH v7 02/11]
> > mm/mremap: Fix race between MOVE_PUD mremap and pageout")
> > url:
> > https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Speedup-mrem
> > ap-on-ppc64/20210607-135424
> > base: https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git
> > next
> >
> >
>
> We dropped that approach and is now using https://lore.kernel.org/linux-mm/20210610083549.386085-1-aneesh.kumar@linux.ibm.com
>
>
> Instead of pud lock we are now using rmap lock with mremap.
>
> Can you check with that series?
Hi Aneesh,
Could you please specify the base commit of the patch series?
We have applied new patch series(rmap lock with mremap) on commit 027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN), and it shows no regression after patch.
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN) <--- patch's base commit
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit
57da7477067d (fixup) <--- apply patch on 027f55e87c30
027f55e87c309427 ecf8443e51a862b261313c2319a 57da7477067dbe29247484eda0e
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
371814 ± 3% -29.1% 263582 ± 3% -0.1% 371286 ± 2% vm-scalability.median
We also tried to apply patches on commit ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout), and the regression increased to -33.9%
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
5f80ee2fc08b (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit's parent
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PMD mremap and pageout) <--- first bad commit
8ae369d45894 (fixup) <--- apply patch on ecf8443e51a8
5f80ee2fc08b3613 ecf8443e51a862b261313c2319a 8ae369d4589492c7f7198cd742d
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
373210 -29.4% 263582 ± 3% -33.9% 246626 ± 2% vm-scalability.median
Thanks
> -aneesh
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Liu, Yujie" <yujie.liu@intel.com>
To: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: lkp <lkp@intel.com>, "lkp@lists.01.org" <lkp@lists.01.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Sang, Oliver" <oliver.sang@intel.com>,
"kaleshsingh@google.com" <kaleshsingh@google.com>,
"joel@joelfernandes.org" <joel@joelfernandes.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [LKP] Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
Date: Thu, 17 Jun 2021 02:38:29 +0000 [thread overview]
Message-ID: <SJ0PR11MB5598DC21AC79E6D8D5F485FDFB0E9@SJ0PR11MB5598.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a815a022-cf3e-fe4b-ee23-191523ed1980@linux.ibm.com>
> -----Original Message-----
> From: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Sent: Tuesday, June 15, 2021 12:09 AM
> To: Sang, Oliver <oliver.sang@intel.com>
> Cc: lkp <lkp@intel.com>; LKML <linux-kernel@vger.kernel.org>; lkp@lists.01.org; linux-mm@kvack.org; akpm@linux-foundation.org;
> mpe@ellerman.id.au; linuxppc-dev@lists.ozlabs.org; kaleshsingh@google.com; npiggin@gmail.com; joel@joelfernandes.org; Christophe
> Leroy <christophe.leroy@csgroup.eu>; Linus Torvalds <torvalds@linux-foundation.org>; Kirill A . Shutemov <kirill@shutemov.name>
> Subject: [LKP] Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
>
> On 6/14/21 8:25 PM, kernel test robot wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed a -29.4% regression of vm-scalability.throughput due to commit:
> >
> >
> > commit: ecf8443e51a862b261313c2319ab4e4aed9e6b7e ("[PATCH v7 02/11]
> > mm/mremap: Fix race between MOVE_PUD mremap and pageout")
> > url:
> > https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Speedup-mrem
> > ap-on-ppc64/20210607-135424
> > base: https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git
> > next
> >
> >
>
> We dropped that approach and is now using https://lore.kernel.org/linux-mm/20210610083549.386085-1-aneesh.kumar@linux.ibm.com
>
>
> Instead of pud lock we are now using rmap lock with mremap.
>
> Can you check with that series?
Hi Aneesh,
Could you please specify the base commit of the patch series?
We have applied new patch series(rmap lock with mremap) on commit 027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN), and it shows no regression after patch.
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN) <--- patch's base commit
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit
57da7477067d (fixup) <--- apply patch on 027f55e87c30
027f55e87c309427 ecf8443e51a862b261313c2319a 57da7477067dbe29247484eda0e
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
371814 ± 3% -29.1% 263582 ± 3% -0.1% 371286 ± 2% vm-scalability.median
We also tried to apply patches on commit ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout), and the regression increased to -33.9%
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
5f80ee2fc08b (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit's parent
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PMD mremap and pageout) <--- first bad commit
8ae369d45894 (fixup) <--- apply patch on ecf8443e51a8
5f80ee2fc08b3613 ecf8443e51a862b261313c2319a 8ae369d4589492c7f7198cd742d
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
373210 -29.4% 263582 ± 3% -33.9% 246626 ± 2% vm-scalability.median
Thanks
> -aneesh
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Liu, Yujie <yujie.liu@intel.com>
To: lkp@lists.01.org
Subject: Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
Date: Thu, 17 Jun 2021 02:38:29 +0000 [thread overview]
Message-ID: <SJ0PR11MB5598DC21AC79E6D8D5F485FDFB0E9@SJ0PR11MB5598.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a815a022-cf3e-fe4b-ee23-191523ed1980@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 5688 bytes --]
> -----Original Message-----
> From: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Sent: Tuesday, June 15, 2021 12:09 AM
> To: Sang, Oliver <oliver.sang@intel.com>
> Cc: lkp <lkp@intel.com>; LKML <linux-kernel@vger.kernel.org>; lkp(a)lists.01.org; linux-mm(a)kvack.org; akpm(a)linux-foundation.org;
> mpe(a)ellerman.id.au; linuxppc-dev(a)lists.ozlabs.org; kaleshsingh(a)google.com; npiggin(a)gmail.com; joel(a)joelfernandes.org; Christophe
> Leroy <christophe.leroy@csgroup.eu>; Linus Torvalds <torvalds@linux-foundation.org>; Kirill A . Shutemov <kirill@shutemov.name>
> Subject: [LKP] Re: [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression
>
> On 6/14/21 8:25 PM, kernel test robot wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed a -29.4% regression of vm-scalability.throughput due to commit:
> >
> >
> > commit: ecf8443e51a862b261313c2319ab4e4aed9e6b7e ("[PATCH v7 02/11]
> > mm/mremap: Fix race between MOVE_PUD mremap and pageout")
> > url:
> > https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Speedup-mrem
> > ap-on-ppc64/20210607-135424
> > base: https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git
> > next
> >
> >
>
> We dropped that approach and is now using https://lore.kernel.org/linux-mm/20210610083549.386085-1-aneesh.kumar(a)linux.ibm.com
>
>
> Instead of pud lock we are now using rmap lock with mremap.
>
> Can you check with that series?
Hi Aneesh,
Could you please specify the base commit of the patch series?
We have applied new patch series(rmap lock with mremap) on commit 027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN), and it shows no regression after patch.
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
027f55e87c30 (tty: hvc: udbg_hvc: retry putc on -EAGAIN) <--- patch's base commit
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit
57da7477067d (fixup) <--- apply patch on 027f55e87c30
027f55e87c309427 ecf8443e51a862b261313c2319a 57da7477067dbe29247484eda0e
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
371814 ± 3% -29.1% 263582 ± 3% -0.1% 371286 ± 2% vm-scalability.median
We also tried to apply patches on commit ecf8443e51a8 (mm/mremap: Fix race between MOVE_PUD mremap and pageout), and the regression increased to -33.9%
=========================================================================================
compiler/cpufreq_governor/kconfig/nr_ssd/nr_task/rootfs/runtime/tbox_group/test/testcase/thp_defrag/thp_enabled/uco
de:
gcc-9/performance/x86_64-rhel-8.3/1/8/debian-10.4-x86_64-20200603.cgz/300/lkp-csl-2ap1/swap-w-seq-mt/vm-scalabili
ty/always/never/0x4003006
commit:
5f80ee2fc08b (mm/mremap: Fix race between MOVE_PUD mremap and pageout) <--- first bad commit's parent
ecf8443e51a8 (mm/mremap: Fix race between MOVE_PMD mremap and pageout) <--- first bad commit
8ae369d45894 (fixup) <--- apply patch on ecf8443e51a8
5f80ee2fc08b3613 ecf8443e51a862b261313c2319a 8ae369d4589492c7f7198cd742d
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
373210 -29.4% 263582 ± 3% -33.9% 246626 ± 2% vm-scalability.median
Thanks
> -aneesh
> _______________________________________________
> LKP mailing list -- lkp(a)lists.01.org
> To unsubscribe send an email to lkp-leave(a)lists.01.org
next prev parent reply other threads:[~2021-06-17 2:38 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 5:51 [PATCH v7 00/11] Speedup mremap on ppc64 Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 01/11] mm/mremap: Fix race between MOVE_PMD mremap and pageout Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-08 0:06 ` Hugh Dickins
2021-06-08 0:06 ` Hugh Dickins
2021-06-08 7:52 ` Aneesh Kumar K.V
2021-06-08 7:52 ` Aneesh Kumar K.V
2021-06-08 9:42 ` Kirill A. Shutemov
2021-06-08 9:42 ` Kirill A. Shutemov
2021-06-08 11:17 ` Aneesh Kumar K.V
2021-06-08 11:17 ` Aneesh Kumar K.V
2021-06-08 12:05 ` Kirill A. Shutemov
2021-06-08 12:05 ` Kirill A. Shutemov
2021-06-08 20:39 ` Hugh Dickins
2021-06-08 20:39 ` Hugh Dickins
2021-06-07 5:51 ` [PATCH v7 02/11] mm/mremap: Fix race between MOVE_PUD " Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-14 14:55 ` [mm/mremap] ecf8443e51: vm-scalability.throughput -29.4% regression kernel test robot
2021-06-14 14:55 ` kernel test robot
2021-06-14 14:55 ` kernel test robot
2021-06-14 14:58 ` Linus Torvalds
2021-06-14 14:58 ` Linus Torvalds
2021-06-14 14:58 ` Linus Torvalds
2021-06-14 16:08 ` Aneesh Kumar K.V
2021-06-14 16:08 ` Aneesh Kumar K.V
2021-06-14 16:08 ` Aneesh Kumar K.V
2021-06-17 2:38 ` Liu, Yujie [this message]
2021-06-17 2:38 ` Liu, Yujie
2021-06-17 2:38 ` [LKP] " Liu, Yujie
2021-06-07 5:51 ` [PATCH v7 03/11] selftest/mremap_test: Update the test to handle pagesize other than 4K Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 04/11] selftest/mremap_test: Avoid crash with static build Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 05/11] mm/mremap: Convert huge PUD move to separate helper Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 06/11] mm/mremap: Don't enable optimized PUD move if page table levels is 2 Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 07/11] mm/mremap: Use pmd/pud_poplulate to update page table entries Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 08/11] powerpc/mm/book3s64: Fix possible build error Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 09/11] mm/mremap: Allow arch runtime override Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 10/11] powerpc/book3s64/mm: Update flush_tlb_range to flush page walk cache Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 5:51 ` [PATCH v7 11/11] powerpc/mm: Enable HAVE_MOVE_PMD support Aneesh Kumar K.V
2021-06-07 5:51 ` Aneesh Kumar K.V
2021-06-07 10:10 ` [PATCH v7 00/11] Speedup mremap on ppc64 Nick Piggin
2021-06-07 10:10 ` Nick Piggin
2021-06-08 4:39 ` Aneesh Kumar K.V
2021-06-08 4:39 ` Aneesh Kumar K.V
2021-06-08 5:03 ` Nicholas Piggin
2021-06-08 5:03 ` Nicholas Piggin
2021-06-08 17:10 ` Linus Torvalds
2021-06-08 17:10 ` Linus Torvalds
2021-06-16 1:44 ` Nicholas Piggin
2021-06-16 1:44 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5598DC21AC79E6D8D5F485FDFB0E9@SJ0PR11MB5598.namprd11.prod.outlook.com \
--to=yujie.liu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oliver.sang@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.