From: Wang Dongsheng <Dongsheng.Wang@freescale.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
Date: Wed, 12 Aug 2015 07:50:03 +0000 [thread overview]
Message-ID: <SN1PR0301MB161694E7F5018A10A74DD2AC9D7E0@SN1PR0301MB1616.namprd03.prod.outlook.com> (raw)
In-Reply-To: 20150714225041.GH20482@piout.net
Hi Belloni,
I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Wednesday, July 15, 2015 10:06 AM
> To: 'Alexandre Belloni'
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Thanks Belloni. :)
>
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > Sent: Wednesday, July 15, 2015 6:51 AM
> > To: Wang Dongsheng-B40534
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > resume function
> >
> > Hi,
> >
> > This seems ok, one small nitpick:
> >
> > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > 7e48e53..2081155 100644
> > > --- a/drivers/rtc/rtc-ds3232.c
> > > +++ b/drivers/rtc/rtc-ds3232.c
> > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > >
> > > if (device_can_wakeup(dev)) {
> > > ds3232->suspended = true;
> > > - irq_set_irq_wake(client->irq, 1);
> > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> >
> > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > log each time the machine is suspended.
> >
> > --
> > Alexandre Belloni, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Wang Dongsheng <Dongsheng.Wang@freescale.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [rtc-linux] RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
Date: Wed, 12 Aug 2015 07:50:03 +0000 [thread overview]
Message-ID: <SN1PR0301MB161694E7F5018A10A74DD2AC9D7E0@SN1PR0301MB1616.namprd03.prod.outlook.com> (raw)
In-Reply-To: 20150714225041.GH20482@piout.net
Hi Belloni,
I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Wednesday, July 15, 2015 10:06 AM
> To: 'Alexandre Belloni'
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Thanks Belloni. :)
>
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > Sent: Wednesday, July 15, 2015 6:51 AM
> > To: Wang Dongsheng-B40534
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > resume function
> >
> > Hi,
> >
> > This seems ok, one small nitpick:
> >
> > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > 7e48e53..2081155 100644
> > > --- a/drivers/rtc/rtc-ds3232.c
> > > +++ b/drivers/rtc/rtc-ds3232.c
> > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > >
> > > if (device_can_wakeup(dev)) {
> > > ds3232->suspended = true;
> > > - irq_set_irq_wake(client->irq, 1);
> > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> >
> > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > log each time the machine is suspended.
> >
> > --
> > Alexandre Belloni, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-08-12 7:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 6:12 [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function Dongsheng Wang
2015-07-07 6:12 ` [rtc-linux] " Dongsheng Wang
2015-07-14 22:50 ` Alexandre Belloni
2015-07-14 22:50 ` [rtc-linux] " Alexandre Belloni
2015-07-15 2:06 ` Wang Dongsheng
2015-07-15 2:06 ` [rtc-linux] " Wang Dongsheng
2015-08-12 7:50 ` Wang Dongsheng [this message]
2015-08-12 7:50 ` Wang Dongsheng
2015-08-12 8:10 ` Alexandre Belloni
2015-08-12 8:10 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR0301MB161694E7F5018A10A74DD2AC9D7E0@SN1PR0301MB1616.namprd03.prod.outlook.com \
--to=dongsheng.wang@freescale.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.