From: Borislav Petkov <bp@alien8.de> To: "Joshi, Mukul" <Mukul.Joshi@amd.com> Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, "Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>, x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Date: Fri, 14 May 2021 09:05:47 +0200 [thread overview] Message-ID: <YJ4hS/SJYmCC9Rpd@zn.tnic> (raw) In-Reply-To: <DM4PR12MB5263A719B11C6DF8EF9F3A4BEE519@DM4PR12MB5263.namprd12.prod.outlook.com> On Thu, May 13, 2021 at 11:10:34PM +0000, Joshi, Mukul wrote: > That's probably not the best example to look at. Oh, it is the *perfect* example but... > smca_get_long_name() is used in drivers/edac/mce_amd.c and this file > doesn't get compiled when CONFIG_X86_MCE_AMD is not defined. > > And amdgpu driver has no dependency on CONFIG_X86_MCE_AMD. ... maybe this will make you see it the right way: how much of the amdgpu RAS functionality you're adding, is going to even function without CONFIG_X86_MCE_AMD? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: "Joshi, Mukul" <Mukul.Joshi@amd.com> Cc: x86-ml <x86@kernel.org>, "Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>, lkml <linux-kernel@vger.kernel.org>, "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Date: Fri, 14 May 2021 09:05:47 +0200 [thread overview] Message-ID: <YJ4hS/SJYmCC9Rpd@zn.tnic> (raw) In-Reply-To: <DM4PR12MB5263A719B11C6DF8EF9F3A4BEE519@DM4PR12MB5263.namprd12.prod.outlook.com> On Thu, May 13, 2021 at 11:10:34PM +0000, Joshi, Mukul wrote: > That's probably not the best example to look at. Oh, it is the *perfect* example but... > smca_get_long_name() is used in drivers/edac/mce_amd.c and this file > doesn't get compiled when CONFIG_X86_MCE_AMD is not defined. > > And amdgpu driver has no dependency on CONFIG_X86_MCE_AMD. ... maybe this will make you see it the right way: how much of the amdgpu RAS functionality you're adding, is going to even function without CONFIG_X86_MCE_AMD? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-05-14 7:05 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-12 1:30 [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Mukul Joshi 2021-05-12 9:36 ` Borislav Petkov 2021-05-12 9:36 ` Borislav Petkov 2021-05-12 19:00 ` Joshi, Mukul 2021-05-12 19:00 ` Joshi, Mukul 2021-05-12 21:05 ` Borislav Petkov 2021-05-12 21:05 ` Borislav Petkov 2021-05-13 3:20 ` Joshi, Mukul 2021-05-13 3:20 ` Joshi, Mukul 2021-05-13 9:53 ` Borislav Petkov 2021-05-13 9:53 ` Borislav Petkov 2021-05-13 14:17 ` Alex Deucher 2021-05-13 14:17 ` Alex Deucher 2021-05-13 14:30 ` Borislav Petkov 2021-05-13 14:30 ` Borislav Petkov 2021-05-13 14:32 ` Alex Deucher 2021-05-13 14:32 ` Alex Deucher 2021-05-13 14:57 ` Borislav Petkov 2021-05-13 14:57 ` Borislav Petkov 2021-05-13 15:02 ` Alex Deucher 2021-05-13 15:02 ` Alex Deucher 2021-05-13 23:14 ` Joshi, Mukul 2021-05-13 23:14 ` Joshi, Mukul 2021-05-14 7:03 ` Borislav Petkov 2021-05-14 7:03 ` Borislav Petkov 2021-05-27 19:54 ` Joshi, Mukul 2021-05-27 19:54 ` Joshi, Mukul 2021-06-03 21:13 ` Yazen Ghannam 2021-06-03 21:13 ` Yazen Ghannam 2021-07-29 23:59 ` Joshi, Mukul 2021-07-29 23:59 ` Joshi, Mukul 2021-09-13 1:31 ` Joshi, Mukul 2021-05-13 23:10 ` Joshi, Mukul 2021-05-13 23:10 ` Joshi, Mukul 2021-05-14 7:05 ` Borislav Petkov [this message] 2021-05-14 7:05 ` Borislav Petkov 2021-05-14 13:06 ` Joshi, Mukul 2021-05-14 13:06 ` Joshi, Mukul 2021-05-14 14:38 ` Borislav Petkov 2021-05-14 14:38 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJ4hS/SJYmCC9Rpd@zn.tnic \ --to=bp@alien8.de \ --cc=Harish.Kasiviswanathan@amd.com \ --cc=Mukul.Joshi@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.