From: Luis Chamberlain <mcgrof@kernel.org>
To: Liang Wang <wangliang101@huawei.com>
Cc: palmerdabbelt@google.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
wangle6@huawei.com, kepler.chenxin@huawei.com,
nixiaoming@huawei.com, wangkefeng.wang@huawei.com
Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
Date: Fri, 30 Jul 2021 12:36:47 -0700 [thread overview]
Message-ID: <YQRUz9Uw9nfiLcgr@bombadil.infradead.org> (raw)
In-Reply-To: <20210730074315.63232-1-wangliang101@huawei.com>
On Fri, Jul 30, 2021 at 03:43:15PM +0800, Liang Wang wrote:
> The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled),
> use PFN_PHYS() in devmem_is_allowed(),
First off, good catch!
This should not be ARM specific, this should just say:
on 32-bit systems with more than 32 bits of physcial address
Also, towards then end then explain that in practice, yes,
this is probably just ARM which is affected. By explaining
this, it ensures folks are aware of the affected systems.
May be good to refer to commit 947d0496cf3e1 ("generic: make PFN_PHYS
explicitly return phys_addr_t") which added the original PFN_PHYS()
casting to phys_addr_t to resolve the same problem.
> or the physical address may overflow and be truncated.
Indeed. How did you find this issue? Can you describe that in the commit
log? Was it a real world issue or did you do just code inspection? Or
was there a bot which helped you?
> This bug was initially introduced from v2.6.37, and the function was moved
> to lib when v5.11.
>
> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
> Cc: stable@vger.kernel.org # v2.6.37
> Signed-off-by: Liang Wang <wangliang101@huawei.com>
Other than that:
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Liang Wang <wangliang101@huawei.com>
Cc: palmerdabbelt@google.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
wangle6@huawei.com, kepler.chenxin@huawei.com,
nixiaoming@huawei.com, wangkefeng.wang@huawei.com
Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
Date: Fri, 30 Jul 2021 12:36:47 -0700 [thread overview]
Message-ID: <YQRUz9Uw9nfiLcgr@bombadil.infradead.org> (raw)
In-Reply-To: <20210730074315.63232-1-wangliang101@huawei.com>
On Fri, Jul 30, 2021 at 03:43:15PM +0800, Liang Wang wrote:
> The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled),
> use PFN_PHYS() in devmem_is_allowed(),
First off, good catch!
This should not be ARM specific, this should just say:
on 32-bit systems with more than 32 bits of physcial address
Also, towards then end then explain that in practice, yes,
this is probably just ARM which is affected. By explaining
this, it ensures folks are aware of the affected systems.
May be good to refer to commit 947d0496cf3e1 ("generic: make PFN_PHYS
explicitly return phys_addr_t") which added the original PFN_PHYS()
casting to phys_addr_t to resolve the same problem.
> or the physical address may overflow and be truncated.
Indeed. How did you find this issue? Can you describe that in the commit
log? Was it a real world issue or did you do just code inspection? Or
was there a bot which helped you?
> This bug was initially introduced from v2.6.37, and the function was moved
> to lib when v5.11.
>
> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
> Cc: stable@vger.kernel.org # v2.6.37
> Signed-off-by: Liang Wang <wangliang101@huawei.com>
Other than that:
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-30 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 7:43 [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() Liang Wang
2021-07-30 7:43 ` Liang Wang
2021-07-30 19:36 ` Luis Chamberlain [this message]
2021-07-30 19:36 ` Luis Chamberlain
2021-07-31 2:04 ` 答复: " wangliang (C)
2021-07-31 2:04 ` wangliang (C)
[not found] <20210730064915.56249-1-wangliang101@huawei.com>
2021-07-30 7:04 ` Kefeng Wang
2021-07-30 7:04 ` Kefeng Wang
2021-08-04 0:20 ` Palmer Dabbelt
2021-08-04 0:20 ` Palmer Dabbelt
2021-08-04 5:03 ` Kefeng Wang
2021-08-04 5:03 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQRUz9Uw9nfiLcgr@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kepler.chenxin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nixiaoming@huawei.com \
--cc=palmerdabbelt@google.com \
--cc=stable@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=wangle6@huawei.com \
--cc=wangliang101@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.