All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao.yu@linux.dev>
Subject: Re: [PATCH] f2fs: introduce nosmall_discard mount option
Date: Wed, 4 Aug 2021 14:52:04 +0100	[thread overview]
Message-ID: <YQqbhMtVZvCF30r9@infradead.org> (raw)
In-Reply-To: <20210730100530.4401-1-chao@kernel.org>

On Fri, Jul 30, 2021 at 06:05:30PM +0800, Chao Yu wrote:
> This patch introduces a new mountoption "nosmall_discard" to support
> disabling small discard functionality, note that the mountoption can not
> be removed by remount() due to related metadata should always be
> initialized during mount().

Why does this need an option?  It should be enable IFF and only IFF a
SMR drive is detected.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, Chao Yu <chao.yu@linux.dev>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option
Date: Wed, 4 Aug 2021 14:52:04 +0100	[thread overview]
Message-ID: <YQqbhMtVZvCF30r9@infradead.org> (raw)
In-Reply-To: <20210730100530.4401-1-chao@kernel.org>

On Fri, Jul 30, 2021 at 06:05:30PM +0800, Chao Yu wrote:
> This patch introduces a new mountoption "nosmall_discard" to support
> disabling small discard functionality, note that the mountoption can not
> be removed by remount() due to related metadata should always be
> initialized during mount().

Why does this need an option?  It should be enable IFF and only IFF a
SMR drive is detected.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2021-08-04 13:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:05 [PATCH] f2fs: introduce nosmall_discard mount option Chao Yu
2021-07-30 10:05 ` [f2fs-dev] " Chao Yu
2021-07-30 18:28 ` Jaegeuk Kim
2021-07-30 18:28   ` Jaegeuk Kim
2021-07-30 23:41   ` Chao Yu
2021-07-30 23:41     ` [f2fs-dev] " Chao Yu
2021-07-30 23:48     ` Chao Yu
2021-07-30 23:48       ` Chao Yu
2021-07-31  0:42       ` Jaegeuk Kim
2021-07-31  0:42         ` Jaegeuk Kim
2021-07-31  0:48         ` Chao Yu
2021-07-31  0:48           ` Chao Yu
2021-08-04 13:52 ` Christoph Hellwig [this message]
2021-08-04 13:52   ` Christoph Hellwig
2021-08-05  1:22   ` Chao Yu
2021-08-05  1:22     ` [f2fs-dev] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQqbhMtVZvCF30r9@infradead.org \
    --to=hch@infradead.org \
    --cc=chao.yu@linux.dev \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.