From: Daniel Vetter <daniel@ffwll.ch> To: Matthew Brost <matthew.brost@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission Date: Tue, 10 Aug 2021 08:38:42 +0200 [thread overview] Message-ID: <YRIe8jEI+0TLreAI@phenom.ffwll.local> (raw) In-Reply-To: <20210729003400.151864-1-matthew.brost@intel.com> On Wed, Jul 28, 2021 at 05:33:59PM -0700, Matthew Brost wrote: > Should fix below failures with GuC submission for the following tests: > gem_exec_balancer --r noheartbeat > gem_ctx_persistence --r heartbeat-close > > Not going to fix: > gem_ctx_persistence --r heartbeat-many > gem_ctx_persistence --r heartbeat-stop After looking at that big thread and being very confused: Are we fixing an actual use-case here, or is this another case of blindly following igts tests just because they exist? I'm leaning towards that we should stall on this, and first document what exactly is the actual intention behind all this, and then fix up the tests to match (if needed). And only then fix up GuC to match whatever we actually want to do. -Daniel > > As the above tests change the heartbeat value to 0 (off) after the > context is closed and we have no way to detect that with GuC submission > unless we keep a list of closed but running contexts which seems like > overkill for a non-real world use case. We likely should just skip these > tests with GuC submission. > > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > > Matthew Brost (1): > drm/i915: Check if engine has heartbeat when closing a context > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++-- > drivers/gpu/drm/i915/gt/intel_context_types.h | 2 ++ > drivers/gpu/drm/i915/gt/intel_engine.h | 21 ++----------------- > .../drm/i915/gt/intel_execlists_submission.c | 14 +++++++++++++ > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 +++++- > .../gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 -- > 6 files changed, 26 insertions(+), 24 deletions(-) > > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Matthew Brost <matthew.brost@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission Date: Tue, 10 Aug 2021 08:38:42 +0200 [thread overview] Message-ID: <YRIe8jEI+0TLreAI@phenom.ffwll.local> (raw) In-Reply-To: <20210729003400.151864-1-matthew.brost@intel.com> On Wed, Jul 28, 2021 at 05:33:59PM -0700, Matthew Brost wrote: > Should fix below failures with GuC submission for the following tests: > gem_exec_balancer --r noheartbeat > gem_ctx_persistence --r heartbeat-close > > Not going to fix: > gem_ctx_persistence --r heartbeat-many > gem_ctx_persistence --r heartbeat-stop After looking at that big thread and being very confused: Are we fixing an actual use-case here, or is this another case of blindly following igts tests just because they exist? I'm leaning towards that we should stall on this, and first document what exactly is the actual intention behind all this, and then fix up the tests to match (if needed). And only then fix up GuC to match whatever we actually want to do. -Daniel > > As the above tests change the heartbeat value to 0 (off) after the > context is closed and we have no way to detect that with GuC submission > unless we keep a list of closed but running contexts which seems like > overkill for a non-real world use case. We likely should just skip these > tests with GuC submission. > > Signed-off-by: Matthew Brost <matthew.brost@intel.com> > > Matthew Brost (1): > drm/i915: Check if engine has heartbeat when closing a context > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++-- > drivers/gpu/drm/i915/gt/intel_context_types.h | 2 ++ > drivers/gpu/drm/i915/gt/intel_engine.h | 21 ++----------------- > .../drm/i915/gt/intel_execlists_submission.c | 14 +++++++++++++ > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 +++++- > .../gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 -- > 6 files changed, 26 insertions(+), 24 deletions(-) > > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
next prev parent reply other threads:[~2021-08-10 6:38 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 0:33 [Intel-gfx] [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission Matthew Brost 2021-07-29 0:33 ` Matthew Brost 2021-07-29 0:34 ` [Intel-gfx] [PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context Matthew Brost 2021-07-29 0:34 ` Matthew Brost 2021-07-30 0:13 ` [Intel-gfx] " John Harrison 2021-07-30 0:13 ` John Harrison 2021-07-30 9:49 ` Tvrtko Ursulin 2021-07-30 18:13 ` John Harrison 2021-08-02 9:40 ` Tvrtko Ursulin 2021-08-06 18:00 ` John Harrison 2021-08-06 19:46 ` Daniel Vetter 2021-08-09 23:12 ` John Harrison 2021-08-10 6:36 ` Daniel Vetter 2021-08-18 0:28 ` John Harrison 2021-08-18 9:26 ` Daniel Vetter 2021-07-30 18:13 ` Matthew Brost 2021-07-29 2:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Fix gem_ctx_persistence failures with GuC submission Patchwork 2021-07-29 7:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-08-10 6:38 ` Daniel Vetter [this message] 2021-08-10 6:38 ` [PATCH 0/1] " Daniel Vetter 2021-08-18 0:08 ` [Intel-gfx] " John Harrison 2021-08-18 9:49 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YRIe8jEI+0TLreAI@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.brost@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.