From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: dev: zero out array used for i2c reads from userspace
Date: Wed, 11 Aug 2021 09:29:04 +0200 [thread overview]
Message-ID: <YRN8QHingopdwmxO@kroah.com> (raw)
In-Reply-To: <YRLnr24IBwe5HS+j@kunai>
On Tue, Aug 10, 2021 at 10:55:11PM +0200, Wolfram Sang wrote:
> On Thu, Jul 29, 2021 at 04:35:32PM +0200, Greg Kroah-Hartman wrote:
> > If an i2c driver happens to not provide the full amount of data that a
> > user asks for, it is possible that some uninitialized data could be sent
> > to userspace. While all in-kernel drivers look to be safe, just be sure
> > by initializing the buffer to zero before it is passed to the i2c driver
> > so that any future drivers will not have this issue.
> >
> > Also properly copy the amount of data recvieved to the userspace buffer,
> > as pointed out by Dan Carpenter.
> >
> > Reported-by: Eric Dumazet <edumazet@google.com>
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Fixed checkpatch warning "WARNING: Invalid email format for stable:
> 'stable <stable@vger.kernel.org>', prefer 'stable@vger.kernel.org' " and
> applied to for-current, thanks!
That is a crazy warning, never even knew it was there. But as the
stable maintainer, it does not look correct as both are just fine...
Anyway, thanks for taking the patch!
greg k-h
prev parent reply other threads:[~2021-08-11 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:35 [PATCH v2] i2c: dev: zero out array used for i2c reads from userspace Greg Kroah-Hartman
2021-08-10 20:55 ` Wolfram Sang
2021-08-11 7:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRN8QHingopdwmxO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=edumazet@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.