From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
tariqt@nvidia.com, saeedm@nvidia.com, mkarsten@uwaterloo.ca,
gal@nvidia.com, nalramli@fastly.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"open list:MELLANOX MLX4 core VPI driver"
<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] net/mlx4: Track RX allocation failures in a stat
Date: Fri, 26 Apr 2024 16:43:53 -0700 [thread overview]
Message-ID: <Ziw8OSchaOaph1i8@LQ3V64L9R2> (raw)
In-Reply-To: <20240426130017.6e38cd65@kernel.org>
On Fri, Apr 26, 2024 at 01:00:17PM -0700, Jakub Kicinski wrote:
> On Fri, 26 Apr 2024 18:33:53 +0000 Joe Damato wrote:
> > --- a/drivers/net/ethernet/mellanox/mlx4/en_port.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/en_port.c
> > @@ -151,7 +151,7 @@ void mlx4_en_fold_software_stats(struct net_device *dev)
> > {
> > struct mlx4_en_priv *priv = netdev_priv(dev);
> > struct mlx4_en_dev *mdev = priv->mdev;
> > - unsigned long packets, bytes;
> > + unsigned long packets, bytes, dropped;
> > int i;
> >
> > if (!priv->port_up || mlx4_is_master(mdev->dev))
> > @@ -159,14 +159,17 @@ void mlx4_en_fold_software_stats(struct net_device *dev)
> >
> > packets = 0;
> > bytes = 0;
> > + dropped = 0;
> > for (i = 0; i < priv->rx_ring_num; i++) {
> > const struct mlx4_en_rx_ring *ring = priv->rx_ring[i];
> >
> > packets += READ_ONCE(ring->packets);
> > bytes += READ_ONCE(ring->bytes);
> > + dropped += READ_ONCE(ring->dropped);
> > }
> > dev->stats.rx_packets = packets;
> > dev->stats.rx_bytes = bytes;
> > + dev->stats.rx_missed_errors = dropped;
>
> I'd drop this chunk, there's a slight but meaningful difference in
> definition of rx_missed vs alloc-fail:
>
> * @rx_missed_errors: Count of packets missed by the host.
> * Folded into the "drop" counter in `/proc/net/dev`.
> *
> * Counts number of packets dropped by the device due to lack
> * of buffer space. This usually indicates that the host interface
> * is slower than the network interface, or host is not keeping up
> * with the receive packet rate.
> ---
> name: rx-alloc-fail
> doc: |
> Number of times skb or buffer allocation failed on the Rx datapath.
> Allocation failure may, or may not result in a packet drop, depending
> on driver implementation and whether system recovers quickly.
>
> tl;dr "packets dropped" vs "may, or may not result in a packet drop"
>
> In case of mlx4 looks like the buffer refill is "async", the driver
> tries to refill the buffers to max, but if it fails the next NAPI poll
> will try again. Allocation failures are not directly tied to packet
> drops. In case of bnxt if "replacement" buffer can't be allocated -
> packet is dropped and old buffer gets returned to the ring (although
> if I'm 100% honest bnxt may be off by a couple, too, as the OOM stat
> gets incremented on ifup pre-fill failures).
Yes, I see that now. I'll drop this patch entirely from v3 and just leave
the other two and remove alloc_fail from the queue stats patch.
Thanks for the careful review.
next prev parent reply other threads:[~2024-04-26 23:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 18:33 [PATCH net-next v2 0/3] mlx4: Add support for netdev-genl API Joe Damato
2024-04-26 18:33 ` [PATCH net-next v2 1/3] net/mlx4: Track RX allocation failures in a stat Joe Damato
2024-04-26 20:00 ` Jakub Kicinski
2024-04-26 23:43 ` Joe Damato [this message]
2024-04-26 23:52 ` Jakub Kicinski
2024-04-27 0:28 ` Joe Damato
2024-04-27 0:34 ` Jakub Kicinski
2024-04-26 18:33 ` [PATCH net-next v2 2/3] net/mlx4: link NAPI instances to queues and IRQs Joe Damato
2024-04-26 20:01 ` Jakub Kicinski
2024-04-26 18:33 ` [PATCH net-next v2 3/3] net/mlx4: support per-queue statistics via netlink Joe Damato
2024-04-26 20:01 ` Jakub Kicinski
2024-04-27 0:05 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziw8OSchaOaph1i8@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=nalramli@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.