From: Philipp Zabel <p.zabel@pengutronix.de>
To: Anand Moon <linux.amoon@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Emiliano Ingrassia <ingrassia@epigenesys.com>
Subject: Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller
Date: Fri, 30 Jul 2021 11:45:50 +0200 [thread overview]
Message-ID: <a360877260a877819ad8eef7f63c370e0c16c640.camel@pengutronix.de> (raw)
In-Reply-To: <20210729201100.3994-3-linux.amoon@gmail.com>
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote:
> Used new reset id for reset controller as it conflict
> with the core reset id.
>
> Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description")
>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 2 +-
> arch/arm/boot/dts/meson8m2.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index c02b03cbcdf4..cb3a579d09ef 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -511,7 +511,7 @@ ðmac {
> tx-fifo-depth = <2048>;
>
> resets = <&reset RESET_ETHERNET>;
> - reset-names = "stmmaceth";
> + reset-names = "ethreset";
This looks like an incompatible change. Is the "stmmaceth" reset not
used? It is documented as "MAC reset signal" in [1]. So a PHY reset
should be separate from this.
[1] Documentation/devicetree/bindings/net/snps,dwmac.yaml
regards
Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Anand Moon <linux.amoon@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Emiliano Ingrassia <ingrassia@epigenesys.com>
Subject: Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller
Date: Fri, 30 Jul 2021 11:45:50 +0200 [thread overview]
Message-ID: <a360877260a877819ad8eef7f63c370e0c16c640.camel@pengutronix.de> (raw)
In-Reply-To: <20210729201100.3994-3-linux.amoon@gmail.com>
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote:
> Used new reset id for reset controller as it conflict
> with the core reset id.
>
> Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description")
>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 2 +-
> arch/arm/boot/dts/meson8m2.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index c02b03cbcdf4..cb3a579d09ef 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -511,7 +511,7 @@ ðmac {
> tx-fifo-depth = <2048>;
>
> resets = <&reset RESET_ETHERNET>;
> - reset-names = "stmmaceth";
> + reset-names = "ethreset";
This looks like an incompatible change. Is the "stmmaceth" reset not
used? It is documented as "MAC reset signal" in [1]. So a PHY reset
should be separate from this.
[1] Documentation/devicetree/bindings/net/snps,dwmac.yaml
regards
Philipp
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Anand Moon <linux.amoon@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Emiliano Ingrassia <ingrassia@epigenesys.com>
Subject: Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller
Date: Fri, 30 Jul 2021 11:45:50 +0200 [thread overview]
Message-ID: <a360877260a877819ad8eef7f63c370e0c16c640.camel@pengutronix.de> (raw)
In-Reply-To: <20210729201100.3994-3-linux.amoon@gmail.com>
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote:
> Used new reset id for reset controller as it conflict
> with the core reset id.
>
> Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description")
>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 2 +-
> arch/arm/boot/dts/meson8m2.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index c02b03cbcdf4..cb3a579d09ef 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -511,7 +511,7 @@ ðmac {
> tx-fifo-depth = <2048>;
>
> resets = <&reset RESET_ETHERNET>;
> - reset-names = "stmmaceth";
> + reset-names = "ethreset";
This looks like an incompatible change. Is the "stmmaceth" reset not
used? It is documented as "MAC reset signal" in [1]. So a PHY reset
should be separate from this.
[1] Documentation/devicetree/bindings/net/snps,dwmac.yaml
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-30 9:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 20:10 [PATCHv1 0/3] Add Reset controller to Ethernet PHY Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:10 ` [PATCHv1 1/3] arm64: dts: amlogic: add missing ethernet reset ID Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-30 9:42 ` Philipp Zabel
2021-07-30 9:42 ` Philipp Zabel
2021-07-30 9:42 ` Philipp Zabel
2021-07-29 20:10 ` [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-30 9:45 ` Philipp Zabel [this message]
2021-07-30 9:45 ` Philipp Zabel
2021-07-30 9:45 ` Philipp Zabel
2021-07-30 18:48 ` Anand Moon
2021-07-30 18:48 ` Anand Moon
2021-07-30 18:48 ` Anand Moon
2021-07-29 20:10 ` [PATCHv1 3/3] net: stmmac: dwmac-meson8b: Add reset controller for ethernet phy Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:10 ` Anand Moon
2021-07-29 20:21 ` Andrew Lunn
2021-07-29 20:21 ` Andrew Lunn
2021-07-29 20:21 ` Andrew Lunn
2021-08-03 20:45 ` Martin Blumenstingl
2021-08-03 20:45 ` Martin Blumenstingl
2021-08-03 20:45 ` Martin Blumenstingl
2021-08-03 20:41 ` [PATCHv1 0/3] Add Reset controller to Ethernet PHY Martin Blumenstingl
2021-08-03 20:41 ` Martin Blumenstingl
2021-08-03 20:41 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a360877260a877819ad8eef7f63c370e0c16c640.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ingrassia@epigenesys.com \
--cc=jbrunet@baylibre.com \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.