From: David Hildenbrand <david@redhat.com>
To: Guillaume Morin <guillaume@morinfr.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
oleg@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] uprobe: support for private hugetlb mappings
Date: Mon, 22 Apr 2024 11:39:33 +0200 [thread overview]
Message-ID: <b70a3d3a-ea8b-4b20-964b-b019c146945a@redhat.com> (raw)
In-Reply-To: <ZiK50qob9yl5e0Xz@bender.morinfr.org>
On 19.04.24 20:37, Guillaume Morin wrote:
> libhugetlbfs, the Intel iodlr code both allow to remap .text onto a
> hugetlb private mapping. It's also pretty easy to do it manually.
> One drawback of using this functionality is the lack of support for
> uprobes (NOTE uprobe ignores shareable vmas)
>
> This patch adds support for private hugetlb mappings. It does require exposing
> some hugetlbfs innards and relies on copy_user_large_folio which is only
> available when CONFIG_HUGETLBFS is used so I had to use an ugly #ifdef
>
> If there is some interest in applying this patch in some form or
> another, I am open to any refactoring suggestions (esp getting rid the
> #ifdef in uprobes.c) . I tried to limit the
> amount of branching.
All that hugetlb special casing .... oh my. What's the benefit why we
should be interested in making that code less clean -- to phrase it in a
nice way ;) ?
Yes, libhugetlbfs exists. But why do we have to support uprobes with it?
Nobody cared until now, why care now?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-22 9:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 18:37 [RFC][PATCH] uprobe: support for private hugetlb mappings Guillaume Morin
2024-04-22 9:39 ` David Hildenbrand [this message]
2024-04-22 18:11 ` Guillaume Morin
2024-04-22 18:59 ` David Hildenbrand
2024-04-22 20:53 ` Guillaume Morin
2024-04-24 20:09 ` David Hildenbrand
2024-04-24 20:44 ` Guillaume Morin
2024-04-24 21:00 ` David Hildenbrand
2024-04-25 15:19 ` Guillaume Morin
2024-04-25 15:42 ` David Hildenbrand
2024-04-25 19:56 ` David Hildenbrand
2024-04-26 0:09 ` Guillaume Morin
2024-04-26 7:19 ` David Hildenbrand
2024-04-26 19:55 ` Guillaume Morin
2024-04-30 15:22 ` Guillaume Morin
2024-04-30 18:21 ` David Hildenbrand
2024-04-30 18:58 ` Guillaume Morin
2024-04-30 19:25 ` David Hildenbrand
2024-05-02 3:59 ` Guillaume Morin
2024-05-16 17:44 ` Guillaume Morin
2024-05-16 19:52 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70a3d3a-ea8b-4b20-964b-b019c146945a@redhat.com \
--to=david@redhat.com \
--cc=guillaume@morinfr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.