Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock

From: Marek Vasut <marex@denx.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Paul Elder <paul.elder@ideasonboard.com>,
	imx@lists.linux.dev,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock
Date: Wed, 17 Apr 2024 13:06:31 +0200	[thread overview]
Message-ID: <b9147e01-4759-44c6-9588-6151ae2ff113@denx.de> (raw)
In-Reply-To: <6872097d-b1c8-40c0-8392-28c351dad3dc@pengutronix.de>

On 4/17/24 12:17 PM, Ahmad Fatoum wrote:
> On 17.04.24 12:14, Ahmad Fatoum wrote:
>> On 16.04.24 16:19, Marek Vasut wrote:
>>> Configure both CSI2 assigned-clock-rates the same way.
>>> There does not seem to be any reason for keeping the
>>> two CSI2 pixel clock set to different frequencies.
>>>
>>> This also reduces first CSI2 clock from overdrive mode
>>> frequency which is 500 MHz down below the regular mode
>>> frequency of 400 MHz.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>
>> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> I see now that the node has a clock-frequency = <500000000>; still.
> This should be lowered too, shouldn't it?

Oh, right, good catch.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel