From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>
Subject: Re: [PATCH v2 2/2] f2fs: atgc: export entries for better tunability via sysfs
Date: Tue, 25 May 2021 19:32:02 +0800 [thread overview]
Message-ID: <c0d287ca-ad38-f261-3e9d-02d3ceabca89@huawei.com> (raw)
In-Reply-To: <20210512020719.43685-1-yuchao0@huawei.com>
Jaegeuk, could you please queue this in dev-test?
On 2021/5/12 10:07, Chao Yu wrote:
> This patch export below sysfs entries for better ATGC tunability.
>
> /sys/fs/f2fs/<disk>/atgc_candidate_ratio
> /sys/fs/f2fs/<disk>/atgc_candidate_count
> /sys/fs/f2fs/<disk>/atgc_age_weight
> /sys/fs/f2fs/<disk>/atgc_age_threshold
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> v2:
> - limit value range of candidate_ratio and candidate_ratio in __sbi_store()
> Documentation/ABI/testing/sysfs-fs-f2fs | 28 +++++++++++++++++++++++++
> fs/f2fs/sysfs.c | 27 ++++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 4849b8e84e42..5088281e312e 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -438,3 +438,31 @@ Description: Show the count of inode newly enabled for compression since mount.
> Note that when the compression is disabled for the files, this count
> doesn't decrease. If you write "0" here, you can initialize
> compr_new_inode to "0".
> +
> +What: /sys/fs/f2fs/<disk>/atgc_candidate_ratio
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls candidate ratio in order to limit total
> + number of potential victim in all candidates, the value should be in
> + range of [0, 100], by default it was initialized as 20(%).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_candidate_count
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls candidate count in order to limit total
> + number of potential victim in all candidates, by default it was
> + initialized as 10 (sections).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_age_weight
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls age weight to balance weight proportion
> + in between aging and valid blocks, the value should be in range of
> + [0, 100], by default it was initialized as 60(%).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_age_threshold
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls age threshold to bypass GCing young
> + candidates whose age is not beyond the threshold, by default it was
> + initialized as 604800 seconds (equals to 7 days).
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 39b522ec73e7..dc71bc968c72 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -37,6 +37,7 @@ enum {
> #endif
> RESERVED_BLOCKS, /* struct f2fs_sb_info */
> CPRC_INFO, /* struct ckpt_req_control */
> + ATGC_INFO, /* struct atgc_management */
> };
>
> struct f2fs_attr {
> @@ -75,6 +76,8 @@ static unsigned char *__struct_ptr(struct f2fs_sb_info *sbi, int struct_type)
> #endif
> else if (struct_type == CPRC_INFO)
> return (unsigned char *)&sbi->cprc_info;
> + else if (struct_type == ATGC_INFO)
> + return (unsigned char *)&sbi->am;
> return NULL;
> }
>
> @@ -495,6 +498,20 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
> }
> #endif
>
> + if (!strcmp(a->attr.name, "atgc_candidate_ratio")) {
> + if (t > 100)
> + return -EINVAL;
> + sbi->am.candidate_ratio = t;
> + return count;
> + }
> +
> + if (!strcmp(a->attr.name, "atgc_age_weight")) {
> + if (t > 100)
> + return -EINVAL;
> + sbi->am.age_weight = t;
> + return count;
> + }
> +
> *ui = (unsigned int)t;
>
> return count;
> @@ -710,6 +727,11 @@ F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_written_block, compr_written_block);
> F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_saved_block, compr_saved_block);
> F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_new_inode, compr_new_inode);
> #endif
> +/* For ATGC */
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_ratio, candidate_ratio);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_count, max_candidate_count);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_weight, age_weight);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_threshold, age_threshold);
>
> #define ATTR_LIST(name) (&f2fs_attr_##name.attr)
> static struct attribute *f2fs_attrs[] = {
> @@ -778,6 +800,11 @@ static struct attribute *f2fs_attrs[] = {
> ATTR_LIST(compr_saved_block),
> ATTR_LIST(compr_new_inode),
> #endif
> + /* For ATGC */
> + ATTR_LIST(atgc_candidate_ratio),
> + ATTR_LIST(atgc_candidate_count),
> + ATTR_LIST(atgc_age_weight),
> + ATTR_LIST(atgc_age_threshold),
> NULL,
> };
> ATTRIBUTE_GROUPS(f2fs);
>
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: atgc: export entries for better tunability via sysfs
Date: Tue, 25 May 2021 19:32:02 +0800 [thread overview]
Message-ID: <c0d287ca-ad38-f261-3e9d-02d3ceabca89@huawei.com> (raw)
In-Reply-To: <20210512020719.43685-1-yuchao0@huawei.com>
Jaegeuk, could you please queue this in dev-test?
On 2021/5/12 10:07, Chao Yu wrote:
> This patch export below sysfs entries for better ATGC tunability.
>
> /sys/fs/f2fs/<disk>/atgc_candidate_ratio
> /sys/fs/f2fs/<disk>/atgc_candidate_count
> /sys/fs/f2fs/<disk>/atgc_age_weight
> /sys/fs/f2fs/<disk>/atgc_age_threshold
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> v2:
> - limit value range of candidate_ratio and candidate_ratio in __sbi_store()
> Documentation/ABI/testing/sysfs-fs-f2fs | 28 +++++++++++++++++++++++++
> fs/f2fs/sysfs.c | 27 ++++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 4849b8e84e42..5088281e312e 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -438,3 +438,31 @@ Description: Show the count of inode newly enabled for compression since mount.
> Note that when the compression is disabled for the files, this count
> doesn't decrease. If you write "0" here, you can initialize
> compr_new_inode to "0".
> +
> +What: /sys/fs/f2fs/<disk>/atgc_candidate_ratio
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls candidate ratio in order to limit total
> + number of potential victim in all candidates, the value should be in
> + range of [0, 100], by default it was initialized as 20(%).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_candidate_count
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls candidate count in order to limit total
> + number of potential victim in all candidates, by default it was
> + initialized as 10 (sections).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_age_weight
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls age weight to balance weight proportion
> + in between aging and valid blocks, the value should be in range of
> + [0, 100], by default it was initialized as 60(%).
> +
> +What: /sys/fs/f2fs/<disk>/atgc_age_threshold
> +Date: May 2021
> +Contact: "Chao Yu" <yuchao0@huawei.com>
> +Description: When ATGC is on, it controls age threshold to bypass GCing young
> + candidates whose age is not beyond the threshold, by default it was
> + initialized as 604800 seconds (equals to 7 days).
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 39b522ec73e7..dc71bc968c72 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -37,6 +37,7 @@ enum {
> #endif
> RESERVED_BLOCKS, /* struct f2fs_sb_info */
> CPRC_INFO, /* struct ckpt_req_control */
> + ATGC_INFO, /* struct atgc_management */
> };
>
> struct f2fs_attr {
> @@ -75,6 +76,8 @@ static unsigned char *__struct_ptr(struct f2fs_sb_info *sbi, int struct_type)
> #endif
> else if (struct_type == CPRC_INFO)
> return (unsigned char *)&sbi->cprc_info;
> + else if (struct_type == ATGC_INFO)
> + return (unsigned char *)&sbi->am;
> return NULL;
> }
>
> @@ -495,6 +498,20 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
> }
> #endif
>
> + if (!strcmp(a->attr.name, "atgc_candidate_ratio")) {
> + if (t > 100)
> + return -EINVAL;
> + sbi->am.candidate_ratio = t;
> + return count;
> + }
> +
> + if (!strcmp(a->attr.name, "atgc_age_weight")) {
> + if (t > 100)
> + return -EINVAL;
> + sbi->am.age_weight = t;
> + return count;
> + }
> +
> *ui = (unsigned int)t;
>
> return count;
> @@ -710,6 +727,11 @@ F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_written_block, compr_written_block);
> F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_saved_block, compr_saved_block);
> F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_new_inode, compr_new_inode);
> #endif
> +/* For ATGC */
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_ratio, candidate_ratio);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_count, max_candidate_count);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_weight, age_weight);
> +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_threshold, age_threshold);
>
> #define ATTR_LIST(name) (&f2fs_attr_##name.attr)
> static struct attribute *f2fs_attrs[] = {
> @@ -778,6 +800,11 @@ static struct attribute *f2fs_attrs[] = {
> ATTR_LIST(compr_saved_block),
> ATTR_LIST(compr_new_inode),
> #endif
> + /* For ATGC */
> + ATTR_LIST(atgc_candidate_ratio),
> + ATTR_LIST(atgc_candidate_count),
> + ATTR_LIST(atgc_age_weight),
> + ATTR_LIST(atgc_age_threshold),
> NULL,
> };
> ATTRIBUTE_GROUPS(f2fs);
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-05-25 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 2:07 [PATCH v2 2/2] f2fs: atgc: export entries for better tunability via sysfs Chao Yu
2021-05-12 2:07 ` [f2fs-dev] " Chao Yu
2021-05-25 11:32 ` Chao Yu [this message]
2021-05-25 11:32 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d287ca-ad38-f261-3e9d-02d3ceabca89@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.