From: Dipen Patel <dipenp@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
robh+dt@kernel.org, timestamp@lists.linux.dev
Subject: Re: [PATCH V2 4/6] dt-bindings: timestamp: Add Tegra234 support
Date: Thu, 9 Mar 2023 10:49:57 -0800 [thread overview]
Message-ID: <c1a78a59-c8ae-81e5-b641-a7cb75062ab3@nvidia.com> (raw)
In-Reply-To: <ab9f7730-d399-0786-67e5-aad57716809e@kernel.org>
On 3/8/23 10:16 PM, Krzysztof Kozlowski wrote:
> On 08/03/2023 21:09, Dipen Patel wrote:
>> On 3/8/23 11:05 AM, Krzysztof Kozlowski wrote:
>>> On 08/03/2023 19:45, Dipen Patel wrote:
>>>> On 2/16/23 6:17 AM, Krzysztof Kozlowski wrote:
>>>>> On 14/02/2023 12:55, Dipen Patel wrote:
>>>>>> Added timestamp provider support for the Tegra234 in devicetree
>>>>>> bindings.
>>>>>
>>>>> 1. Your commit does much more. You need to explain it why you drop some
>>>>> property.
>>>> ACK, will address it next patch
>>>>>
>>>>> 2. Bindings go before its usage (in the patchset).
>>>> Ack...
>>>>>
>>>>> 3. Please use scripts/get_maintainers.pl to get a list of necessary
>>>>> people and lists to CC. It might happen, that command when run on an
>>>>> older kernel, gives you outdated entries. Therefore please be sure you
>>>>> base your patches on recent Linux kernel.
>>>> It is based on recent linux at the time patch series was sent...
>>>
>>> That's good but then why you do not use scripts/get_maintainers.pl? The
>>> hint about recent kernel was just a hint... Just do not invent addresses
>>> by yourself and use the tool to get them right.
>>>
>> I will take a note for the next patch series to add any missing people. The current
>> list of people/group is what historically helped review this new timestamp/hte subsystem.
>>
>>> (...)
>>>
>>>>>> + properties:
>>>>>> + compatible:
>>>>>> + contains:
>>>>>> + enum:
>>>>>> + - nvidia,tegra194-gte-aon
>>>>>
>>>>> This is an ABI break. Does your driver handle it?
>>>> yes, handling patch is part of this patch series.
>>>
>>> Can you point me to the code which does it? I see "return -ENODEV;", so
>>> I think you do not handle ABI break. I could miss something but since
>>> you disagree with me, please at least bring some arguments...
>> Refer to patch https://patchwork.kernel.org/project/timestamp/patch/20230214115553.10416-3-dipenp@nvidia.com/
>> which has compatible properties added and also code changes to reflect addition/deletion of some
>> properties.
>
> I referred to the code which breaks the ABI.
>
>>
>> I am not sure I have understood about ABI break comment. How else one should handle if
>> there is no related gpio controller property found?
>
> In a way it does not break existing users? There are many ways to handle
> it, but I don't know your code to point you.
It is new subsystem and has only one driver which uses it so far. This was a decision taken
after review comments (By Thierry, also in the mailing list) to add this property (nvidia,gpio-controller)
and necessary changes have been made to existing user. From now on, it has to follow this change.
>
>> I am assuming you are referring to the
>> below code from the patch 2 (link above) when you said "return -ENODEV".
>
>
> Your bindings patch points to ABI break without any
> explanation/justification. Then your code #2 patch actually breaks it,
> also without any justification.
I am going to add explanation/justification in the commit message in the next patch series. But to give
you context, discussion happened here https://patchwork.ozlabs.org/project/linux-gpio/patch/20221103174523.29592-3-dipenp@nvidia.com/
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-09 18:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 11:55 [PATCH V2 0/6] Add Tegra234 HTE support Dipen Patel
2023-02-14 11:55 ` [PATCH V2 1/6] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-02-14 11:55 ` [PATCH V2 2/6] hte: Add Tegra234 provider Dipen Patel
2023-02-14 11:55 ` [PATCH V2 3/6] gpio: tegra186: Add Tegra234 hte support Dipen Patel
2023-02-14 11:55 ` [PATCH V2 4/6] dt-bindings: timestamp: Add Tegra234 support Dipen Patel
2023-02-16 14:17 ` Krzysztof Kozlowski
2023-03-08 18:45 ` Dipen Patel
2023-03-08 19:05 ` Krzysztof Kozlowski
2023-03-08 20:09 ` Dipen Patel
2023-03-09 6:16 ` Krzysztof Kozlowski
2023-03-09 18:49 ` Dipen Patel [this message]
2023-03-10 8:45 ` Krzysztof Kozlowski
2023-03-10 17:19 ` Dipen Patel
2023-03-10 18:08 ` Krzysztof Kozlowski
2023-02-14 11:55 ` [PATCH V2 5/6] hte: Re-phrase tegra API document Dipen Patel
2023-02-14 11:55 ` [PATCH V2 6/6] arm64: tegra: Add GTE nodes Dipen Patel
2023-02-16 14:18 ` Krzysztof Kozlowski
2023-03-08 20:13 ` Dipen Patel
2023-03-09 6:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1a78a59-c8ae-81e5-b641-a7cb75062ab3@nvidia.com \
--to=dipenp@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.