From: Dipen Patel <dipenp@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
robh+dt@kernel.org, timestamp@lists.linux.dev
Subject: Re: [PATCH V2 6/6] arm64: tegra: Add GTE nodes
Date: Wed, 8 Mar 2023 12:13:04 -0800 [thread overview]
Message-ID: <ef58cd61-f90d-f242-9923-e9544d1aa963@nvidia.com> (raw)
In-Reply-To: <16e3ddb4-219e-70a8-8644-c62973f84d31@kernel.org>
On 2/16/23 6:18 AM, Krzysztof Kozlowski wrote:
> On 14/02/2023 12:55, Dipen Patel wrote:
>> Add GTE nodes for the tegra234. Also modify AON GTE nodes for the
>> tegra194 to remove nvidia,slice property and add nvidia,gpio-controller
>> propertyto specify AON GPIO controller node so that GTE driver can
>> do namespace conversion between GPIO lines provided by the gpiolib
>> framework and hardware timestamping engine subsystem.
>>
>> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 3 +--
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +++++++++++++++++++
>> 2 files changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> index 4afcbd60e144..4c92850b1ec4 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
>> @@ -1363,7 +1363,6 @@
>> reg = <0x3aa0000 0x10000>;
>> interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>> nvidia,int-threshold = <1>;
>> - nvidia,slices = <11>;
>> #timestamp-cells = <1>;
>> status = "okay";
>> };
>> @@ -1586,7 +1585,7 @@
>> reg = <0xc1e0000 0x10000>;
>> interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
>> nvidia,int-threshold = <1>;
>> - nvidia,slices = <3>;
>> + nvidia,gpio-controller = <&gpio_aon>;
>> #timestamp-cells = <1>;
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index eaf05ee9acd1..4a87490c5fd4 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -1086,6 +1086,15 @@
>> clock-names = "fuse";
>> };
>>
>> + hte_lic: hardware-timestamp@3aa0000 {
>> + compatible = "nvidia,tegra234-gte-lic";
>> + reg = <0x3aa0000 0x10000>;
>> + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>> + nvidia,int-threshold = <1>;
>> + #timestamp-cells = <1>;
>> + status = "okay";
>
> Why do you need status? It's okay by default.
what's harm of having to explicitly mentioned? I can see status = okay in this dtsi file
for other nodes as well and was just following that.
>
>> + };
>> +
>> hsp_top0: hsp@3c00000 {
>> compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp";
>> reg = <0x03c00000 0xa0000>;
>> @@ -1603,6 +1612,16 @@
>> #mbox-cells = <2>;
>> };
>>
>> + hte_aon: hardware-timestamp@c1e0000 {
>> + compatible = "nvidia,tegra234-gte-aon";
>> + reg = <0xc1e0000 0x10000>;
>> + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
>> + nvidia,int-threshold = <1>;
>> + nvidia,gpio-controller = <&gpio_aon>;
>> + #timestamp-cells = <1>;
>> + status = "okay";
>
>
> Also here
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-08 20:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 11:55 [PATCH V2 0/6] Add Tegra234 HTE support Dipen Patel
2023-02-14 11:55 ` [PATCH V2 1/6] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-02-14 11:55 ` [PATCH V2 2/6] hte: Add Tegra234 provider Dipen Patel
2023-02-14 11:55 ` [PATCH V2 3/6] gpio: tegra186: Add Tegra234 hte support Dipen Patel
2023-02-14 11:55 ` [PATCH V2 4/6] dt-bindings: timestamp: Add Tegra234 support Dipen Patel
2023-02-16 14:17 ` Krzysztof Kozlowski
2023-03-08 18:45 ` Dipen Patel
2023-03-08 19:05 ` Krzysztof Kozlowski
2023-03-08 20:09 ` Dipen Patel
2023-03-09 6:16 ` Krzysztof Kozlowski
2023-03-09 18:49 ` Dipen Patel
2023-03-10 8:45 ` Krzysztof Kozlowski
2023-03-10 17:19 ` Dipen Patel
2023-03-10 18:08 ` Krzysztof Kozlowski
2023-02-14 11:55 ` [PATCH V2 5/6] hte: Re-phrase tegra API document Dipen Patel
2023-02-14 11:55 ` [PATCH V2 6/6] arm64: tegra: Add GTE nodes Dipen Patel
2023-02-16 14:18 ` Krzysztof Kozlowski
2023-03-08 20:13 ` Dipen Patel [this message]
2023-03-09 6:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef58cd61-f90d-f242-9923-e9544d1aa963@nvidia.com \
--to=dipenp@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.