From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
rocco.yue@gmail.com, chao.song@mediatek.com,
zhuoliang.zhang@mediatek.com
Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message
Date: Thu, 29 Jul 2021 08:41:17 -0600 [thread overview]
Message-ID: <c4099beb-1c22-ac71-ae05-e3f9a8ab69e2@gmail.com> (raw)
In-Reply-To: <20210729090206.11138-1-rocco.yue@mediatek.com>
On 7/29/21 3:02 AM, Rocco Yue wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 4882e81514b6..ea6c872c5f2c 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -347,7 +347,7 @@ enum {
> */
> IFLA_PARENT_DEV_NAME,
> IFLA_PARENT_DEV_BUS_NAME,
> -
> + IFLA_RA_MTU,
> __IFLA_MAX
> };
>
> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 70603775fe91..3dbcf212b766 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -190,6 +190,7 @@ enum {
> DEVCONF_NDISC_TCLASS,
> DEVCONF_RPL_SEG_ENABLED,
> DEVCONF_RA_DEFRTR_METRIC,
> + DEVCONF_RA_MTU,
> DEVCONF_MAX
> };
>
you do not need both IFLA and DEVCONF. Drop the DEVCONF completely. IFLA
attribute can be used for both inspection and notification on change.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
rocco.yue@gmail.com, chao.song@mediatek.com,
zhuoliang.zhang@mediatek.com
Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message
Date: Thu, 29 Jul 2021 08:41:17 -0600 [thread overview]
Message-ID: <c4099beb-1c22-ac71-ae05-e3f9a8ab69e2@gmail.com> (raw)
In-Reply-To: <20210729090206.11138-1-rocco.yue@mediatek.com>
On 7/29/21 3:02 AM, Rocco Yue wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 4882e81514b6..ea6c872c5f2c 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -347,7 +347,7 @@ enum {
> */
> IFLA_PARENT_DEV_NAME,
> IFLA_PARENT_DEV_BUS_NAME,
> -
> + IFLA_RA_MTU,
> __IFLA_MAX
> };
>
> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 70603775fe91..3dbcf212b766 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -190,6 +190,7 @@ enum {
> DEVCONF_NDISC_TCLASS,
> DEVCONF_RPL_SEG_ENABLED,
> DEVCONF_RA_DEFRTR_METRIC,
> + DEVCONF_RA_MTU,
> DEVCONF_MAX
> };
>
you do not need both IFLA and DEVCONF. Drop the DEVCONF completely. IFLA
attribute can be used for both inspection and notification on change.
WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
rocco.yue@gmail.com, chao.song@mediatek.com,
zhuoliang.zhang@mediatek.com
Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message
Date: Thu, 29 Jul 2021 08:41:17 -0600 [thread overview]
Message-ID: <c4099beb-1c22-ac71-ae05-e3f9a8ab69e2@gmail.com> (raw)
In-Reply-To: <20210729090206.11138-1-rocco.yue@mediatek.com>
On 7/29/21 3:02 AM, Rocco Yue wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 4882e81514b6..ea6c872c5f2c 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -347,7 +347,7 @@ enum {
> */
> IFLA_PARENT_DEV_NAME,
> IFLA_PARENT_DEV_BUS_NAME,
> -
> + IFLA_RA_MTU,
> __IFLA_MAX
> };
>
> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 70603775fe91..3dbcf212b766 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -190,6 +190,7 @@ enum {
> DEVCONF_NDISC_TCLASS,
> DEVCONF_RPL_SEG_ENABLED,
> DEVCONF_RA_DEFRTR_METRIC,
> + DEVCONF_RA_MTU,
> DEVCONF_MAX
> };
>
you do not need both IFLA and DEVCONF. Drop the DEVCONF completely. IFLA
attribute can be used for both inspection and notification on change.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-29 14:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 9:02 [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message Rocco Yue
2021-07-29 9:02 ` Rocco Yue
2021-07-29 9:02 ` Rocco Yue
2021-07-29 14:41 ` David Ahern [this message]
2021-07-29 14:41 ` David Ahern
2021-07-29 14:41 ` David Ahern
2021-07-29 15:42 ` Rocco Yue
2021-07-29 15:42 ` Rocco Yue
2021-07-29 15:42 ` Rocco Yue
2021-07-29 17:28 ` David Ahern
2021-07-29 17:28 ` David Ahern
2021-07-29 17:28 ` David Ahern
2021-07-30 17:39 ` Rocco Yue
2021-07-30 17:39 ` Rocco Yue
2021-07-30 17:39 ` Rocco Yue
2021-07-29 14:43 ` David Ahern
2021-07-29 14:43 ` David Ahern
2021-07-29 14:43 ` David Ahern
2021-07-29 16:45 ` kernel test robot
2021-07-29 16:45 ` kernel test robot
2021-07-29 16:45 ` kernel test robot
2021-07-29 16:45 ` kernel test robot
2021-07-29 18:32 ` kernel test robot
2021-07-29 18:32 ` kernel test robot
2021-07-29 18:32 ` kernel test robot
2021-07-29 18:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4099beb-1c22-ac71-ae05-e3f9a8ab69e2@gmail.com \
--to=dsahern@gmail.com \
--cc=chao.song@mediatek.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rocco.yue@gmail.com \
--cc=rocco.yue@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhuoliang.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.