From: Sibi Sankar <sibis@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, will@kernel.org,
saiprakash.ranjan@codeaurora.org, ohad@wizery.com,
agross@kernel.org, mathieu.poirier@linaro.org,
robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, evgreen@chromium.org,
dianders@chromium.org, swboyd@chromium.org
Subject: Re: [PATCH 9/9] arm64: dts: qcom: sc7280: Update Q6V5 MSS node
Date: Thu, 01 Jul 2021 01:38:16 +0530 [thread overview]
Message-ID: <c561f99cb281c28581d10e5805190df8@codeaurora.org> (raw)
In-Reply-To: <YNodaqE9n9+sQUFq@google.com>
On 2021-06-29 00:35, Matthias Kaehlcke wrote:
> On Fri, Jun 25, 2021 at 01:17:38AM +0530, Sibi Sankar wrote:
>> Update MSS node to support MSA based modem boot on SC7280 SoCs.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 7 +++++++
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++++++---
>> 2 files changed, 23 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> index 191e8a92d153..d66e3ca42ad5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> @@ -343,3 +343,10 @@
>> bias-pull-up;
>> };
>> };
>> +
>> +&remoteproc_mpss {
>> + status = "okay";
>> + compatible = "qcom,sc7280-mss-pil";
>> + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
>> + memory-region = <&mba_mem &mpss_mem>;
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 56ea172f641f..6d3687744440 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -586,7 +586,8 @@
>>
>> remoteproc_mpss: remoteproc@4080000 {
>> compatible = "qcom,sc7280-mpss-pas";
>> - reg = <0 0x04080000 0 0x10000>;
>> + reg = <0 0x04080000 0 0x10000>, <0 0x04180000 0 0x48>;
>> + reg-names = "qdsp6", "rmb";
>
> Binding needs update?
>
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml:
>
> reg:
> maxItems: 1
>
>>
>> interrupts-extended = <&intc GIC_SPI 264 IRQ_TYPE_EDGE_RISING>,
>> <&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
>> @@ -597,8 +598,11 @@
>> interrupt-names = "wdog", "fatal", "ready", "handover",
>> "stop-ack", "shutdown-ack";
>>
>> - clocks = <&rpmhcc RPMH_CXO_CLK>;
>> - clock-names = "xo";
>> + clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>> + <&gcc GCC_MSS_OFFLINE_AXI_CLK>,
>> + <&gcc GCC_MSS_SNOC_AXI_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> + clock-names = "iface", "offline", "snoc_axi", "xo";
>
> Binding needs update?
>
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml:
>
> clocks:
> items:
> - description: XO clock
> clock-names:
> items:
> - const: xo
qcom,sc7280-mpss-pas compatible requires
just the xo clock and one reg space whereas
the qcom,sc7280-mss-pil compatible requires
the additional clks and reg spaces. We just
overload properties where re-use is possible
across boards. Hence it would be wrong to
list those clks/reg spaces as requirements
for the pas compatible.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-06-30 20:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 19:47 [PATCH 0/9] Add Modem support on SC7280 SoCs Sibi Sankar
2021-06-24 19:47 ` [PATCH 1/9] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support Sibi Sankar
2021-06-25 17:12 ` Matthias Kaehlcke
2021-06-25 17:12 ` Matthias Kaehlcke
2021-06-25 17:28 ` Sibi Sankar
2021-06-25 23:20 ` Matthias Kaehlcke
2021-06-25 23:20 ` Matthias Kaehlcke
2021-07-14 19:36 ` Rob Herring
2021-07-14 19:36 ` Rob Herring
2021-06-24 19:47 ` [PATCH 2/9] remoteproc: qcom: pas: Add SC7280 Modem support Sibi Sankar
2021-06-25 23:23 ` Matthias Kaehlcke
2021-06-25 23:23 ` Matthias Kaehlcke
2021-06-24 19:47 ` [PATCH 3/9] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding Sibi Sankar
2021-06-25 23:43 ` Matthias Kaehlcke
2021-06-25 23:43 ` Matthias Kaehlcke
2021-06-30 19:57 ` Sibi Sankar
2021-07-14 19:37 ` Rob Herring
2021-07-14 19:37 ` Rob Herring
2021-06-24 19:47 ` [PATCH 4/9] iommu/arm-smmu-qcom: Request direct mapping for modem device Sibi Sankar
2021-06-25 4:27 ` Sai Prakash Ranjan
2021-06-24 19:47 ` [PATCH 5/9] remoteproc: mss: q6v5-mss: Add modem support on SC7280 Sibi Sankar
2021-06-25 0:35 ` Matthias Kaehlcke
2021-06-25 0:35 ` Matthias Kaehlcke
2021-06-25 14:21 ` Sibi Sankar
2021-06-25 16:39 ` Matthias Kaehlcke
2021-06-25 16:39 ` Matthias Kaehlcke
2021-06-24 19:47 ` [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Sibi Sankar
2021-06-28 18:11 ` Matthias Kaehlcke
2021-06-28 18:11 ` Matthias Kaehlcke
2021-06-30 20:02 ` Sibi Sankar
2021-07-30 18:24 ` Bjorn Andersson
2021-07-30 18:24 ` Bjorn Andersson
2021-06-24 19:47 ` [PATCH 7/9] arm64: dts: qcom: sc7280: Add nodes to boot modem Sibi Sankar
2021-07-30 18:00 ` Bjorn Andersson
2021-07-30 18:00 ` Bjorn Andersson
2021-06-24 19:47 ` [PATCH 8/9] arm64: dts: qcom: sc7280: Add Q6V5 MSS node Sibi Sankar
2021-06-28 18:39 ` Matthias Kaehlcke
2021-06-28 18:39 ` Matthias Kaehlcke
2021-06-30 20:03 ` Sibi Sankar
2021-07-30 18:01 ` Bjorn Andersson
2021-07-30 18:01 ` Bjorn Andersson
2021-06-24 19:47 ` [PATCH 9/9] arm64: dts: qcom: sc7280: Update " Sibi Sankar
2021-06-28 19:05 ` Matthias Kaehlcke
2021-06-28 19:05 ` Matthias Kaehlcke
2021-06-30 20:08 ` Sibi Sankar [this message]
2021-07-30 18:14 ` Bjorn Andersson
2021-07-30 18:14 ` Bjorn Andersson
2021-07-01 20:02 ` [PATCH 0/9] Add Modem support on SC7280 SoCs Pavel Machek
2021-07-01 20:02 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c561f99cb281c28581d10e5805190df8@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.