From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Rob Clark <robdclark@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support
Date: Tue, 2 Aug 2022 10:02:54 +0300 [thread overview]
Message-ID: <c5f6c092-e7ce-2f69-f712-2b8a0a959f32@linaro.org> (raw)
In-Reply-To: <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid>
On 30/07/2022 12:17, Akhil P Oommen wrote:
> Allow a consumer driver to poll for cx gdsc collapse through Reset
> framework.
>
> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> ---
>
> drivers/clk/qcom/gpucc-sc7280.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c
> index 9a832f2..f5df51d 100644
> --- a/drivers/clk/qcom/gpucc-sc7280.c
> +++ b/drivers/clk/qcom/gpucc-sc7280.c
> @@ -433,12 +433,18 @@ static const struct regmap_config gpu_cc_sc7280_regmap_config = {
> .fast_io = true,
> };
>
> +static const struct qcom_reset_map gpucc_sc7280_resets[] = {
> + [GPU_CX_COLLAPSE] = { .op = gdsc_wait_for_collapse, .priv = &cx_gdsc },
This will break bisectability. Please swap this one and the patch 4.
> +};
> +
> static const struct qcom_cc_desc gpu_cc_sc7280_desc = {
> .config = &gpu_cc_sc7280_regmap_config,
> .clks = gpu_cc_sc7280_clocks,
> .num_clks = ARRAY_SIZE(gpu_cc_sc7280_clocks),
> .gdscs = gpu_cc_sc7180_gdscs,
> .num_gdscs = ARRAY_SIZE(gpu_cc_sc7180_gdscs),
> + .resets = gpucc_sc7280_resets,
> + .num_resets = ARRAY_SIZE(gpucc_sc7280_resets),
> };
>
> static const struct of_device_id gpu_cc_sc7280_match_table[] = {
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Rob Clark <robdclark@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support
Date: Tue, 2 Aug 2022 10:02:54 +0300 [thread overview]
Message-ID: <c5f6c092-e7ce-2f69-f712-2b8a0a959f32@linaro.org> (raw)
In-Reply-To: <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid>
On 30/07/2022 12:17, Akhil P Oommen wrote:
> Allow a consumer driver to poll for cx gdsc collapse through Reset
> framework.
>
> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> ---
>
> drivers/clk/qcom/gpucc-sc7280.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c
> index 9a832f2..f5df51d 100644
> --- a/drivers/clk/qcom/gpucc-sc7280.c
> +++ b/drivers/clk/qcom/gpucc-sc7280.c
> @@ -433,12 +433,18 @@ static const struct regmap_config gpu_cc_sc7280_regmap_config = {
> .fast_io = true,
> };
>
> +static const struct qcom_reset_map gpucc_sc7280_resets[] = {
> + [GPU_CX_COLLAPSE] = { .op = gdsc_wait_for_collapse, .priv = &cx_gdsc },
This will break bisectability. Please swap this one and the patch 4.
> +};
> +
> static const struct qcom_cc_desc gpu_cc_sc7280_desc = {
> .config = &gpu_cc_sc7280_regmap_config,
> .clks = gpu_cc_sc7280_clocks,
> .num_clks = ARRAY_SIZE(gpu_cc_sc7280_clocks),
> .gdscs = gpu_cc_sc7180_gdscs,
> .num_gdscs = ARRAY_SIZE(gpu_cc_sc7180_gdscs),
> + .resets = gpucc_sc7280_resets,
> + .num_resets = ARRAY_SIZE(gpucc_sc7280_resets),
> };
>
> static const struct of_device_id gpu_cc_sc7280_match_table[] = {
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-08-02 7:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 9:17 [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-07-30 9:17 ` [PATCH 1/5] dt-bindings: clk: qcom: Support gpu cx gdsc reset Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-08-03 6:37 ` Krzysztof Kozlowski
2022-08-03 6:37 ` Krzysztof Kozlowski
2022-07-30 9:17 ` [PATCH 2/5] clk: qcom: Allow custom reset ops Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-07-30 13:10 ` kernel test robot
2022-08-01 15:20 ` [Freedreno] " Akhil P Oommen
2022-08-01 15:20 ` Akhil P Oommen
2022-08-01 15:20 ` Akhil P Oommen
2022-08-02 7:06 ` Dmitry Baryshkov
2022-08-02 7:06 ` Dmitry Baryshkov
2022-07-30 9:17 ` [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-08-02 7:02 ` Dmitry Baryshkov [this message]
2022-08-02 7:02 ` Dmitry Baryshkov
2022-08-02 7:15 ` Dmitry Baryshkov
2022-08-02 7:15 ` Dmitry Baryshkov
2022-08-03 10:20 ` Akhil P Oommen
2022-08-03 10:20 ` Akhil P Oommen
2022-07-30 9:17 ` [PATCH 4/5] clk: qcom: gdsc: Add a reset op to poll gdsc collapse Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-07-30 9:17 ` [PATCH 5/5] arm64: dts: qcom: sc7280: Add Reset support for gpu Akhil P Oommen
2022-07-30 9:17 ` Akhil P Oommen
2022-08-02 7:02 ` [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface Dmitry Baryshkov
2022-08-02 7:02 ` Dmitry Baryshkov
2022-08-02 18:32 ` Rob Clark
2022-08-02 18:32 ` Rob Clark
2022-08-03 10:01 ` Akhil P Oommen
2022-08-03 10:01 ` Akhil P Oommen
2022-08-09 21:05 ` Bjorn Andersson
2022-08-09 21:05 ` Bjorn Andersson
2022-08-11 11:15 ` Akhil P Oommen
2022-08-11 11:15 ` Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f6c092-e7ce-2f69-f712-2b8a0a959f32@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.