All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: m.deepak@intel.com, yetundex.adebisi@intel.com,
	intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 0/1] drm/i915: connector specific backlight hooks for eDP/DSI
Date: Mon, 14 Sep 2015 14:03:47 +0300	[thread overview]
Message-ID: <cover.1442227790.git.jani.nikula@intel.com> (raw)

Hi all -

This patch moves the backlight hooks from dev_priv->display to
intel_panel. This should enable connector specific backlight control
mechanisms, such as DPCD for eDP and DCS commands for DSI, to be neatly
connected to the existing backlight infrastructure.

Basically it should be sufficient to just point the hooks at the
specific backlight control mechanisms, and let the generic code be. You
can still add those mechanisms to separate files. There should be very
little to no special casing anywhere, apart from the hooks themselves.

This is in response to the two new backlight control mechanisms in
flight, for eDP [1] and DSI [2]. We should not quickly bolt on these
mechanisms when there's a better way with not much extra effort.

This patch is untested, but there's no rocket science here. I just
wanted this quickly out.

BR,
Jani.


[1] http://mid.gmane.org/1441894302-28475-1-git-send-email-yetundex.adebisi@intel.com
[2] http://mid.gmane.org/1441946868-4985-1-git-send-email-m.deepak@intel.com


Jani Nikula (1):
  drm/i915: make backlight hooks connector specific

 drivers/gpu/drm/i915/i915_drv.h      |   9 ---
 drivers/gpu/drm/i915/intel_display.c |   2 -
 drivers/gpu/drm/i915/intel_dp.c      |   2 +-
 drivers/gpu/drm/i915/intel_drv.h     |  13 +++-
 drivers/gpu/drm/i915/intel_panel.c   | 116 +++++++++++++++++++----------------
 5 files changed, 74 insertions(+), 68 deletions(-)

-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-09-14 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 11:03 Jani Nikula [this message]
2015-09-14 11:03 ` [PATCH 1/1] drm/i915: make backlight hooks connector specific Jani Nikula
2015-09-14 14:17   ` Daniel Vetter
2015-09-15  7:00     ` Jani Nikula
2015-09-29 10:10       ` Deepak, M
2015-09-29  9:43   ` Adebisi, YetundeX
2015-09-14 12:29 ` [PATCH 0/1] drm/i915: connector specific backlight hooks for eDP/DSI Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1442227790.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=m.deepak@intel.com \
    --cc=yetundex.adebisi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.