From: Marek Vasut <marex@denx.de>
To: E Shattow <lucent@gmail.com>
Cc: Tim Harvey <tharvey@gateworks.com>, Tom Rini <trini@konsulko.com>,
Simon Glass <sjg@chromium.org>,
Fabio Estevam <festevam@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de, Dragan Simic <dsimic@manjaro.org>
Subject: Re: [PATCH v3] mmc: allow use of hardware partition names for mmc partconf
Date: Sat, 27 Apr 2024 12:22:08 +0200 [thread overview]
Message-ID: <d8a77dd7-39bf-4ccd-979a-97eedb054b36@denx.de> (raw)
In-Reply-To: <CANV2PTOQknpnfKsZQC9Tr0AhZgMQOOTTND0T+WMp8pwv-5TNdQ@mail.gmail.com>
On 4/27/24 3:29 AM, E Shattow wrote:
> Hi Marek,
>
> On Fri, Apr 26, 2024 at 5:49 PM Marek Vasut <marex@denx.de> wrote:
>>
>> [...]
>>
>>> diff --git a/include/mmc.h b/include/mmc.h
>>> index 4b8327f1f93b..7243bd761202 100644
>>> --- a/include/mmc.h
>>> +++ b/include/mmc.h
>>> @@ -381,6 +381,21 @@ enum mmc_voltage {
>>> #define MMC_TIMING_MMC_HS200 9
>>> #define MMC_TIMING_MMC_HS400 10
>>>
>>> +/* emmc hardware partition values */
>>> +enum emmc_hwpart {
>>> + EMMC_HWPART_DEFAULT = 0,
>>> + EMMC_HWPART_BOOT0 = 1,
>>> + EMMC_HWPART_BOOT1 = 2,
>>> + EMMC_HWPART_GP1 = 3,
>>> + EMMC_HWPART_GP2 = 4,
>>> + EMMC_HWPART_GP3 = 5,
>>> + EMMC_HWPART_GP4 = 6,
>>> + EMMC_HWPART_USER = 7,
>>> +};
>>> +
>>> +/* emmc hardware partition names */
>>> +extern const char *emmc_hwpart_names[];
>>
>> Maybe the array should have fixed size here, i.e. 8 ?
>
> Is there an ABI reason to do so? Can you explain further why it would
> be needed to do that?
It has nothing to do with ABI, it is only to let the compiler validate
that nobody would index the array with index > 7 by accident.
next prev parent reply other threads:[~2024-04-27 10:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 0:11 [PATCH v3] mmc: allow use of hardware partition names for mmc partconf Tim Harvey
2024-04-27 0:48 ` Marek Vasut
2024-04-27 1:29 ` E Shattow
2024-04-27 10:22 ` Marek Vasut [this message]
2024-04-27 12:06 ` E Shattow
2024-04-27 23:19 ` Marek Vasut
2024-04-27 23:20 ` Marek Vasut
2024-04-29 16:48 ` Tim Harvey
2024-04-29 20:15 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8a77dd7-39bf-4ccd-979a-97eedb054b36@denx.de \
--to=marex@denx.de \
--cc=dsimic@manjaro.org \
--cc=festevam@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=lucent@gmail.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.