From: Marek Vasut <marex@denx.de>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Fabio Estevam <festevam@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
u-boot@lists.denx.de, Dragan Simic <dsimic@manjaro.org>
Subject: Re: [PATCH v3] mmc: allow use of hardware partition names for mmc partconf
Date: Mon, 29 Apr 2024 22:15:39 +0200 [thread overview]
Message-ID: <ef623aca-ead7-42dc-bacf-6cb51bdfba41@denx.de> (raw)
In-Reply-To: <CAJ+vNU0R5iTgS2_C_OV2VYh5fQnyPV-Lw003CTJAkp1Q6Qdedg@mail.gmail.com>
On 4/29/24 6:48 PM, Tim Harvey wrote:
> On Sat, Apr 27, 2024 at 4:20 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 4/27/24 2:11 AM, Tim Harvey wrote:
>>
>> [...]
>>
>>> diff --git a/include/mmc.h b/include/mmc.h
>>> index 4b8327f1f93b..7243bd761202 100644
>>> --- a/include/mmc.h
>>> +++ b/include/mmc.h
>>> @@ -381,6 +381,21 @@ enum mmc_voltage {
>>> #define MMC_TIMING_MMC_HS200 9
>>> #define MMC_TIMING_MMC_HS400 10
>>>
>>> +/* emmc hardware partition values */
>>> +enum emmc_hwpart {
>>> + EMMC_HWPART_DEFAULT = 0,
>>
>> One more thing ... eMMC hardware partition 0 and 7 are both referring to
>> USER HW partition. Have a look at the git log, there have been patches
>> which handled this case in the MMC subsystem from about a year ago.
>
> Hi Marek,
>
> I can't find what you are referring to. I assume you are talking about
> calling the first name something other than 'user' as technically it's
> not (but it gets treated as user).
>
> Can you find the commit or discussion you are thinking about?
It seems this whole thing is much older:
7dbe63bc950b ("SPL: Add CONFIG_SUPPORT_EMMC_BOOT support to
CONFIG_SPL_FRAMEWORK")
+ * We need to check what the partition is configured to.
+ * 1 and 2 match up to boot0 / boot1 and 7 is user data
+ * which is the first physical partition (0).
+ */
+ int part = (mmc->part_config >> 3) & PART_ACCESS_MASK;
+
+ if (part == 7)
+ part = 0;
next prev parent reply other threads:[~2024-04-29 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 0:11 [PATCH v3] mmc: allow use of hardware partition names for mmc partconf Tim Harvey
2024-04-27 0:48 ` Marek Vasut
2024-04-27 1:29 ` E Shattow
2024-04-27 10:22 ` Marek Vasut
2024-04-27 12:06 ` E Shattow
2024-04-27 23:19 ` Marek Vasut
2024-04-27 23:20 ` Marek Vasut
2024-04-29 16:48 ` Tim Harvey
2024-04-29 20:15 ` Marek Vasut [this message]
2024-05-13 20:52 ` Tim Harvey
2024-05-13 23:02 ` Marek Vasut
2024-05-14 12:05 ` Dragan Simic
2024-05-14 16:31 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef623aca-ead7-42dc-bacf-6cb51bdfba41@denx.de \
--to=marex@denx.de \
--cc=dsimic@manjaro.org \
--cc=festevam@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.