From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Simon Glass <sjg@chromium.org>
Cc: "Pali Rohár" <pali@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Tom Rini" <trini@konsulko.com>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Faiz Abbas" <faiz_abbas@ti.com>
Subject: Re: [PATCH 6/7] lib: Create a new Kconfig option for charset conversion
Date: Mon, 28 Jun 2021 12:37:49 +0200 [thread overview]
Message-ID: <ead4a472-922b-d3c3-4c46-fa605a3a2369@gmx.de> (raw)
In-Reply-To: <20210627194836.6.I70d4b350a1d009c7cd793ac207b9dc934e53c135@changeid>
On 6/28/21 3:48 AM, Simon Glass wrote:
> Rather than looking at two KConfig options in the Makefile, create a new
> Kconfig option for compiling lib/charset.c
>
> Enable it for UFS also, which needs this support.
+CC Faiz, maintainer UFS
Function utf16_to_utf8() is used in ufshcd_read_string_desc(). It
assumes that UTF-16 is using CPU endianness. What does UFS require on
big-endian systems?
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> lib/Kconfig | 8 ++++++++
> lib/Makefile | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index ad0cd52edd8..e1415799965 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -40,6 +40,14 @@ config CC_OPTIMIZE_LIBS_FOR_SPEED
>
> If unsure, say N.
>
> +config CHARSET
> + bool
> + default y if UT_UNICODE || EFI_LOADER || UFS
> + help
> + Enables support for various conversions between different
> + character sets, such as between unicode representations and
> + different 'code pages'.
> +
> config DYNAMIC_CRC_TABLE
> bool "Enable Dynamic tables for CRC"
> help
> diff --git a/lib/Makefile b/lib/Makefile
> index 881034f4ae3..2d2b273ccef 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -25,7 +25,7 @@ obj-$(CONFIG_AES) += aes/
> obj-$(CONFIG_$(SPL_TPL_)BINMAN_FDT) += binman.o
>
> ifndef API_BUILD
> -ifneq ($(CONFIG_UT_UNICODE)$(CONFIG_EFI_LOADER),)
> +ifneq ($(CONFIG_CHARSET),)
> obj-y += charset.o
> endif
> endif
>
next prev parent reply other threads:[~2021-06-28 10:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 1:48 [PATCH 0/7] efi: Various tidy-ups and drop the default Simon Glass
2021-06-28 1:48 ` [PATCH 1/7] configs: Resync with savedefconfig Simon Glass
2021-06-28 1:48 ` [PATCH 2/7] Makefile: Drop include/asm directory as well as symlink Simon Glass
2021-06-28 1:48 ` [PATCH 3/7] disk: Tidy up #ifdefs in part_efi Simon Glass
2021-06-28 11:20 ` Heinrich Schuchardt
2021-06-28 13:50 ` Tom Rini
2021-06-28 16:18 ` Heinrich Schuchardt
2021-06-28 1:48 ` [PATCH 4/7] Use LIB_UUID with ACPIGEN and FS_BTRFS Simon Glass
2021-06-28 1:48 ` [PATCH 5/7] Allow efi_loader header to be included always Simon Glass
2021-06-28 11:02 ` Heinrich Schuchardt
2021-06-28 1:48 ` [PATCH 6/7] lib: Create a new Kconfig option for charset conversion Simon Glass
2021-06-28 10:37 ` Heinrich Schuchardt [this message]
2021-06-28 1:48 ` [PATCH 7/7] efi: Make EBBR optional Simon Glass
2021-06-28 9:48 ` Heinrich Schuchardt
2021-06-28 13:48 ` Tom Rini
2021-06-28 8:38 ` [PATCH 0/7] efi: Various tidy-ups and drop the default Mark Kettenis
2021-06-28 8:59 ` Ilias Apalodimas
2021-06-28 13:37 ` Tom Rini
2021-06-28 14:18 ` Simon Glass
2021-06-28 15:20 ` Heinrich Schuchardt
2021-06-28 16:26 ` Simon Glass
2021-06-28 17:09 ` Heinrich Schuchardt
2021-06-28 18:02 ` Simon Glass
2021-06-28 17:27 ` Tom Rini
2021-06-28 18:08 ` Simon Glass
2021-06-29 12:56 ` AKASHI Takahiro
2021-06-29 14:01 ` Heinrich Schuchardt
2021-06-29 14:14 ` AKASHI Takahiro
2021-06-28 17:49 ` Mark Kettenis
2021-07-02 19:05 ` Simon Glass
2021-07-02 19:48 ` Mark Kettenis
2021-07-02 20:09 ` Tom Rini
2021-07-02 20:47 ` Simon Glass
2021-06-28 14:25 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead4a472-922b-d3c3-4c46-fa605a3a2369@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=faiz_abbas@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.