From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Luiz Sampaio <sampaio.ime@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 16/31] net: broadcom: changing LED_* from enum led_brightness to actual value
Date: Sat, 22 Jan 2022 09:21:58 +0100 [thread overview]
Message-ID: <dd9e469a-b1ab-30d1-8f9f-946d4b323c35@broadcom.com> (raw)
In-Reply-To: <20220121165436.30956-17-sampaio.ime@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]
On 1/21/2022 5:54 PM, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
The commit message sounds a bit obscure to me. You say the
led_brightness enumeration is or rather will become obsolete. I don't
understand the reason given "led class now supports max_brightness".
What does that mean?
Also I do not understand the approach here. If the enum is obsolete why
not start with the APIs using it like the led callbacks
brightness_{get,set{,_blocking}}. I suspect that is your next step, but
it seems like unnecessary churn to me.
Anyway, what triggered me to look at this is the fact that we do have a
led.c under drivers/net/wireless/broadcom/brcm80211/brcmsmac
implementing the brightness_set() callback.
Regards,
Arend
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2022-01-22 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220121165436.30956-1-sampaio.ime@gmail.com>
2022-01-21 16:54 ` [PATCH 16/31] net: broadcom: changing LED_* from enum led_brightness to actual value Luiz Sampaio
2022-01-22 8:21 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9e469a-b1ab-30d1-8f9f-946d4b323c35@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sampaio.ime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).