From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: colyli@suse.de, kent.overstreet@linux.dev, msakai@redhat.com,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, akpm@linux-foundation.org
Cc: bfoster@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
jserv@ccns.ncku.edu.tw, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
linux-bcachefs@vger.kernel.org, linux-perf-users@vger.kernel.org,
Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH v4 14/16] lib/test_min_heap: Add test for heap_del()
Date: Thu, 25 Apr 2024 22:18:24 +0800 [thread overview]
Message-ID: <20240425141826.840077-15-visitorckw@gmail.com> (raw)
In-Reply-To: <20240425141826.840077-1-visitorckw@gmail.com>
Add test cases for the min_heap_del() to ensure its functionality is
thoroughly tested.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Ian Rogers <irogers@google.com>
---
lib/test_min_heap.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
index 0b5037b4bd68..d40851cfd824 100644
--- a/lib/test_min_heap.c
+++ b/lib/test_min_heap.c
@@ -165,6 +165,40 @@ static __init int test_heap_pop_push(bool min_heap)
return err;
}
+static __init int test_heap_del(bool min_heap)
+{
+ int values[] = { 3, 1, 2, 4, 0x8000000, 0x7FFFFFF, 0,
+ -3, -1, -2, -4, 0x8000000, 0x7FFFFFF };
+ struct min_heap_test heap;
+
+ min_heap_init(&heap, values, ARRAY_SIZE(values));
+ heap.nr = ARRAY_SIZE(values);
+ struct min_heap_callbacks funcs = {
+ .less = min_heap ? less_than : greater_than,
+ .swp = swap_ints,
+ };
+ int i, err;
+
+ /* Test with known set of values. */
+ min_heapify_all(&heap, &funcs, NULL);
+ for (i = 0; i < ARRAY_SIZE(values) / 2; i++)
+ min_heap_del(&heap, get_random_u32() % heap.nr, &funcs, NULL);
+ err = pop_verify_heap(min_heap, &heap, &funcs);
+
+
+ /* Test with randomly generated values. */
+ heap.nr = ARRAY_SIZE(values);
+ for (i = 0; i < heap.nr; i++)
+ values[i] = get_random_u32();
+ min_heapify_all(&heap, &funcs, NULL);
+
+ for (i = 0; i < ARRAY_SIZE(values) / 2; i++)
+ min_heap_del(&heap, get_random_u32() % heap.nr, &funcs, NULL);
+ err += pop_verify_heap(min_heap, &heap, &funcs);
+
+ return err;
+}
+
static int __init test_min_heap_init(void)
{
int err = 0;
@@ -175,6 +209,8 @@ static int __init test_min_heap_init(void)
err += test_heap_push(false);
err += test_heap_pop_push(true);
err += test_heap_pop_push(false);
+ err += test_heap_del(true);
+ err += test_heap_del(false);
if (err) {
pr_err("test failed with %d errors\n", err);
return -EINVAL;
--
2.34.1
next prev parent reply other threads:[~2024-04-25 14:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 14:18 [PATCH v4 00/16] treewide: Refactor heap related implementation Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 01/16] perf/core: Fix several typos Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 02/16] bcache: Fix typo Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 03/16] bcachefs: " Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 04/16] lib min_heap: Add type safe interface Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 05/16] lib min_heap: Add min_heap_init() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 06/16] lib min_heap: Add min_heap_peek() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 07/16] lib min_heap: Add min_heap_full() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 08/16] lib min_heap: Add args for min_heap_callbacks Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 09/16] lib min_heap: Add min_heap_sift_up() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 10/16] lib min_heap: Add min_heap_del() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 11/16] lib min_heap: Update min_heap_push() and min_heap_pop() to return bool values Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 12/16] lib min_heap: Rename min_heapify() to min_heap_sift_down() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 13/16] lib min_heap: Update min_heap_push() to use min_heap_sift_up() Kuan-Wei Chiu
2024-04-25 14:18 ` Kuan-Wei Chiu [this message]
2024-04-25 14:18 ` [PATCH v4 15/16] bcache: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 16/16] bcachefs: " Kuan-Wei Chiu
2024-04-25 20:54 ` [PATCH v4 00/16] treewide: Refactor heap related implementation Kent Overstreet
2024-04-26 0:14 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425141826.840077-15-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bfoster@redhat.com \
--cc=colyli@suse.de \
--cc=dm-devel@lists.linux.dev \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).