From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
colyli@suse.de, msakai@redhat.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
akpm@linux-foundation.org, bfoster@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
jserv@ccns.ncku.edu.tw, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
linux-bcachefs@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 00/16] treewide: Refactor heap related implementation
Date: Fri, 26 Apr 2024 08:14:25 +0800 [thread overview]
Message-ID: <Zirx4fCA8C6/hz8m@visitorckw-System-Product-Name> (raw)
In-Reply-To: <txga7kntgxylhmxqkzs3rdgmnjai2ftlstdezltkapdctn3ju6@ndyytejfyoc2>
On Thu, Apr 25, 2024 at 04:54:54PM -0400, Kent Overstreet wrote:
> Hey Stephen, I think this is ready for -next.
>
> https://github.com/visitorckw/linux.git refactor-heap-v4
>
> Kuan, please add my acked-by to the bcachefs patch as well.
>
Acked-by tag has been added to the repository mentioned above and
pushed out.
Regards,
Kuan-Wei
>
> On Thu, Apr 25, 2024 at 10:18:10PM +0800, Kuan-Wei Chiu wrote:
> > This patch series focuses on several adjustments related to heap
> > implementation. Firstly, a type-safe interface has been added to the
> > min_heap, along with the introduction of several new functions to
> > enhance its functionality. Additionally, the heap implementation for
> > bcache and bcachefs has been replaced with the generic min_heap
> > implementation from include/linux. Furthermore, several typos have been
> > corrected.
> >
> > Previous discussion with Kent Overstreet:
> > https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu
> >
> > Regards,
> > Kuan-Wei
> >
> > ---
> >
> > You can preview this patch series on the 'refactor-heap-v4' branch of
> > the repository at the following link:
> >
> > https://github.com/visitorckw/linux.git
> >
> > Changes in v4:
> > - Change struct initializations to use designated initializers.
> > - Replace memcpy() with func->swp() in heap_del() due to issues with
> > set_backpointer in bcachefs when setting idx.
> > - Fix an error in ec_stripes_heap_swap() where
> > ec_stripes_heap_set_backpointer() should be called after swapping.
> >
> > Changes in v3:
> > - Avoid heap->heap.nr to eliminate the nested types.
> > - Add MIN_HEAP_PREALLOCATED macro for preallocating some elements.
> > - Use min_heap_sift_up() in min_heap_push().
> > - Fix a bug in heap_del() where we should copy the last element to
> > 'data + idx * element_size' instead of 'data'.
> > - Add testcases for heap_del().
> > - Fix bugs in bcache/bcachefs patches where the parameter types in
> > some compare functions should have been 'type **', but were
> > mistakenly written as 'type *'.
> >
> > Changes in v2:
> > - Add attribute __always_unused to the compare and swap functions
> > that do not use the args parameter.
> > - Rename min_heapify() to min_heap_sift_down().
> > - Update lib/test_min_heap.c to use min_heap_init().
> > - Refine the commit message for bcache and bcachefs.
> > - Adjust the order of patches in the patch series.
> >
> > Link to v3: https://lore.kernel.org/20240406164727.577914-1-visitorckw@gmail.com
> > Link to v2: https://lore.kernel.org/20240320145417.336208-1-visitorckw@gmail.com
> > Link to v1: https://lkml.kernel.org/20240319180005.246930-1-visitorckw@gmail.com
> >
> > Kuan-Wei Chiu (16):
> > perf/core: Fix several typos
> > bcache: Fix typo
> > bcachefs: Fix typo
> > lib min_heap: Add type safe interface
> > lib min_heap: Add min_heap_init()
> > lib min_heap: Add min_heap_peek()
> > lib min_heap: Add min_heap_full()
> > lib min_heap: Add args for min_heap_callbacks
> > lib min_heap: Add min_heap_sift_up()
> > lib min_heap: Add min_heap_del()
> > lib min_heap: Update min_heap_push() and min_heap_pop() to return bool
> > values
> > lib min_heap: Rename min_heapify() to min_heap_sift_down()
> > lib min_heap: Update min_heap_push() to use min_heap_sift_up()
> > lib/test_min_heap: Add test for heap_del()
> > bcache: Remove heap-related macros and switch to generic min_heap
> > bcachefs: Remove heap-related macros and switch to generic min_heap
> >
> > drivers/md/bcache/alloc.c | 64 ++++++++---
> > drivers/md/bcache/bcache.h | 2 +-
> > drivers/md/bcache/bset.c | 84 ++++++++++-----
> > drivers/md/bcache/bset.h | 14 +--
> > drivers/md/bcache/btree.c | 17 ++-
> > drivers/md/bcache/extents.c | 53 ++++++----
> > drivers/md/bcache/movinggc.c | 41 +++++--
> > drivers/md/bcache/sysfs.c | 2 +
> > drivers/md/bcache/util.c | 2 +-
> > drivers/md/bcache/util.h | 67 +-----------
> > drivers/md/bcache/writeback.c | 3 +
> > drivers/md/dm-vdo/repair.c | 19 ++--
> > drivers/md/dm-vdo/slab-depot.c | 14 +--
> > fs/bcachefs/clock.c | 43 ++++++--
> > fs/bcachefs/clock_types.h | 2 +-
> > fs/bcachefs/ec.c | 76 ++++++++-----
> > fs/bcachefs/ec_types.h | 2 +-
> > fs/bcachefs/util.c | 2 +-
> > fs/bcachefs/util.h | 118 +--------------------
> > include/linux/min_heap.h | 188 +++++++++++++++++++++++++--------
> > kernel/events/core.c | 29 ++---
> > lib/test_min_heap.c | 75 +++++++++----
> > 22 files changed, 522 insertions(+), 395 deletions(-)
> >
> > --
> > 2.34.1
> >
prev parent reply other threads:[~2024-04-26 0:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 14:18 [PATCH v4 00/16] treewide: Refactor heap related implementation Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 01/16] perf/core: Fix several typos Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 02/16] bcache: Fix typo Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 03/16] bcachefs: " Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 04/16] lib min_heap: Add type safe interface Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 05/16] lib min_heap: Add min_heap_init() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 06/16] lib min_heap: Add min_heap_peek() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 07/16] lib min_heap: Add min_heap_full() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 08/16] lib min_heap: Add args for min_heap_callbacks Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 09/16] lib min_heap: Add min_heap_sift_up() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 10/16] lib min_heap: Add min_heap_del() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 11/16] lib min_heap: Update min_heap_push() and min_heap_pop() to return bool values Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 12/16] lib min_heap: Rename min_heapify() to min_heap_sift_down() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 13/16] lib min_heap: Update min_heap_push() to use min_heap_sift_up() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 14/16] lib/test_min_heap: Add test for heap_del() Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 15/16] bcache: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-04-25 14:18 ` [PATCH v4 16/16] bcachefs: " Kuan-Wei Chiu
2024-04-25 20:54 ` [PATCH v4 00/16] treewide: Refactor heap related implementation Kent Overstreet
2024-04-26 0:14 ` Kuan-Wei Chiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zirx4fCA8C6/hz8m@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bfoster@redhat.com \
--cc=colyli@suse.de \
--cc=dm-devel@lists.linux.dev \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).